[
https://issues.apache.org/jira/browse/HDFS-12188?focusedWorklogId=637274&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637274
]
ASF GitHub Bot logged work on HDFS-12188:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Aug/21 07:39
Start Date: 12/Aug/21 07:39
Worklog Time Spent: 10m
Work Description: virajjasani commented on pull request #3280:
URL: https://github.com/apache/hadoop/pull/3280#issuecomment-897418170
Thanks @ferhui for the review.
> This PR tile is different from HDFS-12188
Updated Jira title because testDecommissionStatus test is present in both
`TestDecommissioningStatus` and `TestDecommissioningStatusWithBackoffMonitor`,
hence by just mentioning testDecommissionStatus, we are taking care of both
tests failures.
> Do you explain why test is flaky and how you fix it?
The no of under-replicated blocks on Datanode2 can either be 3 or 4
depending on actual blocks available in Datanode Storage. This is the only
reason behind flakiness, hence our logic should be check for count being 3/4.
If under replicated blocks are anything other than 3 or 4, then this test has
some other genuine failure case.
> I see you add synchronized to some functions, Does it help to fix flaky
problems?
Good point, it doesn't solve flaky problem as of now. I just kept it while
running 2 tests in parallel so that config setup is synchronized but now it is
not required. I will remove it. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 637274)
Time Spent: 40m (was: 0.5h)
> De-flake testDecommissionStatus
> -------------------------------
>
> Key: HDFS-12188
> URL: https://issues.apache.org/jira/browse/HDFS-12188
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: test
> Reporter: Brahma Reddy Battula
> Assignee: Ajay Kumar
> Priority: Major
> Labels: pull-request-available
> Attachments: TestFailure_Log.txt
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> {noformat}
> java.lang.AssertionError: Unexpected num under-replicated blocks expected:<3>
> but was:<4>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:743)
> at org.junit.Assert.assertEquals(Assert.java:118)
> at org.junit.Assert.assertEquals(Assert.java:555)
> at
> org.apache.hadoop.hdfs.server.namenode.TestDecommissioningStatus.checkDecommissionStatus(TestDecommissioningStatus.java:144)
> at
> org.apache.hadoop.hdfs.server.namenode.TestDecommissioningStatus.testDecommissionStatus(TestDecommissioningStatus.java:240)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
