[ https://issues.apache.org/jira/browse/HDFS-15393?focusedWorklogId=587619&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587619 ]
ASF GitHub Bot logged work on HDFS-15393: ----------------------------------------- Author: ASF GitHub Bot Created on: 23/Apr/21 04:09 Start Date: 23/Apr/21 04:09 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on pull request #2055: URL: https://github.com/apache/hadoop/pull/2055#issuecomment-825371322 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 0m 0s | | Docker mode activated. | | -1 :x: | patch | 0m 23s | | https://github.com/apache/hadoop/pull/2055 does not apply to trunk. Rebase required? Wrong Branch? See https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help. | | Subsystem | Report/Notes | |----------:|:-------------| | GITHUB PR | https://github.com/apache/hadoop/pull/2055 | | JIRA Issue | HDFS-15393 | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2055/1/console | | versions | git=2.17.1 | | Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 587619) Remaining Estimate: 0h Time Spent: 10m > Review of PendingReconstructionBlocks > ------------------------------------- > > Key: HDFS-15393 > URL: https://issues.apache.org/jira/browse/HDFS-15393 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: David Mollitor > Assignee: David Mollitor > Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > I started looking at this class based on [HDFS-15351]. > * Uses {{java.sql.Time}} unnecessarily. Confusing since Java ships with time > formatters out of the box in JDK 8. I believe this will cause issues later > when trying to upgrade to JDK 9+ since SQL is a different module in Java. > * Remove code where appropriate > * Use Java Concurrent library for higher concurrent access to underlying map -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org