[jira] [Commented] (HDFS-1473) Refactor storage management into separate classes than fsimage file reading/writing

[ https://issues.apache.org/jira/browse/HDFS-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13023016#comment-13023016 ] Hudson commented on HDFS-1473: -- Integrated in Hadoop-Hdfs-22-branch #35 (See

[jira] [Commented] (HDFS-1473) Refactor storage management into separate classes than fsimage file reading/writing

[ https://issues.apache.org/jira/browse/HDFS-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13022457#comment-13022457 ] Hudson commented on HDFS-1473: -- Integrated in Hadoop-Hdfs-trunk #643 (See

[jira] Commented: (HDFS-1473) Refactor storage management into separate classes than fsimage file reading/writing

[ https://issues.apache.org/jira/browse/HDFS-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12968440#action_12968440 ] Konstantin Shvachko commented on HDFS-1473: --- Could you please run tests or post

[jira] Commented: (HDFS-1473) Refactor storage management into separate classes than fsimage file reading/writing

[ https://issues.apache.org/jira/browse/HDFS-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12968460#action_12968460 ] Todd Lipcon commented on HDFS-1473: --- Since the patch is just renames, I didn't run the

[jira] Commented: (HDFS-1473) Refactor storage management into separate classes than fsimage file reading/writing

[ https://issues.apache.org/jira/browse/HDFS-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12966614#action_12966614 ] Todd Lipcon commented on HDFS-1473: --- I'll fix the save() - write() momentarily. As for

[jira] Commented: (HDFS-1473) Refactor storage management into separate classes than fsimage file reading/writing

[ https://issues.apache.org/jira/browse/HDFS-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12966317#action_12966317 ] Todd Lipcon commented on HDFS-1473: --- Hi Konstantin. Thanks for the review. I fixed points

[jira] Commented: (HDFS-1473) Refactor storage management into separate classes than fsimage file reading/writing

[ https://issues.apache.org/jira/browse/HDFS-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12966440#action_12966440 ] Konstantin Shvachko commented on HDFS-1473: --- The Saver should save() rather than

[jira] Commented: (HDFS-1473) Refactor storage management into separate classes than fsimage file reading/writing

[ https://issues.apache.org/jira/browse/HDFS-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12965525#action_12965525 ] Konstantin Shvachko commented on HDFS-1473: --- Sorry for late response. Was just

[jira] Commented: (HDFS-1473) Refactor storage management into separate classes than fsimage file reading/writing

[ https://issues.apache.org/jira/browse/HDFS-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12964587#action_12964587 ] Eli Collins commented on HDFS-1473: --- Hey Todd, Looks great. Why do we no longer

[jira] Commented: (HDFS-1473) Refactor storage management into separate classes than fsimage file reading/writing

[ https://issues.apache.org/jira/browse/HDFS-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12964614#action_12964614 ] Todd Lipcon commented on HDFS-1473: --- Hey Eli, Looks like the new files in the patch

[jira] Commented: (HDFS-1473) Refactor storage management into separate classes than fsimage file reading/writing

[ https://issues.apache.org/jira/browse/HDFS-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12964623#action_12964623 ] Eli Collins commented on HDFS-1473: --- Added. Sorry bout that. Refactor storage

[jira] Commented: (HDFS-1473) Refactor storage management into separate classes than fsimage file reading/writing

[ https://issues.apache.org/jira/browse/HDFS-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12935698#action_12935698 ] Ivan Kelly commented on HDFS-1473: -- Looks good. +1 Refactor storage management into

[jira] Commented: (HDFS-1473) Refactor storage management into separate classes than fsimage file reading/writing

[ https://issues.apache.org/jira/browse/HDFS-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12933864#action_12933864 ] Todd Lipcon commented on HDFS-1473: --- Unit test results: [junit] Test

[jira] Commented: (HDFS-1473) Refactor storage management into separate classes than fsimage file reading/writing

[ https://issues.apache.org/jira/browse/HDFS-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12933489#action_12933489 ] Hairong Kuang commented on HDFS-1473: - Sounds good to me. Personally I feel that it is

[jira] Commented: (HDFS-1473) Refactor storage management into separate classes than fsimage file reading/writing

[ https://issues.apache.org/jira/browse/HDFS-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12933303#action_12933303 ] Hairong Kuang commented on HDFS-1473: - In general, it looks good. 1. better merge

[jira] Commented: (HDFS-1473) Refactor storage management into separate classes than fsimage file reading/writing

[ https://issues.apache.org/jira/browse/HDFS-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1298#action_1298 ] Todd Lipcon commented on HDFS-1473: --- How about FSImageFormat, with two inner static