[
https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13022443#comment-13022443
]
Hudson commented on HDFS-1557:
--
Integrated in Hadoop-Hdfs-trunk #643 (See
[
https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12992592#comment-12992592
]
Hudson commented on HDFS-1557:
--
Integrated in Hadoop-Hdfs-trunk-Commit #539 (See
[
https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12989569#comment-12989569
]
Ivan Kelly commented on HDFS-1557:
--
That's great :) Thanks for your help on this and
[
https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12989260#comment-12989260
]
Todd Lipcon commented on HDFS-1557:
---
JCarder looks pretty good - one potential deadlock
[
https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12989303#comment-12989303
]
Hadoop QA commented on HDFS-1557:
-
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12989402#comment-12989402
]
Todd Lipcon commented on HDFS-1557:
---
+1 from me, looks great.
Separate Storage from
[
https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12989492#comment-12989492
]
Hadoop QA commented on HDFS-1557:
-
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12989495#comment-12989495
]
Jitendra Nath Pandey commented on HDFS-1557:
The three failed tests and
[
https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12989496#comment-12989496
]
Jitendra Nath Pandey commented on HDFS-1557:
Correction in previous comment:
[
https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12988977#comment-12988977
]
Jakob Homan commented on HDFS-1557:
---
This is a very difficult patch to review due to the
[
https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12988999#comment-12988999
]
Suresh Srinivas commented on HDFS-1557:
---
Most of the comments are minor:
#
[
https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12988998#comment-12988998
]
Suresh Srinivas commented on HDFS-1557:
---
Most of the comments are minor:
#
[
https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12989079#comment-12989079
]
Todd Lipcon commented on HDFS-1557:
---
I assume Suresh's comments were supposed to go to
[
https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12988175#action_12988175
]
Suresh Srinivas commented on HDFS-1557:
---
Some minor comments:
# add listeners.clear()
[
https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12988179#action_12988179
]
Suresh Srinivas commented on HDFS-1557:
---
Missed in my previous comment:
Change
[
https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12988211#action_12988211
]
Todd Lipcon commented on HDFS-1557:
---
Hey Ivan. Now that Suresh and Jitendra have taken a
[
https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12987865#action_12987865
]
Jitendra Nath Pandey commented on HDFS-1557:
I ran test-patch on the latest
[
https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12987185#action_12987185
]
Suresh Srinivas commented on HDFS-1557:
---
Some comments:
# Storage#deleteDir() javadoc
[
https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12984855#action_12984855
]
Jitendra Nath Pandey commented on HDFS-1557:
Couple of things I missed before
[
https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12983308#action_12983308
]
Ivan Kelly commented on HDFS-1557:
--
{quote}
-1 core tests. The patch failed these core unit
[
https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12983319#action_12983319
]
Todd Lipcon commented on HDFS-1557:
---
Hi Ivan. FYi TestConcurrentFileReader is definitely
[
https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982744#action_12982744
]
Hadoop QA commented on HDFS-1557:
-
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12982790#action_12982790
]
Hadoop QA commented on HDFS-1557:
-
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12981995#action_12981995
]
Jitendra Nath Pandey commented on HDFS-1557:
0. Please also comment on the
[
https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12978207#action_12978207
]
Hadoop QA commented on HDFS-1557:
-
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12976817#action_12976817
]
Flavio Junqueira commented on HDFS-1557:
Hi there, I was wondering if there is
[
https://issues.apache.org/jira/browse/HDFS-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12974641#action_12974641
]
Hadoop QA commented on HDFS-1557:
-
-1 overall. Here are the results of testing the latest
27 matches
Mail list logo