[hibernate-dev] [HSearch] Faceting feedback

2011-02-28 Thread Hardy Ferentschik
Hi, I thought it would be great to get some feedback on my faceting work. You can see the latest on my Search fork - https://github.com/hferentschik/hibernate-search/commits/HSEARCH-667 Technically I decided to use a simple custom Collector. I abandoned the idea for using bobo browse, since

Re: [hibernate-dev] hibernate-dev Digest, Vol 56, Issue 20

2011-02-28 Thread Marc Schipperheyn
I have a lot of experience with Bobo Browse. The code is well maintained and performs well. I don't have time to download and implement code examples, but if you have working examples up somewhere, I'd be happy to take a look. Vriendelijke groet, Marc On Mon, Feb 28, 2011 at 6:00 PM, wrote: >

Re: [hibernate-dev] hibernate-dev Digest, Vol 56, Issue 20

2011-02-28 Thread Hardy Ferentschik
Hi Marc, thanks for your feedback. Answers inline On Mon, 28 Feb 2011 19:08:43 +0100, Marc Schipperheyn wrote: > I have a lot of experience with Bobo Browse. The code is well maintained > and performs well. The last release was over a year back and personally I find the docs very sparse.

Re: [hibernate-dev] hibernate-dev Digest, Vol 56, Issue 20

2011-02-28 Thread Marc Schipperheyn
On Mon, Feb 28, 2011 at 7:29 PM, Hardy Ferentschik wrote: > Hi Marc, > > thanks for your feedback. Answers inline > > > On Mon, 28 Feb 2011 19:08:43 +0100, Marc Schipperheyn < > m.schipperh...@gmail.com> wrote: > > I have a lot of experience with Bobo Browse. The code is well maintained >> and p

Re: [hibernate-dev] hibernate-dev Digest, Vol 56, Issue 20

2011-02-28 Thread Marc Schipperheyn
My two cents: * Most of the magic of Bobo Browse apart from the faceting itself is in the performance. I think the challenge with any kind of faceting is keeping it performant which Bobo achieves through all sorts of optimized caches. * The problem for me with Bobo is real time updating the Bobo in

Re: [hibernate-dev] [HSearch] Faceting feedback

2011-02-28 Thread Sanne Grinovero
Hi Hardy, great job! I've been reading this focusing on the tests and the Collectors implementation. If you want me to have a look at all the patches, could you please squash some commits :) Comments: 1) why is it named SimpleFacetRequest, are you planning for a more advanced one? 2) I couldn't f

Re: [hibernate-dev] [HSearch] Faceting feedback

2011-02-28 Thread Hardy Ferentschik
Thanks for the feedback Sanne! On Mon, 28 Feb 2011 19:56:59 +0100, Sanne Grinovero wrote: > I've been reading this focusing on the tests and the Collectors > implementation. That's the most interesting part. There are a few unrelated cleanup and testing related commits which as you say I

Re: [hibernate-dev] hibernate-dev Digest, Vol 56, Issue 20

2011-02-28 Thread Hardy Ferentschik
On Mon, 28 Feb 2011 19:39:27 +0100, Marc Schipperheyn wrote: >> The last release was over a year back and personally I find the docs >> very sparse. I also think there is a lot of complexity in bob browse >> which is not needed for >> simple faceting. > My problem is that javadoc is horrib

Re: [hibernate-dev] hibernate-dev Digest, Vol 56, Issue 20

2011-02-28 Thread Hardy Ferentschik
On Mon, 28 Feb 2011 19:56:32 +0100, Marc Schipperheyn wrote: > My two cents: > * Most of the magic of Bobo Browse apart from the faceting itself is in > the performance. I think the challenge with any kind of faceting is > keeping it performant which Bobo achieves through all sorts of optim

[hibernate-dev] HV - Follow-Up: meta data API for method constraints

2011-02-28 Thread Gunnar Morling
Hi, I pretty much finished the implementation of the meta data API related to method level constraints for Hibernate Validator (see https://github.com/gunnarmorling/hibernate-validator/commits/HV-371). The implementation conforms with what we currently discussed, but right now I'm wondering wheth