Re: [hibernate-dev] OGM: CheckStyle and imports due to JavaDoc comments

2013-08-01 Thread Gunnar Morling
Does the concept of imports apply at runtime at all, or is this concept not only present at compile time, making life easier by allowing to refer to types using their simple name? In [1] it says about type names in class files: "Class and interface names that appear in class file structures are al

Re: [hibernate-dev] OGM: CheckStyle and imports due to JavaDoc comments

2013-08-01 Thread Sanne Grinovero
Let's relax this, the likelyhood of this introducing a real problem affecting the runtime is extremely low, and there are better ways to prevent that. I've reopened the issue. Longer reasoning + better proposal: - we're arguing only about things used in javadoc but not code, this: -- makes th

Re: [hibernate-dev] OGM: CheckStyle and imports due to JavaDoc comments

2013-08-01 Thread Hardy Ferentschik
On 1 Jan 2013, at 8:46 AM, Emmanuel Bernard wrote: > Of course my memory might be flawed but the problems I recall around > isolating a piece of code for hv, search and later bean validation from core > did not involve unused imports. Come to think of it, I have never seen an > *unused* impor

Re: [hibernate-dev] OGM: CheckStyle and imports due to JavaDoc comments

2013-08-01 Thread Hardy Ferentschik
On 1 Jan 2013, at 10:58 AM, Sanne Grinovero wrote: > Let's relax this, the likelyhood of this introducing a real problem > affecting the runtime is extremely low, and there are better ways to > prevent that. I've reopened the issue. Why? The few occasions where it happens a fully qualified clas

Re: [hibernate-dev] OGM: CheckStyle and imports due to JavaDoc comments

2013-08-01 Thread Sanne Grinovero
On 1 August 2013 10:41, Hardy Ferentschik wrote: [...] > > So why not be safe than sorry? > > --Hardy That's my same point, I just want to broaden the healthcheck, and am showing you other practical benefits from it, which happen IMHO to also have less annoying checks as a side effect, but that d

Re: [hibernate-dev] OGM: CheckStyle and imports due to JavaDoc comments

2013-08-01 Thread Emmanuel Bernard
On Thu 2013-08-01 11:41, Hardy Ferentschik wrote: > Why? The few occasions where it happens a fully qualified class name does not > hurt. > It is not enough that it is considered bad practise and even Checkstyle for > that > reason does not allow it in the UnusedImports check? I actually do fi

Re: [hibernate-dev] Static analysis report on thread safety of Hibernate

2013-08-01 Thread Scott Marlow
>> - The shared non-thread-safe content finding looks like it spots a >> symptom of a real bug: in the method 'getNamedEntityManagerFactory', a >> hashmap is extracted from a concurrent hash map and read from. >> Concurrently, there is the possibility that items are removed from the >>

[hibernate-dev] New stored procedure support

2013-08-01 Thread Christian Bauer
Some of the issues I've found with JPA 2.1 and the overall new stored procedure APIs: 1. StoredProcedureQuery#hasMoreResults() returns true if the next result is an update count, it should return false, according to API documentation. On MySQL, if a SP returns a single or multiple ResultSets, y

[hibernate-dev] IRC developer meeting - 8/1

2013-08-01 Thread Steve Ebersole
Discussed OGM development, progress on the new website design, and other topics.. [11:17] Meeting ended Thu Aug 1 16:16:57 2013 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) [11:17] Minutes: http://transcripts.jboss.org/meeting/irc.freenode.org/hibernate-dev/20

Re: [hibernate-dev] New stored procedure support

2013-08-01 Thread Steve Ebersole
Overall I am pretty confident you are not using the latest as we discussed on IRC. But some comments inline... On Thu 01 Aug 2013 10:30:04 AM CDT, Christian Bauer wrote: - show quoted text - Yes I think this is still a bug. I'll fix this. Its because of the concept of Returns. I should loo

Re: [hibernate-dev] Static analysis report on thread safety of Hibernate

2013-08-01 Thread Scott Marlow
On 08/01/2013 10:41 AM, Scott Marlow wrote: >>> - The shared non-thread-safe content finding looks like it spots a >>> symptom of a real bug: in the method 'getNamedEntityManagerFactory', a >>> hashmap is extracted from a concurrent hash map and read from. >>> Concurrently, there is

Re: [hibernate-dev] New stored procedure support

2013-08-01 Thread Christian Bauer
On 01.08.2013, at 19:01, Steve Ebersole wrote: >> 2. If there is only one ResultSet returned by the SP, I should be able to >> call StoredProcedureQuery#getResultList() without first calling >> hasMoreResults(). This maps to JDBC CallableStatement#excuteQuery(). > > Like I said, I don't think

Re: [hibernate-dev] New stored procedure support

2013-08-01 Thread Steve Ebersole
Actually thats easy. The following block in getResultList() should just go away: if ( outputs().hasMoreReturns() ) { outputs().getNextReturn(); } I just missed removing that when moving to the getCurrentReturn() model. On 08/01/2013 01:05 PM, Christian Bauer wrot

Re: [hibernate-dev] Static analysis report on thread safety of Hibernate

2013-08-01 Thread Sanne Grinovero
On 1 August 2013 06:54, Steve Ebersole wrote: > See inline... > > On 07/31/2013 06:08 AM, Sanne Grinovero wrote: > >> # Hibernate: >> >> Probably the best finding is the 'Shared non-thread-safe content' >> finding in the class 'EntityManagerFactoryRegistry'. In general, the >> inconsistent and mix

[hibernate-dev] Commit Often, Perfect Later, Publish Onceā€”Git Best Practices

2013-08-01 Thread Strong Liu
this seems interesting and useful http://sethrobertson.github.io/GitBestPractices/#read - Best Regards, Strong Liu http://about.me/stliu/bio ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.