Re: [hibernate-dev] Release Announcement: General Availability of JDK 9

2017-09-22 Thread Rory O'Donnell
Hi Sanne, Wiki updated : https://wiki.openjdk.java.net/display/quality/Quality+Outreach Thanks,Rory On 21/09/2017 23:53, Sanne Grinovero wrote: > Hi Rory, > > congratulations all with the release! > > Yes please flag our projects as "JDK9 ready". We still have some > unresolved pain points wit

Re: [hibernate-dev] [Search and more] What is new in a give release

2017-09-22 Thread Guillaume Smet
On Thu, Sep 21, 2017 at 6:45 PM, Sanne Grinovero wrote: > *IF* you are willing to improve a minor point: I didn't expect the > "Releases" menu to be expanded when not being in any of these > sections. > Let's keep that one for another time. > Related: I wouldn't highlight both the current rele

Re: [hibernate-dev] Release Announcement: General Availability of JDK 9

2017-09-22 Thread Sanne Grinovero
Thanks Muneer and Rory! It's looking great. -- Sanne On 22 September 2017 at 11:41, Rory O'Donnell wrote: > Hi Sanne, > > Wiki updated : > https://wiki.openjdk.java.net/display/quality/Quality+Outreach > > Thanks,Rory > > > > On 21/09/2017 23:53, Sanne Grinovero wrote: >> >> Hi Rory, >> >> cong

[hibernate-dev] Number of SQL statements

2017-09-22 Thread Thomas Reinhardt
Hello Hibernate Team, is there a good way to check in a junit test which number of sql statements are generated ? I want to tackle some of the lazy loading/class enhancement issues and those need good tests of course. Somehow related: I have a (rather trivial) fix for HHH-7842 (Hibernate Crit

Re: [hibernate-dev] Number of SQL statements

2017-09-22 Thread Vlad Mihalcea
Hi, 1. To validate the number of SQL statements, use this SQL Statement count validator I explained in this article: https://vladmihalcea.com/2014/02/01/how-to-detect-the-n-plus-one-query-problem-during-testing/ 2. For Hibernate Criteria, I don't think you should bother since it will be removed

Re: [hibernate-dev] [Search and more] What is new in a give release

2017-09-22 Thread Sanne Grinovero
After some chats and a night of sleep on this, I think we need to stop obsessing about guiding people into the choice among multiple minor versions: it's hard enough that they have to pick a project. We need to encourage people to use the latest versions and we need to send a clear, strong message

Re: [hibernate-dev] Number of SQL statements

2017-09-22 Thread Sanne Grinovero
Hi Thomas, I can't answer your question - will leave that to the people working on Hibernate ORM - but let me share that I'd also love to see such a tool or an example for unit tests (integration tests) to assert that some specific piece of code won't be generating more than N database round trips

Re: [hibernate-dev] [Search and more] What is new in a give release

2017-09-22 Thread Yoann Rodiere
Ok, this will never end... It was good to merge less than 24h ago and now you're arguing against the very point of this work: provide users with more information regarding each series, so that they know what's new. (see the first email by Emmanuel) Please make concrete, exhaustive proposals. From

Re: [hibernate-dev] Number of SQL statements

2017-09-22 Thread Steve Ebersole
For such assertions in the Hibernate test suite we generally rely on Hibernate Statistics. I also really like Vlad's solution. On Fri, Sep 22, 2017 at 10:19 AM Sanne Grinovero wrote: > Hi Thomas, > > I can't answer your question - will leave that to the people working > on Hibernate ORM - but

Re: [hibernate-dev] [Search and more] What is new in a give release

2017-09-22 Thread Steve Ebersole
I think he is saying what I was saying... make the nav links point to the latest version, but with easy nav from there to list of all series/family/whatever On Fri, Sep 22, 2017 at 10:25 AM Yoann Rodiere wrote: > Ok, this will never end... It was good to merge less than 24h ago and now > you're

Re: [hibernate-dev] [Search and more] What is new in a give release

2017-09-22 Thread Steve Ebersole
And again I just wanted to say thanks, great job. It works much better I think, no matter these nit-picky things On Fri, Sep 22, 2017 at 11:00 AM Steve Ebersole wrote: > I think he is saying what I was saying... make the nav links point to the > latest version, but with easy nav from there to l

Re: [hibernate-dev] Number of SQL statements

2017-09-22 Thread Vlad Mihalcea
HI, We already have such tool for the Hibernate tests. The one that I suggested does not use FlexyPool, but datasource-proxy. Vlad On Fri, Sep 22, 2017 at 5:55 PM, Sanne Grinovero wrote: > Hi Thomas, > > I can't answer your question - will leave that to the people working > on Hibernate ORM -

Re: [hibernate-dev] [Search and more] What is new in a give release

2017-09-22 Thread Guillaume Smet
Hi Sanne, IMHO, this is an orthogonal discussion to the problem Yoann is trying to solve. Yoann didn't change anything about which versions are advertised. What I'm saying is that, if when we start a move, we have 4 other discussions about 4 other things we want to change, we won't do a move any

Re: [hibernate-dev] [Search and more] What is new in a give release

2017-09-22 Thread Sanne Grinovero
Sorry for the confusion, my comment was indeed orthogonal and actually meant to get us all somwhat on the same page, as I have the feeling we have been proposing conflicting design changes (both here and in chat) because there is no agreement on the intent. I took that as a sign that our strategy n