Re: [hibernate-dev] ORM - HHH-12332 - Releasing a 5.2.15 quickly?

2018-03-05 Thread Guillaume Smet
Just so that nobody misses it, Christian pushed a PR here: https://github.com/hibernate/hibernate-orm/pull/2180 . Will require someone more familiar with ORM than me to review it :). Thanks. On Mon, Mar 5, 2018 at 7:54 PM, Gail Badner wrote: > +1 to a quick release, with a partial solution if

Re: [hibernate-dev] ORM - HHH-12332 - Releasing a 5.2.15 quickly?

2018-03-05 Thread Gail Badner
+1 to a quick release, with a partial solution if necessary. On Mon, Mar 5, 2018 at 7:28 AM, Steve Ebersole wrote: > I agree that in general it is ok to cut a release with a partial solution > in a case like this > > On Mon, Mar 5, 2018 at 8:40 AM andrea boriero > wrote: > > > If there are no o

Re: [hibernate-dev] 5.3 finalization plan

2018-03-05 Thread Steve Ebersole
My preference is for the providers to handle that, yes. I have already spoken with the Ehcache devs. I have reached out to the Infinispan team but have not heard back On Mon, Mar 5, 2018 at 10:46 AM Scott Marlow wrote: > > > On 03/01/2018 02:37 PM, Steve Ebersole wrote: > > In 2 weeks I will

Re: [hibernate-dev] 5.3 finalization plan

2018-03-05 Thread Scott Marlow
On 03/01/2018 02:37 PM, Steve Ebersole wrote: > In 2 weeks I will be releasing 5.3 CR2. I waned to start a unified > discussion about the remaining currently unresolved discussions and what > exactly we are going to do for 5.3 mainly in regards to compatibility with > an eye to 6.0 > > > > Ca

Re: [hibernate-dev] HHH-12353: have getReference stick to the Java API it promises?

2018-03-05 Thread Steve Ebersole
Sure, I think using DeprecationLogger is a good short-term option. On Mon, Mar 5, 2018 at 9:32 AM Sanne Grinovero wrote: > On 5 March 2018 at 15:24, Steve Ebersole wrote: > > Fun trip down memory lane :) > > > > No one really like my proposed solution, but also no one really seemed to > > disl

Re: [hibernate-dev] HHH-12353: have getReference stick to the Java API it promises?

2018-03-05 Thread Sanne Grinovero
On 5 March 2018 at 15:24, Steve Ebersole wrote: > Fun trip down memory lane :) > > No one really like my proposed solution, but also no one really seemed to > dislike it enough to implement something themselves ;) > > Anyway, those older discussions are a piece of the same overall discussion > tha

Re: [hibernate-dev] ORM - HHH-12332 - Releasing a 5.2.15 quickly?

2018-03-05 Thread Steve Ebersole
I agree that in general it is ok to cut a release with a partial solution in a case like this On Mon, Mar 5, 2018 at 8:40 AM andrea boriero wrote: > If there are no objections I can manage a release as soon as a fix is > ready. > > On 5 March 2018 at 14:20, Chris Cranford wrote: > > > On 03/05/

Re: [hibernate-dev] HHH-12353: have getReference stick to the Java API it promises?

2018-03-05 Thread Steve Ebersole
Fun trip down memory lane :) No one really like my proposed solution, but also no one really seemed to dislike it enough to implement something themselves ;) Anyway, those older discussions are a piece of the same overall discussion that this one belongs to. This discussion is just a specific pa

Re: [hibernate-dev] HHH-12353: have getReference stick to the Java API it promises?

2018-03-05 Thread Gunnar Morling
Hey, It's just three and six years, respectively, since we discussed this matter last [1], [2] (wow, I'm feeling old somehow now ;) Detecting the situation at boot time and raising an exception early on would be the best. --Gunnar [1] http://lists.jboss.org/pipermail/hibernate-dev/2015-April/01

Re: [hibernate-dev] HHH-12353: have getReference stick to the Java API it promises?

2018-03-05 Thread Steve Ebersole
+1 (a) is the only feasible option On Mon, Mar 5, 2018, 7:53 AM Sanne Grinovero wrote: > Issue HHH-12353 was just reported and I have to agree it looks dodgy. > > Essentially invoking: > > entityManager.getReference( Person.class ) > > might not return a type compatible with Person, when Perso

Re: [hibernate-dev] ORM - HHH-12332 - Releasing a 5.2.15 quickly?

2018-03-05 Thread andrea boriero
If there are no objections I can manage a release as soon as a fix is ready. On 5 March 2018 at 14:20, Chris Cranford wrote: > On 03/05/2018 08:26 AM, Sanne Grinovero wrote: > > On 5 March 2018 at 12:27, Guillaume Smet > > wrote: > >> Hi, So far we had 4 duplicate reports of > >> https://hibern

Re: [hibernate-dev] ORM - HHH-12332 - Releasing a 5.2.15 quickly?

2018-03-05 Thread Chris Cranford
On 03/05/2018 08:26 AM, Sanne Grinovero wrote: > On 5 March 2018 at 12:27, Guillaume Smet > wrote: >> Hi, So far we had 4 duplicate reports of >> https://hibernate.atlassian.net/browse/HHH-12332 (so not counting the >> users having seen the bug and not opening a new one). I think this >> issue qua

Re: [hibernate-dev] ORM - HHH-12332 - Releasing a 5.2.15 quickly?

2018-03-05 Thread Guillaume Smet
Hi Christian, On Mon, Mar 5, 2018 at 2:15 PM, Christian Beikov wrote: > > I have a fix for the NPE the user reported, but there is one edge case, > which hasn't been rerported yet as it seems exotic, that I am still trying > to figure out. > I can provide the "partial fix" later today if you like

[hibernate-dev] HHH-12353: have getReference stick to the Java API it promises?

2018-03-05 Thread Sanne Grinovero
Issue HHH-12353 was just reported and I have to agree it looks dodgy. Essentially invoking: entityManager.getReference( Person.class ) might not return a type compatible with Person, when Person is final and annotated with @Proxy(proxyClass = AnotherTypeX.class), then AnotherTypeX might be retu

Re: [hibernate-dev] ORM - HHH-12332 - Releasing a 5.2.15 quickly?

2018-03-05 Thread Sanne Grinovero
On 5 March 2018 at 12:27, Guillaume Smet wrote: > Hi, > > So far we had 4 duplicate reports of > https://hibernate.atlassian.net/browse/HHH-12332 (so not counting the users > having seen the bug and not opening a new one). > > I think this issue qualifies as "we should really get a hotfix release

Re: [hibernate-dev] NoORM - Improve consistency of our pom files with JBoss parent and WildFly parent

2018-03-05 Thread Davide D'Alto
Sure, thanks On Mon, Mar 5, 2018 at 11:37 AM, Guillaume Smet wrote: > Hi, > > So, I started the effort of making our version properties consistent with > JBoss parent/WildFly parent with Search but the idea is to generalize this > to all our NoORM projects and be as consistent as possible between

Re: [hibernate-dev] Null-Pointer Exception with 5.2.14

2018-03-05 Thread Guillaume Smet
Hi Christian, Looks like we just crossposted. FWIW, there is another report here: https://hibernate.atlassian.net/browse/HHH-12347 . We should check this case is covered too. I marked the 2 other issues as duplicate of https://hibernate.atlassian.net/browse/HHH-12332 , feel free to close them as

[hibernate-dev] ORM - HHH-12332 - Releasing a 5.2.15 quickly?

2018-03-05 Thread Guillaume Smet
Hi, So far we had 4 duplicate reports of https://hibernate.atlassian.net/browse/HHH-12332 (so not counting the users having seen the bug and not opening a new one). I think this issue qualifies as "we should really get a hotfix release soon". I let the duplicated issues open for now as I saw a c

Re: [hibernate-dev] Null-Pointer Exception with 5.2.14

2018-03-05 Thread Christian Beikov
I have a reproducer as well and have a partial fix already. Just doing some more testing now to make sure some other edge cases I discovered are handled properly. Am 05.03.2018 13:08 schrieb "Petar Tahchiev" : > I managed to reproduce it. Here's the bug: https://hibernate.atlassian. > net/browse/

Re: [hibernate-dev] Null-Pointer Exception with 5.2.14

2018-03-05 Thread Petar Tahchiev
I managed to reproduce it. Here's the bug: https://hibernate.atlassian.net/browse/HHH-12354 and here is the project to reproduce it: https://github.com/ptahchiev/hibernate-test-case-templates/tree/nlp 2018-03-01 10:49 GMT+02:00 Vlad Mihalcea : > Hi Petar, > > You can use this template: > > http:/

[hibernate-dev] NoORM - Improve consistency of our pom files with JBoss parent and WildFly parent

2018-03-05 Thread Guillaume Smet
Hi, So, I started the effort of making our version properties consistent with JBoss parent/WildFly parent with Search but the idea is to generalize this to all our NoORM projects and be as consistent as possible between the projects. The idea is to, as much as possible, use the exact same notatio