Re: [hibernate-dev] ORM - HHH-12332 - Releasing a 5.2.15 quickly?

2018-03-07 Thread andrea boriero
sorry but I had an horrible night and not feeling great right now so I'll do the release late this afternoon or tomorrow morning. On 6 March 2018 at 19:32, Chris Cranford wrote: > Gail - > > I asked Andrea earlier and he hoped Wednesday March 7th; however he did > say it depends on the status of

Re: [hibernate-dev] ORM - HHH-12332 - Releasing a 5.2.15 quickly?

2018-03-07 Thread Guillaume Smet
Apparently, there is still an issue with the latest fix but a different one: https://hibernate.atlassian.net/browse/HHH-12332?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&focusedCommentId=101427#comment-101427 I posted a message to try to help the OP isolating the issue.

Re: [hibernate-dev] ORM - HHH-12332 - Releasing a 5.2.15 quickly?

2018-03-07 Thread andrea boriero
I agree with the revert solution Guillaume proposed. On 7 March 2018 at 12:25, Guillaume Smet wrote: > Apparently, there is still an issue with the latest fix but a different > one: > https://hibernate.atlassian.net/browse/HHH-12332?page=com. > atlassian.jira.plugin.system.issuetabpanels%3Acomme

Re: [hibernate-dev] ORM - HHH-12332 - Releasing a 5.2.15 quickly?

2018-03-07 Thread Sanne Grinovero
Let's not rush things and see what Christian thinks: he should be allowed to analyze this - if he has time and wants to - w/o too much pressure. I see the last report is an NPE, that's typically not too hard to fix so I'd rather try again. The risk with a full revert is that it's never getting fix

Re: [hibernate-dev] ORM - HHH-12332 - Releasing a 5.2.15 quickly?

2018-03-07 Thread Guillaume Smet
On Wed, Mar 7, 2018 at 1:53 PM, Sanne Grinovero wrote: > Let's not rush things and see what Christian thinks: he should be > allowed to analyze this - if he has time and wants to - w/o too much > pressure. I see the last report is an NPE, that's typically not too > hard to fix so I'd rather try a

Re: [hibernate-dev] ORM - HHH-12332 - Releasing a 5.2.15 quickly?

2018-03-07 Thread Sanne Grinovero
On 7 March 2018 at 13:02, Guillaume Smet wrote: > On Wed, Mar 7, 2018 at 1:53 PM, Sanne Grinovero wrote: >> >> Let's not rush things and see what Christian thinks: he should be >> allowed to analyze this - if he has time and wants to - w/o too much >> pressure. I see the last report is an NPE, th

[hibernate-dev] Self sanity check - caching and stats changes - invalidated query cache results

2018-03-07 Thread Steve Ebersole
I am trying to finish up these caching and stats related changes, but am currently fighting a few remaining test failures. In my initial investigation IMO some of these tests are wrong, but hoped someone(s) else could check may expectation/belief. E.g. have a look at `org.hibernate.test.querycach

Re: [hibernate-dev] Self sanity check - caching and stats changes - invalidated query cache results

2018-03-07 Thread andrea boriero
is the first check assertEquals( qs.getCacheHitCount(), 0 ); ? On 7 March 2018 at 17:12, Steve Ebersole wrote: > I am trying to finish up these caching and stats related changes, but am > currently fighting a few remaining test failures. In my initial > investigation IMO some of these tests are

Re: [hibernate-dev] Self sanity check - caching and stats changes - invalidated query cache results

2018-03-07 Thread Steve Ebersole
Sorry for the noise - I misread the error. I missed that it was doing an invalidation (update) in the middle of the test as well. That failure is valid after all. Somehow the query execution count is getting out of sync with miss/put counts. Those values should always be equal. I'll have to tr

[hibernate-dev] Is unidirectional one-to-one referencing a non-primary key valid

2018-03-07 Thread Gail Badner
Hi, This is an unusual mapping. My gut feeling is that it is not a valid mapping, but I don't see anything in the spec that would indicate it is invalid. Here is the mapping: @Entity public class Product { @Id @Column(name = "id") private int id; @OneToOne(cascade = CascadeType.ALL)

[hibernate-dev] HHH-12372 Restore binary compatibility with applications using the legacy Session#getFlushMode() method

2018-03-07 Thread Sanne Grinovero
Hi all, good news on the backwards compatibility; David suggested we could use his "bridger" tool to have the Session API binary compatible with older versions. - https://github.com/dmlloyd/bridger I created a prototype patch, it's all actually quite self-explanatory: - https://github.com/Sann

Re: [hibernate-dev] HHH-12372 Restore binary compatibility with applications using the legacy Session#getFlushMode() method

2018-03-07 Thread Steve Ebersole
On Wed, Mar 7, 2018 at 6:59 PM Sanne Grinovero wrote: > Hi all, > > good news on the backwards compatibility; David suggested we could use > his "bridger" tool to have the Session API binary compatible with > older versions. > - https://github.com/dmlloyd/bridger > Wow, very cool! Thanks for t