Re: [hibernate-dev] SingleTableEntityPersister memory footprint in 5.3

2018-05-03 Thread Sanne Grinovero
On 3 May 2018 at 19:33, Gail Badner wrote: > OK, let me know if I should jump in... Thanks Gail, I think you can relax for now :) - knowing that 4.3 introduced the load plans explains a good deal of the difference - Guillaume is checking details too - the Red Hat

Re: [hibernate-dev] SingleTableEntityPersister memory footprint in 5.3

2018-05-03 Thread Gail Badner
OK, let me know if I should jump in... On Thu, May 3, 2018 at 10:59 AM, Steve Ebersole wrote: > Yeah, we have been having a chat about this on HipChat > > On Thu, May 3, 2018 at 12:54 PM Gail Badner wrote: > >> I just looked at that thread and it's

Re: [hibernate-dev] SingleTableEntityPersister memory footprint in 5.3

2018-05-03 Thread Steve Ebersole
Yeah, we have been having a chat about this on HipChat On Thu, May 3, 2018 at 12:54 PM Gail Badner wrote: > I just looked at that thread and it's comparing 3.6 to 5.3.CR2... > > On Thu, May 3, 2018 at 4:17 AM, Vlad Mihalcea > wrote: > > > I asked

Re: [hibernate-dev] SingleTableEntityPersister memory footprint in 5.3

2018-05-03 Thread Gail Badner
FYI, those batch loaders were updated to use "load plans" in 4.3. I suspect that might have something to do with it. Please let me know if I should look into this. On Thu, May 3, 2018 at 10:54 AM, Gail Badner wrote: > I just looked at that thread and it's comparing 3.6 to

Re: [hibernate-dev] SingleTableEntityPersister memory footprint in 5.3

2018-05-03 Thread Gail Badner
I just looked at that thread and it's comparing 3.6 to 5.3.CR2... On Thu, May 3, 2018 at 4:17 AM, Vlad Mihalcea wrote: > I asked because someone might have an idea about some change that was doe > in 5.3 that might affect it. > For the moment, I haven't started doing

Re: [hibernate-dev] Releases and CI setup

2018-05-03 Thread Sanne Grinovero
Awesome job! On 3 May 2018 at 14:04, Guillaume Smet wrote: > On Thu, May 3, 2018 at 2:47 PM, Guillaume Smet > wrote: >> >> On Thu, May 3, 2018 at 1:17 PM, Sanne Grinovero >> wrote: >>> >>> Very cool! >>> >>> Feel free to

Re: [hibernate-dev] HSEARCH-3000 Pick Jigsaw Automatic Module names for all published modules

2018-05-03 Thread Sanne Grinovero
Ok, I surrender. so it's going to be `org.hibernate.search.backend.elasticsearch`. Even if it's not ideal in the context of Hibernate Search 5.x, IMO long term stability is more important for people. For the record I still think this tendency to over-qualify things and add many prefixes should

Re: [hibernate-dev] Releases and CI setup

2018-05-03 Thread Guillaume Smet
On Thu, May 3, 2018 at 2:47 PM, Guillaume Smet wrote: > On Thu, May 3, 2018 at 1:17 PM, Sanne Grinovero > wrote: > >> Very cool! >> >> Feel free to build it and deploy on ci.hibernate.org ? >> > > I deployed it on ci.hibernate.org just now. > > It

Re: [hibernate-dev] Releases and CI setup

2018-05-03 Thread Guillaume Smet
On Thu, May 3, 2018 at 1:17 PM, Sanne Grinovero wrote: > Very cool! > > Feel free to build it and deploy on ci.hibernate.org ? > I deployed it on ci.hibernate.org just now. It would be nice if you could check which jobs get triggered when you push something to master/a

Re: [hibernate-dev] HSEARCH-3000 Pick Jigsaw Automatic Module names for all published modules

2018-05-03 Thread Guillaume Smet
On Thu, May 3, 2018 at 2:17 PM, Yoann Rodiere wrote: > Still, there are several reasons because of which I'd rather use > "org.hibernate.search.backend.": > >- It is closer to how we will probably refer to the module on a >day-to-day basis: I don't know about you,

Re: [hibernate-dev] HSEARCH-3000 Pick Jigsaw Automatic Module names for all published modules

2018-05-03 Thread Yoann Rodiere
Since the names are about to be set in stone, and there has been some discussion off list, I'd like to talk a bit about the Elasticsearch/Lucene module names... In the Search 6 architecture, these modules really provide a "backend", i.e. a component that actually implements indexing/querying over

Re: [hibernate-dev] Releases and CI setup

2018-05-03 Thread Sanne Grinovero
Very cool! Feel free to build it and deploy on ci.hibernate.org ? On 3 May 2018 at 11:53, Guillaume Smet wrote: > On Mon, Apr 30, 2018 at 6:09 PM, Guillaume Smet > wrote: > >> So I would say: >> - either we fix the issue we have with all the

Re: [hibernate-dev] Releases and CI setup

2018-05-03 Thread Yoann Rodiere
Great! Thanks a lot :) I added a few comments, but nothing very important. On Thu, 3 May 2018 at 12:55 Guillaume Smet wrote: > On Mon, Apr 30, 2018 at 6:09 PM, Guillaume Smet > wrote: > > > So I would say: > > - either we fix the issue we

Re: [hibernate-dev] SingleTableEntityPersister memory footprint in 5.3

2018-05-03 Thread Vlad Mihalcea
I asked because someone might have an idea about some change that was doe in 5.3 that might affect it. For the moment, I haven't started doing anything about it. Vlad On Thu, May 3, 2018 at 2:01 PM, Guillaume Smet wrote: > On Thu, May 3, 2018 at 9:35 AM, Vlad Mihalcea

Re: [hibernate-dev] SingleTableEntityPersister memory footprint in 5.3

2018-05-03 Thread Guillaume Smet
On Thu, May 3, 2018 at 9:35 AM, Vlad Mihalcea wrote: > I think it's worth investigating the cause and see how we could address it > in the next release. > Sure, something looks fishy there. Will you do it or do you expect someone else to do it? It's not very clear from

Re: [hibernate-dev] Releases and CI setup

2018-05-03 Thread Guillaume Smet
On Mon, Apr 30, 2018 at 6:09 PM, Guillaume Smet wrote: > So I would say: > - either we fix the issue we have with all the branches being tested for > each commit that we discussed numerous times > Here it is:

[hibernate-dev] SingleTableEntityPersister memory footprint in 5.3

2018-05-03 Thread Vlad Mihalcea
Hi, On Discourse, a user told us that the memory footprint has increased dramatically between 5.2 and 5.3: https://discourse.hibernate.org/t/batch-fetch-style-recommendations/631/5?u=vlad I think it's worth investigating the cause and see how we could address it in the next release. Vlad