[hibernate-dev] Failing Analysis

2018-07-17 Thread Alvaro Pedraza
Hi, I'm wondering if there is something wrong with LGTM Java analysis, because it has failed in my 2 open PR’s. https://github.com/hibernate/hibernate-orm/pull/2357 https://github.com/hibernate/hibernate-orm/pull/2433

Re: [hibernate-dev] Failing test for issue HHH-12688

2018-07-17 Thread Alvaro Pedraza
I ran it again and seems to be failing consistently. This is the info I can get: Stacktrace: java.lang.AssertionError: expected:<1> but was:<0> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:834) at

[hibernate-dev] NoORM IRC meeting minutes

2018-07-17 Thread Guillaume Smet
Hi! Here are the minutes of our NoORM IRC meeting: 15:26 < jbott> Meeting ended Tue Jul 17 13:26:02 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 15:26 < jbott> Minutes:

Re: [hibernate-dev] HHH-3138 - make constructor of DynamicMapEntityTuplizer public

2018-07-17 Thread Steve Ebersole
Sorry for the late reply. As Sanne indicated, we are all very busy with our own work. Reaching out here and "championing" a particular issue that you are interested in working on is a great way to make sure it is not missed. Anyway, I replied on the Jira. On Tue, Jul 17, 2018 at 8:11 AM Sanne

Re: [hibernate-dev] HHH-3138 - make constructor of DynamicMapEntityTuplizer public

2018-07-17 Thread Sanne Grinovero
On Tue, 17 Jul 2018 at 13:45, Guillaume Smet wrote: > > Hi, > > On Tue, Jul 17, 2018 at 11:33 AM Sanne Grinovero wrote: >> >> In the specific example of HHH-3138, I guess people didn't comment as >> there is no clear problem to be solved. It might help to explain why >> you want to subclass a

Re: [hibernate-dev] HHH-3138 - make constructor of DynamicMapEntityTuplizer public

2018-07-17 Thread Guillaume Smet
Hi, On Tue, Jul 17, 2018 at 11:33 AM Sanne Grinovero wrote: > In the specific example of HHH-3138, I guess people didn't comment as > there is no clear problem to be solved. It might help to explain why > you want to subclass a DynamicMapEntityTuplizer - but I'm just > guessing as I'm not

[hibernate-dev] JDK 11 Early Access build 22 & JDK 12 Early Access b02 are available.

2018-07-17 Thread Rory O'Donnell
Hi Sanne, *JDK 11 is in Rampdown Phase one* * *The overall feature set is frozen. No further JEPs will be targeted to this release.* * *Rampdown Phase two is scheduled to start * *26th of July* **JDK 11 EA build 22 , *under both the GPL and Oracle EA licenses, is now available at

Re: [hibernate-dev] HHH-3138 - make constructor of DynamicMapEntityTuplizer public

2018-07-17 Thread Sanne Grinovero
Hi Alvaro, welcome :-) The ticket descriptions can be debated; we can all be wrong, or you might have a better idea. Regarding feedback times: I'm sorry we're a bit slow. There are many things which are urgent - or we're more interested in - and since it's summer so many are on holidays. It

Re: [hibernate-dev] Failing test for issue HHH-12688

2018-07-17 Thread Guillaume Smet
Does it fail every time you run the build or is it a transient failure? If it's consistent, please check the result of the test (the Gradle log points you to a HTML file containing all the info) and paste the full error message and stracktrace here. Information about your environment might also