che in front of our server.
>
> Long story short, nobody had time to look into this so far.
>
> Yoann Rodière
> Hibernate Team
> yo...@hibernate.org
>
>
> On Mon, 23 Nov 2020 at 17:23, Gunnar Morling wrote:
>
>> Hey all,
>>
>> I just noticed
Hey all,
I just noticed that visiting http://hibernate.org/ (i.e. not http*s*) will
not automatically upgrade you to HTTPS, but leave you with that ugly
unsecure icon in the browser address bar. It's also what you get when
simply typing hibernate.org (i.e. 99% of users).
As search engines tend to
Am Di., 29. Sept. 2020 um 13:38 Uhr schrieb Sanne Grinovero <
sa...@hibernate.org>:
> On Tue, 29 Sep 2020 at 12:34, Gunnar Morling wrote:
> >
> > Hey Sanne,
> >
> > > ALL commits need to start with the JIRA code which relates to the
> change.
> >
>
Hey Sanne,
> ALL commits need to start with the JIRA code which relates to the change.
Perhaps you're doing this already, so just in case: for Debezium we have a
simple check of that as a GH action, failing PR builds if they contain
commits whose message does not begin with "DBZ-":
https://gith
ch is accessing those entities needs to be
> enhaced as well.
>
> Anything could be done of course, but that one is rather tricky to accomplish
> without the well designed analysis and augmentation phases of Quarkus,
> especially in a modular environment.
>
> Cheers
> Sann
Hi,
An interesting question came up during the Quarkus meet-up with Harald
Pehl here in Hamburg last night: could Panache also be used without
Quarkus, e.g. within a WildFly application?
Any plans to enable that?
Thanks,
--Gunnar
___
hibernate-dev mai
> I thought that the next LTS was going to be JDK 17. Did the plans change?
It could be both actually.
LTS is not a notion of OpenJDK itself; instead, individual build providers
can support LTS for any release they want. The three years cadence (i.e.
11, 17 etc.) is what Oracle indicated they'd p
Hi all,
Just tried to reach in.relation.to via HTTPS, but it doesn't connect. Has
it not been moved to HTTPS yet, or is something broken there?
--Gunnar
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinf
Does anyone know whether/how I could export all my existing chat logs
from HipChat? I'd like to keep a copy esp. of all 1:1 chats I had, if
that's possible.
Thanks for any hints,
--Gunnar
Am Do., 6. Dez. 2018 um 17:03 Uhr schrieb Yoann Rodiere :
>
> > Hey wait a second :) You invited us to try G
Yes, we're doing something like that in MapStruct, too:
https://github.com/mapstruct/mapstruct/blob/master/processor/src/main/java/org/mapstruct/ap/MappingProcessor.java#L114
There we need to wait with code generation for processed classes until
their hierarchy has stabilized (other APs may gene
Hey,
When discussing this before, there were some doubts about its actual
usefulness in non-testing, real-world code. E.g. you'd typically
interact with multiple DAOs/repositories etc. and would have to
somehow pass the session to each of them.
One other thought is that inTransaction() should all
al
mentions in a room.
Am Mo., 12. Nov. 2018 um 11:28 Uhr schrieb Guillaume Smet
:
>
> Are you using the webapp?
>
> Because I don't see any preference to enable sound and there is no sound at
> all when I get a notification.
>
> On Mon, Nov 12, 2018 at 11:21 AM Gunnar
Have you tried "Room Settings" -> "Notifications"? We're on Gitter for
Debezium, too, and in fact the notifications were too noisy for me, so
I turned them off :)
--Gunnar
Am Mo., 12. Nov. 2018 um 10:59 Uhr schrieb Guillaume Smet
:
>
> Hi,
>
> So, one thing I find particularly annoying with Gitte
IMO no timezone conversion whatsoever should be applied when
persisting LocalDateTime as it doesn't contain any TZ information.
If the target column type requires a TZ, it should be set to UTC,
storing the given value without any shift. I.e. the LDT value
2007-12-03T10:15:30 should be stored as 20
Would SessionFactoryServiceContributor [1] be of use to you? It lets you
add services to the SF-scoped service registry; not sure whether that suits
your requirements or no.
--Gunnar
[1]
https://github.com/hibernate/hibernate-orm/blob/master/hibernate-core/src/main/java/org/hibernate/service/spi/
Hi,
A common requirement that comes up repeatedly is "upsert" operations, i.e.
either insert a record or update the existing one with the same PK, if it
already exists. Many (most?) RDBMS support it, either by implementing SQL
2003's MERGE keyword or via proprietary alternatives [1].
I think it'd
Excellent, thanks a lot! Do you have a link to instructions you followed?
Would like to do the same for another site of mine.
2018-06-16 9:05 GMT+02:00 Emmanuel Bernard :
> I’ve enabled HTTPS for BV after a bit of a fight with the DNS entries. I’m
> planning to enforce HTTPS only in a few days.
>
No strong preference on my side, but I found this project of Lauri Apple
very useful:
https://github.com/LappleApple/feedmereadmes
You can ask for input on your README file there (they may send a PR for
updating it) and it also contains a "README maturity model". Perhaps it's
helpful for you,
+1 for looking into the mP health check API.
In fact, I don't even think that Hibernate would have to implement any sort
of looping itself. Instead, the orchestration layer would check the health
check endpoint and automatically restart the service if it's not in a
healthy state. That way, the ord
I've mostly used Japicmp recently http://siom79.github.io/japicmp/). Works
pretty well, but it lacks a way to distinguish between API and SPI, so
you'll likely also see "false positives". In fact I thought it's the one
you'd be using, but it doesn't seem so from looking at the report attached
to th
t;
>> It's better if we use simple slug names that capture the article focus
>> keywords and remove the date altogether.
>>
>> Vlad
>>
>> On Thu, Mar 22, 2018 at 10:23 AM, Gunnar Morling
>> wrote:
>>
>> > Hi,
>> >
>> > Wh
Hi,
While talking to a few bloggers from the Java ecosphere at JavaLand last
week, the question came up why we have the date in the URL of blog posts.
Arguably, it doesn't add value there (we show the date on the actual posts
themselves), and makes the URLs slightly worse to read. In particular,
Excellent, very nice! Thanks, Guilllaume!
2018-03-21 11:15 GMT+01:00 Guillaume Smet :
> As per Gunnar's request, you can now use the ++ marker to
> explicitly mark the end of the preamble (same as in Hugo).
>
> For an example:
> posts/Gunnar/2018-02-26-putting-bean-validation-
> constraints-t
I don't know whether that's the resource Emmanuel meant to link to, but
it's the most recent presentation on the topic I'm aware of:
https://blogs.oracle.com/java/jdbc-next%3a-a-new-asynchronous-api-for-connecting-to-a-database
--Gunnar
2018-03-20 19:09 GMT+01:00 Mark Rotteveel :
> Minor ni
Great initiative, always wanted to have this! Can you send a PR for
debezium.github.io, too ;)
2018-03-20 16:02 GMT+01:00 Guillaume Smet :
> On Tue, Mar 20, 2018 at 2:23 PM, Yoann Rodiere
> wrote:
>
> > It's definitely better. There are a few drawbacks, such as the summary
> not
> > displaying f
This is a spec-level API, defined in ValidatorContext:
https://github.com/beanvalidation/beanvalidation-api/blob/master/src/main/java/javax/validation/ValidatorContext.java#L77
So unless we change the rules (there might be some leeway now when
formalizing compat rules for Jakarta EE), we cannot
Hey,
It's just three and six years, respectively, since we discussed this matter
last [1], [2] (wow, I'm feeling old somehow now ;)
Detecting the situation at boot time and raising an exception early on
would be the best.
--Gunnar
[1] http://lists.jboss.org/pipermail/hibernate-dev/2015-April/01
pendencies (e.g. in a module-info) would not give
> us the option to have classpath dependencies (or would it?), and thus we
> would not be able to depend on Lucene...
>
I'm not quite following on this reasoning. But yes, a named module
shouldn't depend on the UNNAMED module. But
;
>> Either way, that's interesting to experiment with but we can't publish
>> full modules as almost none of our dependencies are ready; they should
>> at least all have an automatic module name.
>>
>> Thanks,
>> Sanne
>>
>> On 12 February 2
an't publish
> full modules as almost none of our dependencies are ready; they should
> at least all have an automatic module name.
>
> Thanks,
> Sanne
>
> On 12 February 2018 at 19:43, Gunnar Morling wrote:
> >
> >
> > 2018-02-12 19:28 GMT+01:00 Sanne Grin
2018-02-12 19:28 GMT+01:00 Sanne Grinovero :
> On 12 February 2018 at 18:00, Gunnar Morling wrote:
> >
> >
> > 2018-02-12 17:55 GMT+01:00 Sanne Grinovero :
> >>
> >> Picking automatic module names for Hibernate Search isn't going to be
> >> st
2018-02-12 17:55 GMT+01:00 Sanne Grinovero :
> Picking automatic module names for Hibernate Search isn't going to be
> straight-forward as our two main jars (hibernate-search-engine &
> hibernate-search-orm) suffer from split package among them.
>
> We can't really fix the split package problem wi
Excellent; I've filed https://hibernate.atlassian.net/browse/HHH-12287 for
this. I'll try and find some time to provide a PR.
What's the cut-off date for 5.3?
2018-02-10 16:17 GMT+01:00 Steve Ebersole :
> Yes, I agree.
>
> On Sat, Feb 10, 2018, 7:55 AM Gunnar Morling w
viderImpl.java#L61-L74
[2] https://hibernate.atlassian.net/browse/HHH-12284
2018-02-04 12:30 GMT+01:00 Gunnar Morling :
> I like it, but I think that's two separate concerns:
>
> * using byte code generation to improve performance of entity
> instantiations
> * avoiding the nee
Seems we're on the same page. I can do this change, my only question would
be about dropping the DDL enum member and rejecting multiple values (your
1. and 2. above). Should we first (i.e. in 5.3) deprecate the enum member
and log a warning if multiple values are given?
>
> On Fri, Fe
;d work for me.
2018-02-07 21:07 GMT+01:00 Steve Ebersole :
> No, I think you are right and `hibernate.validator.apply_to_ddl` should
> apply to CALLBACK as well.
>
> On Wed, Feb 7, 2018 at 1:45 PM Gunnar Morling
> wrote:
>
>> > How is a String "CALLBACK,DDL" c
SD?
>
> Look, I don't mind revisiting a change here. I really have no horse n
> this race - this is not even my code originally. TBH I thought this was
> code that you did. So I don't mind changes here if there is a consensus.
> But let's use real reasons ;)
>
&g
Right, giving multiple values isn't allowed as per JPA's XSD.
2018-02-07 19:44 GMT+01:00 Steve Ebersole :
> Of course you can. `mode = CALLBACK,DDL`
>
> You mean that you cannot using single-valued setting
>
> On Wed, Feb 7, 2018 at 12:02 PM Gunnar Morling
> wrote:
2018-02-07 16:08 GMT+01:00 Steve Ebersole :
> Ok, so this is the crux then because it really comes down to whether you
> believe whether it is valid to *only* export the annotation-based
> validations as DDL.
>
> And keep in mind that this code is basically unchanged from all the way
> back to the
control 1 thing is fugly, but if there is
> a consensus that is fine. Bu so far its just been you saying that.
>
> On Tue, Feb 6, 2018 at 10:09 AM Gunnar Morling
> wrote:
>
>> > All of those are valid options. But I think Gunnar's suggestion misses
>> #3, alt
> All of those are valid options. But I think Gunnar's suggestion misses
#3, although I certainly maybe just missed that in his email. Gunnar?
You'd have this:
- No validation: validation mode = NONE, hibernate.validator.apply_to_ddl =
false
- In-memory validation: validation mode = AUTO|CALLBA
se level via contraints?
> No of course not - but the vast majority in fact can.
>
>
>
> On Tue, Feb 6, 2018, 7:52 AM Gunnar Morling wrote:
>
>> 2018-02-06 14:41 GMT+01:00 Steve Ebersole :
>>
>>> The reasoning is that the 2 BV modes you mention make no me
;>
>> I don't particularly see a reason why we cannot as it seems we're
>> handling the CALLBACK mode with no BV provider present earlier in the
>> code path. I'm fine changing it.
>>
>> Chris
>>
>>
>> On 02/04/2018 07:21 AM, Gu
Hi,
If the JPA validation mode is set to CALLBACK, BV constraints such as
@NotNull, @Size etc. are not reflected in the DDL created by ORM.
Instead, in TypeSafeActivator, the BV constraints are only considered for
DDL if the validation mode is DDL or AUTO [1].
CALLBACK is the safe way to ensure
I like it, but I think that's two separate concerns:
* using byte code generation to improve performance of entity instantiations
* avoiding the need for entities to have a parameterless constructor,
emphasising the mandatory properties of an entity (by requiring them as
constructor parameters) an
2018-01-15 11:54 GMT+01:00 Yoann Rodiere :
> > We should reconfigure those to not "install" - that's actually a bad
> > habit, legacy from Maven 2 times - people nowadays recommend using
> > "mvn clean verify", especially on CI environments.
>
> I could not agree more, that would be cleaner, but t
Brett,
What's still unclear to me is when going the Docker route, won't you still
need some code which deploys your tests to Karaf, runs them there and
fetches the test results, so e.g. your Gradle build will fail if there are
test failures? Would you envision to write these bits yourself? And
wou
Hey all,
> at least plan a 5.2.13 release soon to release all the fixes already in?
+1 for doing another 5.2 release if there are lots of issues already merged
and 5.3 isn't going through the door very soon. It'd be great to get those
nice fixes you all did out to users.
I realize I won't be th
2018-01-12 12:59 GMT+01:00 Sanne Grinovero :
> Personally I'm neutral. I surely wouldn't want to manage our own
> Artifactory, but since JFrog will do that I'm not concerned about the
> platform management being horrible.
>
> Artifactory looks better, OSSRH has the benefit of possibly having
> bet
Hi Brett,
We also had our fair share of frustration with Pax Exam in HV, and I was
(more than once) at the point of dropping it.
Docker could work, but as you say it's a bit of a heavy dependency, if not
required anyways. Not sure whether I'd like to add this as a prerequisite
for the HV build to
Hi Hilmer,
Welcome to the list and +1 to that constraint. I think it's a good idea
overall, will comment on the PR on some details as needed.
Cheers,
--Gunnar
2018-01-08 13:04 GMT+01:00 Guillaume Smet :
> Hi Hilmer,
>
> On Sat, Jan 6, 2018 at 9:10 PM, Hilmer Chona wrote:
>
> > I have created
separated.
>
> It would be nice if it was considered a Bean Validation effort rather than
> as a purely HV one.
>
> But maybe it makes it too official to have it in the BV organization?
>
> WDYT?
>
> --
> Guillaume
>
> On Wed, Jan 10, 2018 at 9:33 AM, Gunn
+1, good idea. Thanks!
2018-01-09 14:46 GMT+01:00 Guillaume Smet :
> Hi,
>
> Now that we added some more value to the Bean Validation benchmark [1]
> (Marko converted them to JMH), I think it's time to move the repo to the
> Hibernate org.
>
> Anyone against it?
>
> FYI, it's Apache 2 licensed as
2017-12-29 21:34 GMT+01:00 Steve Ebersole :
> On Fri, Dec 22, 2017 at 5:33 AM Steve Ebersole
> wrote:
>
>>
>> * When using ByteBuddy as the byte code provider, I still needed to have
>>> Javassist around, as it's used in ClassFileArchiveEntryHandler. I
>>> understand that eventually this should b
e there is a potential issue for any tooling that
> >>> might be relying on that (logging/auditing, etc.)...
> >>>
> >>>
> >>> On 12/23/17 11:38 PM, Steve Ebersole wrote:
> >>> > Another thing I was noticing was an annoying minor differenc
g those headers anyways.
>
> On Thu, Dec 28, 2017 at 11:58 AM Gunnar Morling
> wrote:
>
>> Automatic-Module-Name looks good.
>>
>> While unrelated, those look odd:
>>
>> * Main-Class: I don't think ORM - as a library - should declare this
>>
rnate.core
> >> >
> >> > Does it make sense to adjust the OSGi bundle name to follow the module
> >> > naming?
> >> >
> >> > On Sat, Dec 23, 2017 at 8:47 AM Steve Ebersole
> >> wrote:
> >> >
> >> >>
e...
>>
>> On Wed, Dec 20, 2017 at 3:54 PM Gunnar Morling
>> wrote:
>>
>>
>>> * JDK 9 comes with an incomplete JTA module (java.transaction), so a
>>> complete one must be provided via --upgrade-module-path (I'm using the
>>> 2.0.0.Alpha1
Hi all,
Following to our discussion in Paris, I've created a simple test bed for
showing the usage of Hibernate ORM and its dependencies as automatic
modules for the Java 9 module system:
https://github.com/gunnarmorling/hibernate-orm-on-java9-modules
It pretty much works as expected, I coul
Just to be sure, including an EPL-licensed item is fine as far as WildFly
is concerned? Other than that, +1 for that change.
2017-12-13 14:04 GMT+01:00 Sanne Grinovero :
> On 13 December 2017 at 13:54, Steve Ebersole wrote:
> > Considering the spec contracts are defined by the EG under the JCP,
Hi,
Related to the discussion this afternoon, this is the list of API changes
in JPA 2.2:
* all repeatable annotations marked with @Repeatable
* new annotations javax.persistence.SequenceGenerators and TableGenerators
(containing annotation types for repeatable annotations SequenceGenerator
and T
+1 for going with the standard.
2017-11-30 18:11 GMT+01:00 Guillaume Smet :
> On Thu, Nov 30, 2017 at 6:02 PM, Steve Ebersole
> wrote:
>
> > IMO though its still a nice touch to "skin" the coloring in the nav bars,
> > main header, footer etc. I have not looked into how much work just those
> >
Hi Dalibor,
2017-11-20 10:24 GMT+01:00 dalibor topic :
>
>
> On 19.11.2017 13:03, Gunnar Morling wrote:
>
>> Hi Rory,
>>
>> While updating my JDK API change report generator [1] for JDK 10, I
>> noticed that three modules aren't available in J
Hi Rory,
While updating my JDK API change report generator [1] for JDK 10, I noticed
that three modules aren't available in JDK 10 as of b32 which existed in
JDK 9:
* jdk.management.cmm
* jdk.management.jfr
* jdk.management.resource
I couldn't find any details on this in the release notes [2], s
Poor guest accessibility is the biggest issue I see about HipChat. I hope
that's a thing improved in Stride.
@Yoann, could you adjust the info on http://hibernate.org/community/ to the
room link you provided?
2017-10-27 15:41 GMT+02:00 Yoann Rodiere :
> Steve, Robert,
>
> The link to the room is
Does anyone know whether our chat histories will be transferred?
I remember we got upgraded to some pro plan on HipChat at some point,
allowing for unlimited history access (unlike with the basis plan). Will we
have the same on Stride?
2017-10-26 15:45 GMT+02:00 Steve Ebersole :
> Right, ultimat
ding it. Thanks!
>
> On Tue, Oct 24, 2017 at 6:36 AM Alessio Stalla
> wrote:
>
>> That would be great for framework developers as well.
>>
>> Il 24 ott 2017 12:01, "Gunnar Morling" ha scritto:
>>
>> > Anyone with thoughts on this? To elabo
not.
Vlad, perhaps you have any insights from the field?
Cheers,
--Gunnar
2017-10-13 21:21 GMT+02:00 Gunnar Morling :
> Hi all,
>
> This has crossed my mind for a few times: should we provide a programmatic
> API in Hibernate ORM for mapping entities, as an alternative mapp
Hi all,
This has crossed my mind for a few times: should we provide a programmatic
API in Hibernate ORM for mapping entities, as an alternative mapping
definition source to annotations and XML? I.e. something similar to the
programmatic mapping APIs we have in Hibernate Validator and Search.
It'd
or JSON, we could add support for
> it in 6.0.
> For ARRAY, I doubt that more DBs will support it if they haven't done it
> by now.
>
> Vlad
>
> On Thu, Sep 28, 2017 at 9:47 AM, Gunnar Morling
> wrote:
>
>> Hey Vlad,
>>
>> I recently learned about y
Hey Vlad,
I recently learned about your "Hibernate Types" project [1]. It's great to
see support for JSON, arrays, etc!
Out of curiosity, though, why did you decide to make it a separate project
instead of adding these very useful types to Hibernate itself? Seems it'd
be easier for people to us t
2017-09-27 14:19 GMT+02:00 Sanne Grinovero :
> Thanks Gunnar, at an high level that's pretty much on the same page
> than everyone else, but some details are relevant:
>
> On 27 September 2017 at 13:08, Gunnar Morling
> wrote:
> > I'd suggest to
> >
>
I'd suggest to
* simply ignore "create database" for Infinispan (not all OGM-defined
properties are supported for all stores)
* implement support for HBM2DDL_AUTO to create tables (or caches etc.)
*within* the chosen database (which will be ISPN's global namespace as
there is no notion of database
fered
from each such logger, which may be better than mangling everything
together into one interface.
2017-09-25 14:18 GMT+02:00 Sanne Grinovero :
> On 25 September 2017 at 13:09, Gunnar Morling
> wrote:
> > 2017-09-25 13:47 GMT+02:00 Steve Ebersole :
> >>
> >> I'
2017-09-25 13:47 GMT+02:00 Steve Ebersole :
> I'm missing something. IIUC the discovery was that, e.g., having something
> like `BaseHibernateSearchLogger` in module-A and then something like
> `RealLogger` in module-B that extends `BaseHibernateSearchLogger` causes
> extra space to be taken up w
That's great news, Steve! Thanks for having this discussion and achieving
this outcome.
I personally hope we can do the same for the other projects such as
Validator, Search and OGM.
2017-08-07 23:27 GMT+02:00 Steve Ebersole :
> Currently we have had to rely on a less-than-ideal CLA approach as
nd JPA 2.2, right?
>
> I've never considered changing the dependencies in any way. It's just this
> method that makes it easier to use Hibernate 5.2 with both JPA 2.1 and JPA
> 2.2 API.
>
> Vlad
>
> On Wed, Aug 2, 2017 at 8:40 PM, Gunnar Morling
> wrote:
>
>
Sure, but you may not publish something like an JPA 2.1+ with just some of
the 2.2 methods.
2017-08-02 17:40 GMT+01:00 Sanne Grinovero :
> On 2 August 2017 at 17:07, Gunnar Morling wrote:
> >> You don't plan on actually updating the JPA API we use at build time
> >> r
> You don't plan on actually updating the JPA API we use at build time
right?
We cannot do that, you may not provide a version of a spec'ed API with
additional methods. It'd have to be in ORM's sub-interface or similar.
2017-08-02 16:16 GMT+01:00 Sanne Grinovero :
> On 2 August 2017 at 15:21, Vl
Hi all,
One general challenge for HV is that we cannot easily determine the set of
validated classes upfront. Neither is there means of listing all validated
types explicitly (akin to JPA's in persistence.xml), nor is it
sufficient to check classes for a limited set of well-known annotations to
i
Hi Guillaume,
Awesome, thanks a lot for getting the numbers and applying the improvements.
So to be sure, at runtime (non-metadata retrieval), CR3 already is faster
than 5.4, also without your latest optimisations from the pending PR? You
mentioned this morning that having the first 6 commits fro
Hi Sanne, Yoann,
This build on CI seems stuck since yesterday:
http://ci.hibernate.org/job/hibernate-search-performance-elasticsearch/44/
Also I noticed a huge amount of log output: "121,741 KB". Do you really
need all that output for each build? Esp. given that this job is about
perf, logging
> there are cases where we deprecate something
> with no replacement whatsoever
Ah, so you are using deprecation to give users a heads-up that some
API will be removed in a future release, but there's no replacement
available yet?
In that case I'd indeed go for a separate annotation such as your
Hi,
This might be interesting to some:
https://rapidclipse.atlassian.net/wiki/display/DOCEN/JPA-SQL.
It's an external DSL for writing queries which are translated into JPA
Criteria API queries then. There's a dedicated editor for that DSL,
with auto-completion etc. I.e. one should get the feel of
2017-06-13 7:54 GMT+02:00 Christian Beikov :
> Hi,
>
> this might work for a limited set of use cases, but what exactly are you
> expecting from that approach? Performance might be a bit better, but
> that's probably negligible. Apart from that, I only see "encapsulation"
> or "ease of use with oth
> Gunnar had a POC to create some great reports about private types
> leaking on public API.. that's something useful and possibly even ok
> to fail the build if that's violated - just we can't do it now as it
> would fail the build on our current API :) I was waiting for 6 to
> enable that, but ma
> Anyway, if you agree with that, I can have a look at the tooling we may
> use. I suspect other Hibernate projects may already have such tooling in
> place (Hibernate Validator in particular).
Indeed we're using some tooling related to this, japicmp:
https://github.com/siom79/japicmp
And ou
;
>> > org.elasticsearch.client.RestClientBuilder.setFailureListener(FailureListener)
>> > org.elasticsearch.client.RestClientBuilder.setPathPrefix(String)
>> >
>> > ... and that's all.
>> >
>> > So yes, this SPI doesn't have a
istener(FailureListener)
> org.elasticsearch.client.RestClientBuilder.setPathPrefix(String)
>
> ... and that's all.
>
> So yes, this SPI doesn't have a direct dependency to Apache HTTP Client, but
> any practical use of it will have one. At the end of the day, that
if you want it ;)
I don't feel strongly about it - you asked for feedback on the
proposal, so that's what I gave. I'd personally avoid to tie our SPIs
to implementation specifics of dependencies. Nothing more, nothing
less.
>
> Thanks,
> Sanne
>
>>
>> Yoann R
ow how to do the AWS signing
etc.
> So at some point, if we want to allow
> configuration (and in the case of an HTTP client, I'm afraid we have to),
> we'll have to expose internals. We just have to make sure this is done in a
> controlled way (expose as little as possible).
>
&
hat. If people are in control of the
RestClient entirely, they can do whatever they want?
>
> Yoann Rodière
> Hibernate NoORM Team
> yo...@hibernate.org
>
> On 2 June 2017 at 10:30, Sanne Grinovero wrote:
>>
>> On Fri, 2 Jun 2017, 08:56 Gunnar Morling, wrote:
>>
>
2017-06-02 10:30 GMT+02:00 Sanne Grinovero :
>
>
> On Fri, 2 Jun 2017, 08:56 Gunnar Morling, wrote:
>>
>> Hi,
>>
>> I find the exposure of an implementation detail (usage of Apache HTTP
>> client) of the Elasticsearch client a bit problematic. If they cha
Hi,
I find the exposure of an implementation detail (usage of Apache HTTP
client) of the Elasticsearch client a bit problematic. If they change
this to another HTTP client, our SPI would break.
Did you instead consider to just let users provide their custom
instance of org.elasticsearch.client.Re
I'd argue you can keep the name, if it's in the test JAR. If people
still use it in their production code, well...
Otherwise, how about "ephemeral"?
2017-05-18 19:05 GMT+02:00 Sanne Grinovero :
> On 18 May 2017 at 17:31, Gunnar Morling wrote:
>> Can't you ju
Can't you just move it to the test JAR if it's for testing only?
Am 18.05.2017 6:29 nachm. schrieb "Sanne Grinovero" :
Right technically it's not a unit test. But I'd like to focus on the
testing aspect, as "local-ram" might still convey concepts as "fast",
maybe even expect it to engage Infinisp
2017-05-17 2:01 GMT+02:00 Steve Ebersole :
> On Tue, May 16, 2017 at 11:20 AM Sanne Grinovero
> wrote:
>
>> Since 6 is coming I'd like to suggest two trivial changes for the
>> listeners:
>>
>> # Serializable
>>
>> I assume we can drop the "extend Serializable" from all these interfaces ?
>>
>>
>
Hi,
I recently got some good questions on Hibernate Search + Elastisearch:
* Can we have multiple indexes for the same entity, with different
fields, geared towards different use cases?
* How could we deal with authorization for seeing specific ES query
results? I reckon that's something to mostl
I don't mind removing it too much; but the idea behind it was no so
much our own testing but rather to let OGM users test their apps with
Fongo. I can see some value in that.
2017-04-27 17:46 GMT+02:00 Sanne Grinovero :
> +1 as I proposed the same thing a long time ago: if it's not the real
> thin
Hi,
On the group id, I'd prefer to keep it as is. This will make it less
disruptive if dialects are demoted/promoted between contrib and core.
On the license I also think it needs to remain as is.
Overall, I'm still unsure what's the implication of the split and how
the lifecycle of dialects is g
1 - 100 of 922 matches
Mail list logo
