[hibernate-dev] [!] Changing the Faceting API in Hibernate Search

2015-05-01 Thread Sanne Grinovero
Hi all, Hardy completed the Faceting re-work in Hibernate Search to use the much improved implementation from recent versions of Lucene, and we'd like to merge his work now making these improvements available to users of Hibernate Search 5.2.0+ There is a catch: while the API to create a Faceting

Re: [hibernate-dev] [!] Changing the Faceting API in Hibernate Search

2015-05-01 Thread Steve Ebersole
So here is what I did. I think this is the best compromise, short of us hand crafting the keywords for each and every one of our Dialects... 1) I added this method to Dialect: /** * Hook into auto-quoting of identifiers that are deemed to be keywords. By default we * return all of the followi

Re: [hibernate-dev] [!] Changing the Faceting API in Hibernate Search

2015-05-04 Thread Gunnar Morling
+1 for merging this work and making the changed behaviour very apparent in the migration notes / announcement. Btw. in addition to @Facet, it should be possible to enable specific fields for faceting via the mapping API (if that's not part of the PR yet). Then a user could programmatically enable

Re: [hibernate-dev] [!] Changing the Faceting API in Hibernate Search

2015-05-04 Thread Hardy Ferentschik
Hi, On Mon, May 04, 2015 at 09:11:06AM +0200, Gunnar Morling wrote: > +1 for merging this work and making the changed behaviour very apparent in > the migration notes / announcement. +1 as well. As I mentioned on the pull request, this is such a long standing issue and a topic which we keep get