FYI : https://hibernate.atlassian.net/browse/HHH-9803
Its not super high on my priority list, but I want to get to a point where
we can start to fail the build on "serious checkstyle regressions". Part
of that is being more realistic with what is considered serious, and part
of that is fixing up
One nice thing of checkstyle is that it's easily extended, for example
in Search we added a couple of checks, like to ban double whitespaces:
-
https://github.com/hibernate/hibernate-search/blob/master/build-config/src/main/java/org/hibernate/checkstyle/checks/regexp/DoubleSpacesCheck.java
Or to
Yes, we use FindBugs too; I will start a discussion about it after this. I
wanted to do CheckStyle first because its easier to work with IMO. And yes
we use FindBugs because there are thins it can do that CheckStyle just
cannot (like checking for the use of non-localized
String#toUpperCase/toLowe
Actually a few others I will add:
3) missing @Override
4) missing @Deprecated/@deprecated
5) missing braces
6) star imports
7) redundant imports
8) lower case 'l' for long literals (upper case is much more readable)
9) missing newline at end of file
On Sat, May 16, 2015 at 1:18 PM, Steve Ebersol
Sanne, can you give me the low-down on this line?
On Sat, May 16, 2015 at 1:26 PM, Steve Ebersole wrote:
> Actually a few others I will add:
>
> 3) missing @Override
> 4) missing @Deprecated/@deprecated
> 5) missing braces
> 6) star imports
> 7) redundant imports
> 8) lower case 'l' for long l
Note that custom checkstyle rule implementations does not fare well with IDE
checkstyle rules enforcement.
I can't make it reliably work on search and OGM.
> On 16 mai 2015, at 16:11, Sanne Grinovero wrote:
>
> One nice thing of checkstyle is that it's easily extended, for example
> in Search
On 16 May 2015 at 19:43, Steve Ebersole wrote:
>
> Sanne, can you give me the low-down on this line?
>
>
I'm not sure of that one; it's "documented" here under TreeWalker section:
- http://checkstyle.sourceforge.net/config.html
That specific value we use is what is suggested to use in combinat
On 18 May 2015 at 15:23, Emmanuel Bernard wrote:
> Note that custom checkstyle rule implementations does not fare well with IDE
> checkstyle rules enforcement.
> I can't make it reliably work on search and OGM.
As far as I remember the problem was related with having the
customisations as part o
Sure. Personally I think the "trick" is to keep the number of failures
small. In fact I initially listed just 9, but am already thinking of
moving at least one from high to medium (and therefore not considered a
failure).
On Mon, May 18, 2015 at 9:23 AM, Emmanuel Bernard
wrote:
> Note that
As far as the file header, I have often thought of condensing our ORM one
so that is awesome information. For my own curiosity did Richard give you
a reason that the copyright statement is not necessary?
On Mon, May 18, 2015 at 9:58 AM, Sanne Grinovero
wrote:
> On 18 May 2015 at 15:23, Emmanuel
Sorry hit send too soon :(
Anyway.. I assume it is because we know this information from commit
history?
As far as the ORM one, I propose a similar change. Any objections?
On Mon, May 18, 2015 at 10:14 AM, Steve Ebersole
wrote:
> As far as the file header, I have often thought of condensing o
+1 I thought it was in already :)
> On 18 mai 2015, at 17:20, Steve Ebersole wrote:
>
> Sorry hit send too soon :(
>
> Anyway.. I assume it is because we know this information from commit
> history?
>
> As far as the ORM one, I propose a similar change. Any objections?
>
> On Mon, May 18, 20
And see, this[1] is exactly the kind of thing I always try to avoid... Why
did y'all decide on that approach?
[1] https://github.com/hibernate/hibernate-search/blob/master/copyright.txt
On Mon, May 18, 2015 at 10:33 AM, Emmanuel Bernard
wrote:
> +1 I thought it was in already :)
>
> > On 18 m
On 18 May 2015 at 19:44, Steve Ebersole wrote:
> And see, this[1] is exactly the kind of thing I always try to avoid... Why
> did y'all decide on that approach?
Personally I think the main reason is pride. Some contributors
explicitly asked me if it was ok to add their names, after they had
cont
Hardy, do you happen to still have your sed script for updating these file
headers?
On Mon, May 18, 2015 at 2:48 PM, Sanne Grinovero
wrote:
> On 18 May 2015 at 19:44, Steve Ebersole wrote:
> > And see, this[1] is exactly the kind of thing I always try to avoid...
> Why
> > did y'all decide on t
ORM master is now enforcing checkstyle. The CI builds will fail if you
commit anything that was deemed a severity of error/high. The only part
missing there is headers, which I will follow up with once I hear back from
Hardy.
On Mon, May 18, 2015 at 3:07 PM, Steve Ebersole wrote:
> Hardy, do y
On Mon, May 18, 2015 at 03:07:08PM -0500, Steve Ebersole wrote:
> Hardy, do you happen to still have your sed script for updating these file
> headers?
I do, they are attached to the JIRA issue -
https://hibernate.atlassian.net/browse/HV-926.
You will need to adjust them to your needs. I used fin
17 matches
Mail list logo
