I agree completely with this.
And yes he did, but then we are moving to Asciidoc :)
On Wed, Jan 13, 2016 at 10:32 AM Hardy Ferentschik
wrote:
> Hi,
>
> > slightly related and just in case you are not aware of this feature
> > yet: You can include (parts of) actual source code files straight i
Hi,
> slightly related and just in case you are not aware of this feature
> yet: You can include (parts of) actual source code files straight into
> AsciiDoc documents. We do that in the HV reference guide, e.g. at [1].
> That way you are 100% sure your examples actually compile (and pass
> tests)
Right; you also can use the same tag several times if you want several
distinct snippets from a file to end up in one listing in the docs:
https://github.com/hibernate/hibernate-validator/blob/master/documentation/src/test/java/org/hibernate/validator/referenceguide/chapter11/failfast/Car.java
.
T
It's quite flexible.
I'll have to use it as soon as we agree with the tests that were moved into
the doc folder.
Vlad
On Wed, Jan 13, 2016 at 5:07 PM, Gunnar Morling
wrote:
> Right; you also can use the same tag several times if you want several
> distinct snippets from a file to end up in one
This is how you mark an anchor in the source code:
//tag::constraintMapping[]HibernateValidatorConfiguration configuration =
Validation.byProvider( HibernateValidator.class )
.configure();
ConstraintMapping constraintMapping =
configuration.createConstraintMapping();
constraintMapping
Hi Gunnar,
That's really cool, I didn't know that.
We have the old code snippets as they were copied from the docbook folder
and there are also some new tests that I wrote for the new content.
I could really use this approach for the new snippets.
Vlad
On Wed, Jan 13, 2016 at 4:47 PM, Gunnar Mor
Gunnar, that's very awesome. You mention being able to include snippets of
an actual source file. Do you have pointers to an explanation of the
snippets/portion part of that?
On Wed, Jan 13, 2016 at 8:47 AM Gunnar Morling wrote:
> Hey Vlad,
>
> slightly related and just in case you are not awa
Hey Vlad,
slightly related and just in case you are not aware of this feature
yet: You can include (parts of) actual source code files straight into
AsciiDoc documents. We do that in the HV reference guide, e.g. at [1].
That way you are 100% sure your examples actually compile (and pass
tests) and
Hi Steve,
The User Guide illustrations are snippets of code that go into the extras
folder, which stays right next to every chapter.
That's in the main folder.
The tests are now located in the test folder of the documentation folder,
so that we can update/evolve them in future.
They are also a pr
Vlad, I see you created a PR for moving your new tests out of
hibernate-entitymanager into documentation. I guess that depends on the
intent. Are they meant as illustrations? And if so, how are you expecting
people will see them? And if they are meant as real tests rather than as
illustrations,
I'm not against the use of Java 8 letting AnimalSniffer guarding for
compatibility,
but I understand this can cause some problems so I'm ok with removing Java
8 usage from tests.
On 12 January 2016 at 10:07, Gunnar Morling wrote:
> @Vlad, what Java 8 syntax specifically are you using in the user
@Vlad, what Java 8 syntax specifically are you using in the user guide
tests (examples?)?
I like the idea of using a current syntax in usage examples, to give
the guide a current look and show that our APIs play well with current
Java versions (while staying compatible with older ones).
2016-01
+1 for Vlad's proposal to use the same JDK for tests and main code in
a given module.
Infinispan requires Java8 at runtime too, so that module should be the
only one to use Java8?
On 12 January 2016 at 07:55, Vlad Mihalcea wrote:
> I used Java 8 syntax in the User Guide tests as I remembered tha
I used Java 8 syntax in the User Guide tests as I remembered that tests can
use it, but I also agree that this is a rather strange move.
Since we need to support Java 1.6, maybe it's a better idea to use the
latest JDK just in the modules where we have no other choice.
For testing, I think that 1.6
The former. People commit things that already assume the move to Java 8
locally to build (and test). But at the moment we have not formalized
that, and so that causes problems when we import into an IDE - the imported
IDE project is built for 1.6 compliance and so everything we try in the IDE
fai
Hey,
> or we move to Java 8 and rely on
> AnimalSniffer to make sure we are still compatible.
WDYM by "move to Java8" exactly? Requiring it at Hibernate's build
time, or also at runtime in user apps?
2016-01-11 19:49 GMT+01:00 Steve Ebersole :
> The use of Java 8 features in Hibernate ORM is st
The use of Java 8 features in Hibernate ORM is starting to expand. Luckily
it is still constrained to just tests.
However these usages make development in an IDE more and more difficult.
Previously this was isolated to hibernate-infinispan. Now[1] this has
crept into hibernate-entitymanager. We
17 matches
Mail list logo
