[hibernate-dev] New stored procedure support

2013-08-01 Thread Christian Bauer
Some of the issues I've found with JPA 2.1 and the overall new stored procedure APIs: 1. StoredProcedureQuery#hasMoreResults() returns true if the next result is an update count, it should return false, according to API documentation. On MySQL, if a SP returns a single or multiple ResultSets,

Re: [hibernate-dev] New stored procedure support

2013-08-01 Thread Steve Ebersole
Overall I am pretty confident you are not using the latest as we discussed on IRC. But some comments inline... On Thu 01 Aug 2013 10:30:04 AM CDT, Christian Bauer wrote: - show quoted text - Yes I think this is still a bug. I'll fix this. Its because of the concept of Returns. I should

Re: [hibernate-dev] New stored procedure support

2013-08-01 Thread Christian Bauer
On 01.08.2013, at 19:01, Steve Ebersole steven.ebers...@gmail.com wrote: 2. If there is only one ResultSet returned by the SP, I should be able to call StoredProcedureQuery#getResultList() without first calling hasMoreResults(). This maps to JDBC CallableStatement#excuteQuery(). Like I

Re: [hibernate-dev] New stored procedure support

2013-08-01 Thread Steve Ebersole
Actually thats easy. The following block in getResultList() should just go away: if ( outputs().hasMoreReturns() ) { outputs().getNextReturn(); } I just missed removing that when moving to the getCurrentReturn() model. On 08/01/2013 01:05 PM, Christian Bauer