On 7 March 2018 at 13:02, Guillaume Smet wrote:
> On Wed, Mar 7, 2018 at 1:53 PM, Sanne Grinovero wrote:
>>
>> Let's not rush things and see what Christian thinks: he should be
>> allowed to analyze this - if he has time and wants to - w/o too much
>> pressure. I see the last report is an NPE, th
On Wed, Mar 7, 2018 at 1:53 PM, Sanne Grinovero wrote:
> Let's not rush things and see what Christian thinks: he should be
> allowed to analyze this - if he has time and wants to - w/o too much
> pressure. I see the last report is an NPE, that's typically not too
> hard to fix so I'd rather try a
Let's not rush things and see what Christian thinks: he should be
allowed to analyze this - if he has time and wants to - w/o too much
pressure. I see the last report is an NPE, that's typically not too
hard to fix so I'd rather try again.
The risk with a full revert is that it's never getting fix
I agree with the revert solution Guillaume proposed.
On 7 March 2018 at 12:25, Guillaume Smet wrote:
> Apparently, there is still an issue with the latest fix but a different
> one:
> https://hibernate.atlassian.net/browse/HHH-12332?page=com.
> atlassian.jira.plugin.system.issuetabpanels%3Acomme
Apparently, there is still an issue with the latest fix but a different one:
https://hibernate.atlassian.net/browse/HHH-12332?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&focusedCommentId=101427#comment-101427
I posted a message to try to help the OP isolating the issue.
sorry but I had an horrible night and not feeling great right now so I'll
do the release late this afternoon or tomorrow morning.
On 6 March 2018 at 19:32, Chris Cranford wrote:
> Gail -
>
> I asked Andrea earlier and he hoped Wednesday March 7th; however he did
> say it depends on the status of
Gail -
I asked Andrea earlier and he hoped Wednesday March 7th; however he did
say it depends on the status of Christian's fix.
On 03/06/2018 02:13 PM, Gail Badner wrote:
> When are you planning to release? I'd like to take a look at the original
> fix and PR as well.
>
> On Tue, Mar 6, 2018 at 5
When are you planning to release? I'd like to take a look at the original
fix and PR as well.
On Tue, Mar 6, 2018 at 5:44 AM, Steve Ebersole wrote:
> +1
>
> If you are confident, that's good for me
>
>
> On Tue, Mar 6, 2018, 7:24 AM Sanne Grinovero wrote:
>
> > On 6 March 2018 at 11:21, Christi
+1
If you are confident, that's good for me
On Tue, Mar 6, 2018, 7:24 AM Sanne Grinovero wrote:
> On 6 March 2018 at 11:21, Christian Beikov
> wrote:
> > Hey,
> >
> > I'm fine with reverting the patch as well, though I just fixed the issue
> > Andrea found and am confident about the solution
On 6 March 2018 at 11:21, Christian Beikov wrote:
> Hey,
>
> I'm fine with reverting the patch as well, though I just fixed the issue
> Andrea found and am confident about the solution now.
Hi Christian, that's great! Let's go with your fix then.
Thanks,
Sanne
>
>
> Mit freundlichen Grüßen,
>
Hey,
I'm fine with reverting the patch as well, though I just fixed the issue
Andrea found and am confident about the solution now.
Mit freundlichen Grüßen,
*Christian Beikov*
Am 06.03.2018 um 11:57 schrieb Guillaume Smet:
nothing against reverting the PR that caused this issue.
On 6 March 2018 at 10:57, Guillaume Smet wrote:
> Hi,
>
> So, AFAICS, Andrea found another failing case for the new PR.
>
> I would vote for reverting the original patch [
> https://hibernate.atlassian.net/browse/HHH-11544] for now and let
Hi,
So, AFAICS, Andrea found another failing case for the new PR.
I would vote for reverting the original patch [
https://hibernate.atlassian.net/browse/HHH-11544] for now and let Christian
the time to think of a proper fix. I'm a bit worried we will miss something
if we try to find a fix in a hu
Just so that nobody misses it, Christian pushed a PR here:
https://github.com/hibernate/hibernate-orm/pull/2180 .
Will require someone more familiar with ORM than me to review it :).
Thanks.
On Mon, Mar 5, 2018 at 7:54 PM, Gail Badner wrote:
> +1 to a quick release, with a partial solution if
+1 to a quick release, with a partial solution if necessary.
On Mon, Mar 5, 2018 at 7:28 AM, Steve Ebersole wrote:
> I agree that in general it is ok to cut a release with a partial solution
> in a case like this
>
> On Mon, Mar 5, 2018 at 8:40 AM andrea boriero
> wrote:
>
> > If there are no o
I agree that in general it is ok to cut a release with a partial solution
in a case like this
On Mon, Mar 5, 2018 at 8:40 AM andrea boriero wrote:
> If there are no objections I can manage a release as soon as a fix is
> ready.
>
> On 5 March 2018 at 14:20, Chris Cranford wrote:
>
> > On 03/05/
If there are no objections I can manage a release as soon as a fix is ready.
On 5 March 2018 at 14:20, Chris Cranford wrote:
> On 03/05/2018 08:26 AM, Sanne Grinovero wrote:
> > On 5 March 2018 at 12:27, Guillaume Smet
> > wrote:
> >> Hi, So far we had 4 duplicate reports of
> >> https://hibern
On 03/05/2018 08:26 AM, Sanne Grinovero wrote:
> On 5 March 2018 at 12:27, Guillaume Smet
> wrote:
>> Hi, So far we had 4 duplicate reports of
>> https://hibernate.atlassian.net/browse/HHH-12332 (so not counting the
>> users having seen the bug and not opening a new one). I think this
>> issue qua
Hi Christian,
On Mon, Mar 5, 2018 at 2:15 PM, Christian Beikov wrote:
>
> I have a fix for the NPE the user reported, but there is one edge case,
> which hasn't been rerported yet as it seems exotic, that I am still trying
> to figure out.
> I can provide the "partial fix" later today if you like
On 5 March 2018 at 12:27, Guillaume Smet wrote:
> Hi,
>
> So far we had 4 duplicate reports of
> https://hibernate.atlassian.net/browse/HHH-12332 (so not counting the users
> having seen the bug and not opening a new one).
>
> I think this issue qualifies as "we should really get a hotfix release
Hi,
So far we had 4 duplicate reports of
https://hibernate.atlassian.net/browse/HHH-12332 (so not counting the users
having seen the bug and not opening a new one).
I think this issue qualifies as "we should really get a hotfix release
soon".
I let the duplicated issues open for now as I saw a c
21 matches
Mail list logo
