[hibernate-dev] Removing dom4j?

2018-02-16 Thread Jordan Gigov
So, the library has not seen a bugfix in over 10 years, and it lists the wrong version for it's xml-apis dependency. There are some notes in comments about eventually removing it, and I thought I'd give it a try on the 5.2 branch. I had to remove two shiv-libraries you had added to work around prob

Re: [hibernate-dev] Removing dom4j?

2018-02-16 Thread Sanne Grinovero
Hi Jordan, I think it would be great to remove it. Especially recently we've started exploring what it would take to convert all jars into proper Jigsaw modules, and a requirement is that all dependencies need to be converted as well; this is obviously more problematic for such old libraries so it

Re: [hibernate-dev] Removing dom4j?

2018-02-16 Thread Jordan Gigov
The woodstox dependency is incompatible with the rest of the XML API due to a bug in the JDK that is otherwise hidden in all cases in the default implementation. Specifically it's implementation of EndElement brings that bug to the forefront, when com.sun.org.apache.xalan.internal.xsltc.trax.StAXE

Re: [hibernate-dev] Removing dom4j?

2018-02-17 Thread Steve Ebersole
Would we be interested? Heck yeah. We have just not put in the effort because it is used for such a small subset of features *and* we plan to not use DOM/SAX directly moving forward (we are transitioning to JAXB). All that said though, I am surprised you ran into so few problems. Envers e.g. ma

Re: [hibernate-dev] Removing dom4j?

2018-02-18 Thread Jordan Gigov
I think transitioning to automatic bindings via JAXB will result in error messages on wrong configurations becoming far too vague to be useful to the users. That's just an opinion, though. I tried building from a clean master branch at home on Windows 10 before moving the changes, but the multilin

Re: [hibernate-dev] Removing dom4j?

2018-02-18 Thread Steve Ebersole
On Sun, Feb 18, 2018 at 4:52 AM Jordan Gigov wrote: > I think transitioning to automatic bindings via JAXB will result in error > messages on wrong configurations becoming far too vague to be useful to the > users. > I'm not understanding... we've used jaxb since 4.0 I am just talking about env

Re: [hibernate-dev] Removing dom4j?

2018-02-19 Thread Chris Cranford
See below On 02/18/2018 11:38 AM, Steve Ebersole wrote: > On Sun, Feb 18, 2018 at 4:52 AM Jordan Gigov wrote: > >> I think transitioning to automatic bindings via JAXB will result in error >> messages on wrong configurations becoming far too vague to be useful to the >> users. >> > I'm not unders

Re: [hibernate-dev] Removing dom4j?

2018-02-20 Thread Jordan Gigov
Well, it took longer than expected as the source of the failures became more obscure, but here it is, done on the master (5.3) branch. https://github.com/coladict/hibernate-orm/tree/dom4j-removal It's in the dom4j-removal branch. The tests for entity-mode dom4j have been removed, but it might be

Re: [hibernate-dev] Removing dom4j?

2018-02-21 Thread Chris Cranford
See inline On 02/20/2018 10:52 AM, Jordan Gigov wrote: > Well, it took longer than expected as the source of the failures > became more obscure, but here it is, done on the master (5.3) branch. > > https://github.com/coladict/hibernate-orm/tree/dom4j-removal > It's in the dom4j-removal branch. > >

Re: [hibernate-dev] Removing dom4j?

2018-02-21 Thread Chris Cranford
Another alternative (at least for Envers) might be to incorporate the JAXB work I did into 5.3 rather than wait for 6.0. Steve/Andrea, either of you have a preference one way or another? On 02/21/2018 10:52 AM, Chris Cranford wrote: > See inline > > On 02/20/2018 10:52 AM, Jordan Gigov wrote: >>