Re: [hibernate-dev] TableGenerator missing "not null"

2008-12-12 Thread Chris Bredesen
Juraci Costa wrote: - "Chris Bredesen" escreveu: The not null constraint is redundant in Oracle and possibly others; you wind up with two constraints on the table if you specify PK & not null. I don't think so. I tested in our QA lab in both Oracle 9i and 10g. Only one constraint and o

Re: [hibernate-dev] TableGenerator missing "not null"

2008-12-12 Thread Juraci Costa
- "Steve Ebersole" escreveu: > I am surprised that DB2 does not allow nulls and yet forces you to > specify "not null" since it is totally redundant: PK cannot be null > on > DB2 by definition yet it forces user to explicitly specify "not null" Not only that: they even have a very specific er

Re: [hibernate-dev] TableGenerator missing "not null"

2008-12-12 Thread Steve Ebersole
I am surprised that DB2 does not allow nulls and yet forces you to specify "not null" since it is totally redundant: PK cannot be null on DB2 by definition yet it forces user to explicitly specify "not null" :/ The patch looks fine to me in this case. - Steve Ebersole Project Lead http://hib

Re: [hibernate-dev] TableGenerator missing "not null"

2008-12-12 Thread Juraci Costa
- "Chris Bredesen" escreveu: > The not null constraint is redundant in Oracle and possibly others; > you > wind up with two constraints on the table if you specify PK & not > null. I don't think so. I tested in our QA lab in both Oracle 9i and 10g. Only one constraint and only one index. T

Re: [hibernate-dev] TableGenerator missing "not null"

2008-12-12 Thread Chris Bredesen
The not null constraint is redundant in Oracle and possibly others; you wind up with two constraints on the table if you specify PK & not null. Perhaps we need an attribute on the Dialect for this... -CB Juraci Costa wrote: Guys, As suggested in a previous topic, I'll pay a genuine Czech be

[hibernate-dev] TableGenerator missing "not null"

2008-12-12 Thread Juraci Costa
Guys, As suggested in a previous topic, I'll pay a genuine Czech beer in any pub in Brno for whoever reviews the patch in HHH-3650[1] (or Moravian wine, if you prefer) :-) The class org.hibernate.id.enhanced.TableGenerator is used to generate tables which acts as sequences. In the method sqlCr