RE: [Hibernate] use ant checkstyle

2004-06-28 Thread Joshua Davis
org.hibernate.hql and sub-packages now comply with checkstyle > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On > Behalf Of Emmanuel Bernard > Sent: Monday, June 28, 2004 7:59 PM > To: [EMAIL PROTECTED] > Subject: [Hibernate] use ant checkstyle > > > Please

[Hibernate] What would this break: Paged Entity Loader?

2004-06-28 Thread Simon Spero
I've been kicking this idea around for a bit: If you have a persistent class which has a numeric identifier type whose values are allocated sequentially, and if you often access instances of the class in a similar order to the order in which you create them, you can get a pretty good hit rate by

[Hibernate] use ant checkstyle

2004-06-28 Thread Emmanuel Bernard
Please use ant checkstyle before any commit. I've fixed half of the issues, I've left : - org.hibernate.hql - org.hibernate.collection -- Emmanuel Bernard [EMAIL PROTECTED] http://www.hibernate.org --- This SF.Net email sponsored by Black Hat Bri

Fwd: [Hibernate] Check named queries

2004-06-28 Thread Christian Bauer
On Jun 28, 2004, at 6:45 PM, Emmanuel Bernard wrote: Actually the ant task wrapping is done and just call for a session factory build. Do you think it's enough? I think the validator should do the following: - Compile all mapping documents to metamodel, check for persistent classes - Compile all

Re: [Hibernate] Check named queries

2004-06-28 Thread Emmanuel Bernard
Actually the ant task wrapping is done and just call for a session factory build. Do you think it's enough? Christian Bauer wrote: On Jun 28, 2004, at 6:27 PM, Emmanuel Bernard wrote: I would be ready to apply the YAGNI principle and not provide such param (yet). What do you guys think? I think

Re: [Hibernate] Check named queries

2004-06-28 Thread Christian Bauer
On Jun 28, 2004, at 6:27 PM, Emmanuel Bernard wrote: I would be ready to apply the YAGNI principle and not provide such param (yet). What do you guys think? I think it should be configurable. I've heard one or two requests for a "mapping validation tool" that you could run independently from Hib

Re: [Hibernate] Hibernate3 HEAD

2004-06-28 Thread Emmanuel Bernard
2) I've fixed the XMLDataBinder one. There is still 1 failure on refresh with lock mode (MasterDetailTest). The LockMode seems not to be applied. This part is still too obscure for me. Joshua Davis wrote: Should I add the task to the build file so that I can compile with 1.4? 1) It still doesn't

[Hibernate] Check named queries

2004-06-28 Thread Emmanuel Bernard
I'll commit a patch allowing checking of named queries at SessionFactory build. I'm wondering whether this feature should be disabled by configuration or not. Imagine you're working on an Hibernate Query and you don't call for it in your code yet. The checking will fail unless you comment it on

Re: [Hibernate] Hibernate3 HEAD

2004-06-28 Thread Simon Spero
Joshua Davis wrote: 1) It still doesn't compile with 1.4. 2) There are still unit test failures. I had a few problems building with generics-ea-2.4: The problem was due to the change in the method signature in ObjectFactory; the generics compiler doesn't have the updated inteface in its stubs