Re: [Hibernate] HQL/EJBQL built-in functions

2005-01-09 Thread Gavin King
OK, understood, I will throw away that stuff. Joshua Davis wrote: What I'm getting at is that adding new keywords should only be added when it's absolutely necessary. New keywords can break upward compatibility and make it difficult to extend the language later. Joshua Davis wrote: upper(x) an

Re: [Hibernate] HQL/EJBQL built-in functions

2005-01-09 Thread Gavin King
Joshua Davis wrote: Did you add current_date, current_time, and current_timestamp as keywords, or as specially interpreted identifiers (i.e. semantic actions only)? I added them as keywords. -- Gavin King +61 410 534 454 +1 404 822 8349 callto://gavinking Hibernate [EMAIL PROTECTED] http://hibern

Re: [Hibernate] HQL/EJBQL built-in functions

2005-01-06 Thread Joshua Davis
What I'm getting at is that adding new keywords should only be added when it's absolutely necessary. New keywords can break upward compatibility and make it difficult to extend the language later. Joshua Davis wrote: upper(x) and lower(x) should be handled by the 'method' syntax and semantic

Re: [Hibernate] HQL/EJBQL built-in functions

2005-01-06 Thread Joshua Davis
upper(x) and lower(x) should be handled by the 'method' syntax and semantic actions, no? Did you add current_date, current_time, and current_timestamp as keywords, or as specially interpreted identifiers (i.e. semantic actions only)? Gavin King wrote: Last night I wrote some code which I was k

[Hibernate] HQL/EJBQL built-in functions

2005-01-06 Thread Gavin King
Last night I wrote some code which I was kinda proud of at the time (I proved I could add new functionality to the query parser all by myself), but now I'm not so sure that my approach was Good. Basically, I added the builtin functions to the grammar - stuff like this: lower(x) upper(x) current_