Ariel Weinberger pushed to branch feature/CC-CHANNELMGR-1484 at cms-community /
hippo-addon-channel-manager
Commits:
056c526a by Ariel Weinberger at 2017-11-01T12:51:37+01:00
CHANNELMGR-1484 Add a CreateContent mocks file, apply on NameUrlFields to get
tests working
- Remove mocks from step-1.component.spec.ts file and add them to the newly
created create-content.mocks.spec.ts
- - - - -
3 changed files:
- +
frontend-ng/src/app/channel/sidePanels/rightSidePanel/create-content/create-content.mocks.spec.ts
-
frontend-ng/src/app/channel/sidePanels/rightSidePanel/create-content/name-url-fields/name-url-fields.component.spec.ts
-
frontend-ng/src/app/channel/sidePanels/rightSidePanel/create-content/step-1/step-1.component.spec.ts
Changes:
=====================================
frontend-ng/src/app/channel/sidePanels/rightSidePanel/create-content/create-content.mocks.spec.ts
=====================================
--- /dev/null
+++
b/frontend-ng/src/app/channel/sidePanels/rightSidePanel/create-content/create-content.mocks.spec.ts
@@ -0,0 +1,16 @@
+import { Observable } from 'rxjs/Observable';
+import { TemplateQuery } from './create-content.types';
+
+export class CreateContentServiceMock {
+ getTemplateQuery(id): Observable<TemplateQuery> {
+ return Observable.of(null);
+ }
+
+ generateDocumentUrlByName(name): Observable<string> {
+ return Observable.of(name.replace(/\s+/g, '-').toLowerCase()); // will
transform "TestName123" into "test-name-123"
+ }
+}
+
+export class FeedbackServiceMock {
+ showError(key: string, params: Map<string, any>): void {}
+}
=====================================
frontend-ng/src/app/channel/sidePanels/rightSidePanel/create-content/name-url-fields/name-url-fields.component.spec.ts
=====================================
---
a/frontend-ng/src/app/channel/sidePanels/rightSidePanel/create-content/name-url-fields/name-url-fields.component.spec.ts
+++
b/frontend-ng/src/app/channel/sidePanels/rightSidePanel/create-content/name-url-fields/name-url-fields.component.spec.ts
@@ -17,17 +17,19 @@
import { TestBed, ComponentFixture, fakeAsync, tick } from
'@angular/core/testing';
import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
import { FormsModule } from '@angular/forms';
-import { DebugElement } from '@angular/core';
+import { DebugElement, Injector } from '@angular/core';
import 'rxjs/add/observable/of';
import 'rxjs/add/observable/throw';
import { NameUrlFieldsComponent } from "./name-url-fields.component";
import { HintsComponent } from
"../../../../../shared/components/hints/hints.component";
import { SharedModule } from "../../../../../shared/shared.module";
+import { CreateContentService } from '../create-content.service';
+import { CreateContentServiceMock } from '../create-content.mocks.spec';
describe('NameUrlFields Component', () => {
-
let component: NameUrlFieldsComponent;
let fixture: ComponentFixture<NameUrlFieldsComponent>;
+ let createContentService: CreateContentService;
let de: DebugElement;
let el: HTMLElement;
@@ -41,11 +43,15 @@ describe('NameUrlFields Component', () => {
BrowserAnimationsModule,
FormsModule,
SharedModule
+ ],
+ providers: [
+ { provide: CreateContentService, useClass: CreateContentServiceMock },
]
});
fixture = TestBed.createComponent(NameUrlFieldsComponent);
component = fixture.componentInstance;
+ createContentService =
fixture.debugElement.injector.get(CreateContentService);
component.ngOnInit();
fixture.detectChanges();
=====================================
frontend-ng/src/app/channel/sidePanels/rightSidePanel/create-content/step-1/step-1.component.spec.ts
=====================================
---
a/frontend-ng/src/app/channel/sidePanels/rightSidePanel/create-content/step-1/step-1.component.spec.ts
+++
b/frontend-ng/src/app/channel/sidePanels/rightSidePanel/create-content/step-1/step-1.component.spec.ts
@@ -23,24 +23,14 @@ import 'rxjs/add/observable/throw';
import { TemplateQuery, DocumentTypeInfo } from '../create-content.types';
import { CreateContentComponent } from '../step-1/step-1.component';
-import { CreateContentService } from '../create-content.service';
import FeedbackService from '../../../../../services/feedback.service';
+import { CreateContentService } from '../create-content.service';
import { HintsComponent } from
'../../../../../shared/components/hints/hints.component';
-import { MaterialModule } from
'../../../../../shared/material/material.module';
import { NameUrlFieldsComponent } from
"../name-url-fields/name-url-fields.component";
+import { SharedModule } from '../../../../../shared/shared.module';
+import { CreateContentServiceMock, FeedbackServiceMock } from
'../create-content.mocks.spec';
-class CreateContentServiceMock {
- getTemplateQuery(id): Observable<TemplateQuery> {
- return Observable.of(null);
- }
-}
-
-class FeedbackServiceMock {
- showError(key: string, params: Map<string, any>): void {}
-}
-
-fdescribe('Create content component', () => {
-
+describe('Create content component', () => {
let component: CreateContentComponent;
let fixture: ComponentFixture<CreateContentComponent>;
let createContentService: CreateContentService;
@@ -54,9 +44,8 @@ fdescribe('Create content component', () => {
NameUrlFieldsComponent
],
imports: [
- BrowserAnimationsModule,
+ SharedModule,
FormsModule,
- MaterialModule,
],
providers: [
{ provide: CreateContentService, useClass: CreateContentServiceMock },
View it on GitLab:
https://code.onehippo.org/cms-community/hippo-addon-channel-manager/commit/056c526a653d0df3c3aefe11974736a994f3e226
---
View it on GitLab:
https://code.onehippo.org/cms-community/hippo-addon-channel-manager/commit/056c526a653d0df3c3aefe11974736a994f3e226
You're receiving this email because of your account on code.onehippo.org.
_______________________________________________
Hippocms-svn mailing list
Hippocms-svn@lists.onehippo.org
https://lists.onehippo.org/mailman/listinfo/hippocms-svn
