[jira] Commented: (HIVE-1359) Unit test should be shim-aware

[ https://issues.apache.org/jira/browse/HIVE-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12881255#action_12881255 ] Namit Jain commented on HIVE-1359: -- Requirements 2 and 3 are not addressed in the above

[jira] Commented: (HIVE-1359) Unit test should be shim-aware

[ https://issues.apache.org/jira/browse/HIVE-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12881258#action_12881258 ] Namit Jain commented on HIVE-1359: -- This is also needed for

[jira] Commented: (HIVE-1359) Unit test should be shim-aware

[ https://issues.apache.org/jira/browse/HIVE-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12881274#action_12881274 ] Namit Jain commented on HIVE-1359: -- Looks good to me - John, can you also review ? Unit

[jira] Commented: (HIVE-1359) Unit test should be shim-aware

[ https://issues.apache.org/jira/browse/HIVE-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12881285#action_12881285 ] John Sichi commented on HIVE-1359: -- Since we're not actually dealing with the minimr

[jira] Commented: (HIVE-1359) Unit test should be shim-aware

[ https://issues.apache.org/jira/browse/HIVE-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12881431#action_12881431 ] John Sichi commented on HIVE-1359: -- +1. Will commit when tests pass. Unit test should

[jira] Commented: (HIVE-1359) Unit test should be shim-aware

[ https://issues.apache.org/jira/browse/HIVE-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12872990#action_12872990 ] Ashish Thusoo commented on HIVE-1359: - +1 to all the great suggestions in this

[jira] Commented: (HIVE-1359) Unit test should be shim-aware

[ https://issues.apache.org/jira/browse/HIVE-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12873132#action_12873132 ] Ning Zhang commented on HIVE-1359: -- @ashish, what you propose is a finer granular control

[jira] Commented: (HIVE-1359) Unit test should be shim-aware

[ https://issues.apache.org/jira/browse/HIVE-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871850#action_12871850 ] Ning Zhang commented on HIVE-1359: -- Discussed offline with Namit, John, and Paul. We need

[jira] Commented: (HIVE-1359) Unit test should be shim-aware

[ https://issues.apache.org/jira/browse/HIVE-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871940#action_12871940 ] John Sichi commented on HIVE-1359: -- Regarding proposed change #1, let's keep the test

[jira] Commented: (HIVE-1359) Unit test should be shim-aware

[ https://issues.apache.org/jira/browse/HIVE-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12871982#action_12871982 ] Ning Zhang commented on HIVE-1359: -- #1: will do that in a separate xml file. #2:

[jira] Commented: (HIVE-1359) Unit test should be shim-aware

[ https://issues.apache.org/jira/browse/HIVE-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12870126#action_12870126 ] Ning Zhang commented on HIVE-1359: -- The proposal is to change the unit test directory

[jira] Commented: (HIVE-1359) Unit test should be shim-aware

[ https://issues.apache.org/jira/browse/HIVE-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12870239#action_12870239 ] Namit Jain commented on HIVE-1359: -- Let us generalize it even more - was talking to John