[
https://issues.apache.org/jira/browse/HIVE-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12900012#action_12900012
]
John Sichi commented on HIVE-1518:
--
Running through tests now.
> context_ngrams() UDAF fo
[
https://issues.apache.org/jira/browse/HIVE-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899684#action_12899684
]
John Sichi commented on HIVE-1518:
--
Oops, I'm getting a conflict when attempting to apply t
[
https://issues.apache.org/jira/browse/HIVE-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899682#action_12899682
]
John Sichi commented on HIVE-1518:
--
+1. Will commit when tests pass.
> context_ngrams() U
[
https://issues.apache.org/jira/browse/HIVE-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899624#action_12899624
]
John Sichi commented on HIVE-1518:
--
Now there are a bunch of redundant casts remaining, e.g
[
https://issues.apache.org/jira/browse/HIVE-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898425#action_12898425
]
HBase Review Board commented on HIVE-1518:
--
Message from: "John Sichi"
--
[
https://issues.apache.org/jira/browse/HIVE-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898421#action_12898421
]
HBase Review Board commented on HIVE-1518:
--
Message from: "John Sichi"
--
[
https://issues.apache.org/jira/browse/HIVE-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896187#action_12896187
]
Mayank Lahiri commented on HIVE-1518:
-
Note that this generalizes ngrams(), but is less