[
https://issues.apache.org/jira/browse/HIVE-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731020#action_12731020
]
Namit Jain commented on HIVE-623:
-
+1
looks good - will commit if the tests pass
> Optimize
[
https://issues.apache.org/jira/browse/HIVE-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730648#action_12730648
]
Namit Jain commented on HIVE-623:
-
Can you make the check as a function in
./ql/src/java/org
[
https://issues.apache.org/jira/browse/HIVE-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730637#action_12730637
]
Namit Jain commented on HIVE-623:
-
Otherwise, the code changes look good
> Optimize length a
[
https://issues.apache.org/jira/browse/HIVE-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730634#action_12730634
]
Namit Jain commented on HIVE-623:
-
yes, you should make that change and submit the patch
> O
[
https://issues.apache.org/jira/browse/HIVE-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730632#action_12730632
]
Zheng Shao commented on HIVE-623:
-
Text.charAt(i) is actually very expensive - it calls ByteB
[
https://issues.apache.org/jira/browse/HIVE-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730602#action_12730602
]
Namit Jain commented on HIVE-623:
-
In the test udf_reverse.q, can you change the test to sele
