RE: thread cofinement session state

2009-03-09 Thread Joydeep Sen Sarma
Are u observing very high memory usage? The session state should be available for cleanup once the connection is closed. So really should only scale to number of active connections - at this point that would be a _great_ problem to have :) (since no one's even really used the thrift server for r

Re: thread cofinement session state

2009-03-09 Thread Min Zhou
oops, my fault. It works now. However, the overhead initializing a new session state is too high. I guess it will cause a StackOverflowError when connection reaching a certain amount. On Tue, Mar 10, 2009 at 2:16 PM, Min Zhou wrote: > No connection right now, the server can not start well. > >

Re: thread cofinement session state

2009-03-09 Thread Min Zhou
No connection right now, the server can not start well. On Tue, Mar 10, 2009 at 2:07 PM, Joydeep Sen Sarma wrote: > Hey – not able to understand – does this mean it didn’t work. Can u > explain in more detail what u did (how many connections/requests etc.) > > > --

Re: thread cofinement session state

2009-03-09 Thread Min Zhou
It didnot work, I am finding the reason, but I think you are in the right way. On Tue, Mar 10, 2009 at 2:07 PM, Joydeep Sen Sarma wrote: > Hey – not able to understand – does this mean it didn’t work. Can u > explain in more detail what u did (how many connections/requests etc.) > > > -

RE: thread cofinement session state

2009-03-09 Thread Joydeep Sen Sarma
Hey - not able to understand - does this mean it didn't work. Can u explain in more detail what u did (how many connections/requests etc.) From: Min Zhou [mailto:coderp...@gmail.com] Sent: Monday, March 09, 2009 11:04 PM To: hive-user@hadoop.apache.org Subject: Re

Re: thread cofinement session state

2009-03-09 Thread Min Zhou
The server was keeping stay at the start point. On Tue, Mar 10, 2009 at 1:36 PM, Joydeep Sen Sarma wrote: > Attaching a small patch. Can u try and see if this works? (it compiles > and passes the hiveserver test) > > > > It does seem that the getProcessor() call is made every time a new > conne

RE: thread cofinement session state

2009-03-09 Thread Joydeep Sen Sarma
Attaching a small patch. Can u try and see if this works? (it compiles and passes the hiveserver test) It does seem that the getProcessor() call is made every time a new connection starts to get serviced (so, yes, after the accept call). From: Min Zhou [mailto:c

Re: thread cofinement session state

2009-03-09 Thread Min Zhou
Hi, On Tue, Mar 10, 2009 at 12:07 PM, Prasad Chakka wrote: > I use a thread specific storage to do something similar. Ie. I keep the > initialized session in the tss so new threads will not have it initialized. > Would that work here? > I am sorry you misunderstanded our meaning, we are talki

RE: thread cofinement session state

2009-03-09 Thread Joydeep Sen Sarma
I don't think tss will work here since from what I can understand - the same thread can serve different connections. The session is associated with the connection right now - so it needs to be reset once the serving thread switches from one connection to another. Especially once the thrift serve

Re: thread cofinement session state

2009-03-09 Thread Prasad Chakka
I use a thread specific storage to do something similar. Ie. I keep the initialized session in the tss so new threads will not have it initialized. Would that work here? From: Joydeep Sen Sarma Reply-To: Date: Mon, 9 Mar 2009 20:44:02 -0700 To: Subject: RE: t

RE: thread cofinement session state

2009-03-09 Thread Joydeep Sen Sarma
Min is right. this seems a little screwed up. The Thrift Interface handler is constructed just once for the lifetime of the HiveServer. The session object is initialized inside this constructor. The SessionState.start() is called only once (in the constructor) All connections/requests then go t

Re: thread cofinement session state

2009-03-09 Thread Min Zhou
On Tue, Mar 10, 2009 at 11:23 AM, Prasad Chakka wrote: > TThreadPoolServer is supposed to use a new thread for each connection. > Exactly! But I dont think it will construct a new session state for the new thread, for new connection in other words. > > > -- > *F

Re: thread cofinement session state

2009-03-09 Thread Prasad Chakka
I am assuming he is using the same code as MetaStore server. AFAIK, TThreadPoolServer is supposed to use a new thread for each connection. From: Joydeep Sen Sarma Reply-To: Date: Mon, 9 Mar 2009 20:16:22 -0700 To: Subject: RE: thread cofinement session state

RE: thread cofinement session state

2009-03-09 Thread Joydeep Sen Sarma
(also been reading up on this code a bit just now) That's weird. It seems to be using TThreadPoolServer and that seems to just service all requests from a single connection in one thread. (and uses the same processor I assume that seems to initialize the session state in the interface construct

thread cofinement session state

2009-03-09 Thread Min Zhou
Hi list, I found each invoke of HiveServer's execute method run in different threads. Those threads which execute a HSQL query(not a client connection may execute several pieces of queries), have not their own session state. when I call SessionState.get(), it will return null beacuse session sta