Re: [htmltmpl] Patch to fix global_vars and loop problem...

2004-05-11 Thread simran
very good points :-) How is the attached as a patch... simran. On Wed, 2004-05-12 at 14:09, Sam Tregar wrote: > On Wed, 12 May 2004, simran wrote: > > > +foreach my $row (@$value) { > > + foreach my $key (keys %$row) { > > +$row->{$key} ||= ""; > > + }

Re: [htmltmpl] warning_on_bad_params (fwd)

2004-05-11 Thread Gabor Szabo
On Tue, 11 May 2004, Karen J. Cravens wrote: > On Wed, 12 May 2004, Gabor Szabo wrote: > > GS>Normally I'd do that but in our current setup he does not have a > GS>test server and I don't have the templates :( quite crazy. > GS>In any case he might later update the templates on the live server an

Re: [htmltmpl] Patch to fix global_vars and loop problem...

2004-05-11 Thread Sam Tregar
On Wed, 12 May 2004, simran wrote: > +foreach my $row (@$value) { > + foreach my $key (keys %$row) { > +$row->{$key} ||= ""; > + } > +} H. What happens when $row->{$key} is "0"? What happens when undef is set in a loop within a loop? I think th

[htmltmpl] Patch to fix global_vars and loop problem...

2004-05-11 Thread simran
Hi Sam, et al, Here are the details of (what i consider to be a bug anyway) a bug in HTML::Template - its been bought up before, and you have mentioned that it does need fixing, but it annoyed me enough today to produce a patch for it and submit the patch :-) Take the following example: =

Re: [htmltmpl] Whitespace (linefeed) suppression?

2004-05-11 Thread Karen J. Cravens
On Tue, 11 May 2004, Mark Fuller wrote: MF>Thank you! That will work for me. I still think the unusual appearance of MF>the solution points to something missing in H::T. But, I don't seem to be MF>getting anywhere. :) I dunno. Like I've said, I use H::T for building (non-HTML) email notification

Re: [htmltmpl] warning_on_bad_params

2004-05-11 Thread Karen J. Cravens
On Wed, 12 May 2004, Gabor Szabo wrote: GS>Normally I'd do that but in our current setup he does not have a GS>test server and I don't have the templates :( quite crazy. GS>In any case he might later update the templates on the live server and GS>I'd like to get informed about missed params. Buy

Re: [htmltmpl] Whitespace (linefeed) suppression?

2004-05-11 Thread Mathew Robertson
> > I don't think you're saying this, but doesn't your decision ultimately mean > > legibility of the template is outside the scope of H::T? On the one hand > > you're saying H::T does exactly what you tell it to do. On the other hand, > > if you write it legibly but don't like all the artifacts in

Re: [htmltmpl] Whitespace (linefeed) suppression?

2004-05-11 Thread Clifton Royston
On Tue, May 11, 2004 at 01:55:38PM -0700, Mark Fuller wrote: > From: "petersm" <[EMAIL PROTECTED]> > > Why should this matter (besides the bandwidth issue)? HTML ignores > whitespace > > and other than looking at the output of a template every now and then to > make > > sure that it is what you wan

Re: [htmltmpl] warning_on_bad_params

2004-05-11 Thread Gabor Szabo
On Tue, 11 May 2004, Sam Tregar wrote: > Sorry about that. I meant to reply but got distracted. no problem, > Run with die_on_bad_params on your test server and turn it off in > production. Normally I'd do that but in our current setup he does not have a test server and I don't have the templat

Re: [htmltmpl] warning_on_bad_params

2004-05-11 Thread petersm
Gabor Szabo > The issues is that I created a simple set of templates that > is used by someone to design a page from it. > Sometimes he is missing a few of the codes, especially > the new once I add. > > When we put the pages online I'd like to be sure they won't crash > because of bad params b

Re: [htmltmpl] warning_on_bad_params

2004-05-11 Thread Sam Tregar
On Wed, 12 May 2004, Gabor Szabo wrote: > I asked this a couple of days ago with no response. > > I'd really appreciate your feedback. Sorry about that. I meant to reply but got distracted. > When we put the pages online I'd like to be sure they won't crash > because of bad params but I'd like

Re: [htmltmpl] Whitespace (linefeed) suppression?

2004-05-11 Thread Mark Fuller
Thank you! That will work for me. I still think the unusual appearance of the solution points to something missing in H::T. But, I don't seem to be getting anywhere. :) Mark --- This SF.Net email is sponsored by Sleepycat Software Learn develo

Re: [htmltmpl] Whitespace (linefeed) suppression?

2004-05-11 Thread Mark Fuller
From: "Puneet Kishor" <[EMAIL PROTECTED]> > The thing is... it is so easy to get around this problem... as David > suggested... what is wrong with either html-tidy, or with s/\n\n/\n/g Nothing wrong with them. I only suggested it belongs in H::T. If the argument is that H::T shouldn't suffer the p

Re: [htmltmpl] Whitespace (linefeed) suppression?

2004-05-11 Thread Sam Tregar
On Tue, 11 May 2004, Mark Fuller wrote: > I don't think you're saying this, but doesn't your decision ultimately mean > legibility of the template is outside the scope of H::T? On the one hand > you're saying H::T does exactly what you tell it to do. On the other hand, > if you write it legibly bu

Re: [htmltmpl] Whitespace (linefeed) suppression?

2004-05-11 Thread Mark Fuller
From: "Sam Tregar" <[EMAIL PROTECTED]> > In my opinion, the problem is in your expectation. HTML::Template > gives you back exactly what you put in the template, ... > ... I consider this to be outside the scope of HTML::Template. I'm sorry. I was hoping you'd see the legitimacy of my suggestion.

Re: [htmltmpl] warning_on_bad_params

2004-05-11 Thread Gabor Szabo
I asked this a couple of days ago with no response. I'd really appreciate your feedback. The issues is that I created a simple set of templates that is used by someone to design a page from it. Sometimes he is missing a few of the codes, especially the new once I add. When we put the pages onli

Re: [htmltmpl] Whitespace (linefeed) suppression?

2004-05-11 Thread Karen J. Cravens
On Tue, 11 May 2004, Mark Fuller wrote: MF>Something's missing. I don't think post-processing the output is really the MF>answer when I could just say "NOLF" while authoring. FWIW, using whitespace *inside* the TMPL_IF statements goes a long way toward breaking things up without introducing extra

Re: [htmltmpl] Whitespace (linefeed) suppression?

2004-05-11 Thread Puneet Kishor
Mark Fuller wrote: From: "Puneet Kishor" <[EMAIL PROTECTED]> IMO, logic should belong in the script, not in the H-T markup, else it will become like php or coldfusion. The control tags (tmpl_if, tmpl_unless, etc.) provide basic programmatic control in the markup, but enough is enough, in my view.

Re: [htmltmpl] Whitespace (linefeed) suppression?

2004-05-11 Thread Sam Tregar
On Tue, 11 May 2004, Mark Fuller wrote: > It seems like there should be a way to express "TMPL_COMMENT" Then don't define "comment". Compare to the POD "=begin comment" convention which is very similar. > But, more importantly, it seems like something is missing in H::T > when I get som

Re: [htmltmpl] Whitespace (linefeed) suppression?

2004-05-11 Thread Mark Fuller
From: "Puneet Kishor" <[EMAIL PROTECTED]> > IMO, logic should belong in the > script, not in the H-T markup, else it will become like php or > coldfusion. The control tags (tmpl_if, tmpl_unless, etc.) provide basic > programmatic control in the markup, but enough is enough, in my view. It seems l

Re: [htmltmpl] Whitespace (linefeed) suppression?

2004-05-11 Thread David Hodgkinson
On 11 May 2004, at 21:19, Keith Jackson wrote: During previous discussions on this the suggestion was used to use tidy in some way. running the template output through HTML::Tidy in some way is a no-brainer... Obviously in HTML the whitespace is fairly harmless, but for an email template or usi

Re: [htmltmpl] Whitespace (linefeed) suppression?

2004-05-11 Thread Mark Fuller
From: "petersm" <[EMAIL PROTECTED]> > Why should this matter (besides the bandwidth issue)? HTML ignores whitespace > and other than looking at the output of a template every now and then to make > sure that it is what you want, why do you care what the output looks like? Why take bandwidth off th

Re: [htmltmpl] Whitespace (linefeed) suppression?

2004-05-11 Thread Puneet Kishor
Keith Jackson wrote: During previous discussions on this the suggestion was used to use tidy in some way. Obviously in HTML the whitespace is fairly harmless, but for an email template or using H::T for something other then HTML the whitespace makes a big difference. So I throw my vote in for a f

Re: [htmltmpl] Whitespace (linefeed) suppression?

2004-05-11 Thread petersm
Mark Fuller wrote: > If I have something like this for readability in the template: > > == > > > Error: > > > > (Forgot your password? Reset and email it to yourself.) > > > > > > > > > The resulting HTML has a

Re: [htmltmpl] Whitespace (linefeed) suppression?

2004-05-11 Thread Keith Jackson
During previous discussions on this the suggestion was used to use tidy in some way. Obviously in HTML the whitespace is fairly harmless, but for an email template or using H::T for something other then HTML the whitespace makes a big difference. So I throw my vote in for a flag to include or not

Re: [htmltmpl] Whitespace (linefeed) suppression?

2004-05-11 Thread Mark Fuller
From: "David Hodgkinson" <[EMAIL PROTECTED]> > There are mod_perl and apache filters for doing this. mod_gzip makes it > particularly > academic if you're prepared to trade a little CPU for a *lot* of > bandwidth. > > Stuff in the right place. I don't agree with the assertion that mod_perl is the

Re: [htmltmpl] Whitespace (linefeed) suppression?

2004-05-11 Thread David Hodgkinson
On 11 May 2004, at 20:47, Mark Fuller wrote: If I have something like this for readability in the template: == Error: (Forgot your password? Reset and email it to yourself.) The resulting HTML has a lot of newlin

[htmltmpl] Whitespace (linefeed) suppression?

2004-05-11 Thread Mark Fuller
If I have something like this for readability in the template: == Error: (Forgot your password? Reset and email it to yourself.) The resulting HTML has a lot of newlines. I'd like to ask if there should'nt be a