Re: HttpEntity cleanup - possible bugs?

2023-08-31 Thread Brent Putman
On 8/31/23 3:55 AM, Oleg Kalnichevski wrote: And that the EntityUtils#consume call in the CloseableHttpClient is really just there for the case of an improperly written handler that doesn't do that, and solely so that the connection can be reused? Correct. It is an extra safety net. Ok,

Re: org.apache.http.concurrent.FutureCallback: Exception handling

2023-08-31 Thread Oleg Kalnichevski
On Thu, 2023-08-31 at 11:32 +0200, Konrad Windszus wrote: > Hi Oleg, > Thanks for the input. > > > On 31. Aug 2023, at 11:17, Oleg Kalnichevski > > wrote: > > > > On Thu, 2023-08-31 at 10:08 +0200, Konrad Windszus wrote: > > > Hi, > > > I can pass a FutureCallback implementation to > > > HttpAsy

Re: org.apache.http.concurrent.FutureCallback: Exception handling

2023-08-31 Thread Konrad Windszus
Hi Oleg, Thanks for the input. > On 31. Aug 2023, at 11:17, Oleg Kalnichevski wrote: > > On Thu, 2023-08-31 at 10:08 +0200, Konrad Windszus wrote: >> Hi, >> I can pass a FutureCallback implementation to >> HttpAsyncClient.execute(…). >> However the javadoc at >> https://hc.apache.org/httpcompone

Re: org.apache.http.concurrent.FutureCallback: Exception handling

2023-08-31 Thread Oleg Kalnichevski
On Thu, 2023-08-31 at 10:08 +0200, Konrad Windszus wrote: > Hi, > I can pass a FutureCallback implementation to > HttpAsyncClient.execute(…). > However the javadoc at > https://hc.apache.org/httpcomponents-core-5.1.x/current/httpcore5/apidocs/org/apache/hc/core5/concurrent/FutureCallback.html >  is

org.apache.http.concurrent.FutureCallback: Exception handling

2023-08-31 Thread Konrad Windszus
Hi, I can pass a FutureCallback implementation to HttpAsyncClient.execute(…). However the javadoc at https://hc.apache.org/httpcomponents-core-5.1.x/current/httpcore5/apidocs/org/apache/hc/core5/concurrent/FutureCallback.html is very sparse. Particularly the following questions are not answered:

Re: HttpEntity cleanup - possible bugs?

2023-08-31 Thread Oleg Kalnichevski
On Wed, 2023-08-30 at 16:33 -0400, Brent Putman wrote: > > On 8/30/23 5:00 AM, Oleg Kalnichevski wrote: > > > > Again. It is called to make sure the entity has been fully consumed > > and > > the underlying connection the entity has been streaming its content > > from is fully re-usable. > > >