On Fri, 27 May 2022 18:40:32 GMT, XenoAmess wrote:
>> as title.
>
> XenoAmess has updated the pull request incrementally with one additional
> commit since the last revision:
>
> do it as naotoj said
`java.io` and `java.nio` look all right.
-
Marked as reviewed by bpb (Reviewer
On Wed, 11 May 2022 16:30:41 GMT, Roger Riggs wrote:
>> PR#8599 8244681: proposes to add compiler warnings for possible lossy
>> conversions
>> From the CSR:
>>
>> "If the type of the right-hand operand of a compound assignment is not
>> assignment compatible with the type of the variable, a c
On Tue, 10 May 2022 21:32:10 GMT, Roger Riggs wrote:
> PR#8599 8244681: proposes to add compiler warnings for possible lossy
> conversions
> From the CSR:
>
> "If the type of the right-hand operand of a compound assignment is not
> assignment compatible with the type of the variable, a cast is
On Fri, 15 Apr 2022 19:34:33 GMT, Pavel Rappo wrote:
> People rarely include JDK elements with package access in a javadoc run. That
> is why bugs in those elements' doc comments tend to remain unnoticed.
>
> There are many more bugs in the doc comments of the JDK elements with the
> package a
On Wed, 13 Apr 2022 20:36:48 GMT, Andrey Turbanov wrote:
> Found various typos of expected: `exepected`, `exept`, `epectedly`,
> `expeced`, `Unexpeted`, etc.
Expect the Unexpeted.
-
Marked as reviewed by bpb (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8231
On Wed, 30 Mar 2022 12:06:39 GMT, Claes Redestad wrote:
> A few integer divisions and multiplications can be replaced with test +
> addition, leading to a decent speed-up on java.time microbenchmarks such as
> `GetYearBench`. Numbers from my local x86 workstation, seeing similar
> speed-up on
On Tue, 22 Mar 2022 22:02:22 GMT, Naoto Sato wrote:
>> Fixing the out-of-date number of entries in
>> `Character.UnicodeBlock.NUM_ENTITIES` field. The regression test has been
>> renamed and now repurposed just to examine whether the `NUM_ENTITIES`
>> correctly has the `map.size()` value.
>
>
On Tue, 22 Mar 2022 18:44:09 GMT, Naoto Sato wrote:
> Fixing the out-of-date number of entries in
> `Character.UnicodeBlock.NUM_ENTITIES` field. The regression test has been
> renamed and now repurposed just to examine whether the `NUM_ENTITIES`
> correctly has the `map.size()` value.
Marked
On Thu, 9 Sep 2021 20:12:47 GMT, Andrey Turbanov
wrote:
> Redundant castings make code harder to read.
> Found them by IntelliJ IDEA.
> I tried to select only casts which are definitely safe to remove. Also didn't
> touch primitive types casts.
`java.io` change looks all right.
-
On Mon, 27 Sep 2021 20:21:43 GMT, Joe Darcy wrote:
> Follow-up changes to JDK-8231334. , augmentations to javac's Xlint:serial
> checking are out for review (#5709) and various client libraries would need
> some changes to pass under the expanded checks.
>
> The changes are to suppress warning
On Tue, 21 Sep 2021 21:45:40 GMT, Naoto Sato wrote:
> Simple doc fix.
Marked as reviewed by bpb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5620
On Thu, 2 Sep 2021 19:26:12 GMT, Naoto Sato wrote:
> Simple spec clarification. A CSR has also been drafted
> (https://bugs.openjdk.java.net/browse/JDK-8273296).
Marked as reviewed by bpb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5354
On Wed, 18 Aug 2021 20:59:20 GMT, Andrey Turbanov
wrote:
> remove redundant if
Looks fine.
-
Marked as reviewed by bpb (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5171
On Mon, 28 Jun 2021 18:37:34 GMT, Naoto Sato wrote:
>> Please review this small doc change to the system property. Accompanying CSR
>> has also been created.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Refined wording.
On Fri, 7 May 2021 22:46:08 GMT, Naoto Sato wrote:
> Please review this small fix to Windows system property init code. This is
> leftover from the support for `Console.charset()` method, where it lacked to
> initialize `sun.stdout/err.encoding` to `UTF-8` for the code page `cp65001`.
> The f
On Tue, 27 Apr 2021 21:34:02 GMT, Ian Graves wrote:
> 8266155: Convert java.base to use Stream.toList()
Looks all right.
-
Marked as reviewed by bpb (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3734
On Fri, 16 Apr 2021 16:08:53 GMT, Ian Graves wrote:
>> This fixes a bug where the formatting code for `%g` flags incorrectly tries
>> to round `BigDecimal` after determining whether it should be a decimal
>> numeric format or a scientific numeric format. The solution rounds before
>> determini
On Mon, 8 Mar 2021 18:48:30 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the `instanceof` pattern
> variable?
>
> Kind regards,
> Patrick
Looks good and builds clean
On Wed, 17 Feb 2021 20:18:56 GMT, Naoto Sato wrote:
>> Please review this simple doc fix. A CSR will be filed accordingly.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Made the additional text an @apiNote
Marked as review
On Wed, 17 Feb 2021 19:34:47 GMT, Naoto Sato wrote:
> Please review this simple doc fix. A CSR will be filed accordingly.
LGTM
-
Marked as reviewed by bpb (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2616
On Fri, 12 Feb 2021 02:50:35 GMT, Naoto Sato wrote:
> Please review this doc fix to j.l.Character, which now includes the table of
> the history of supported Unicode versions. A corresponding CSR will be filed
> accordingly.
Looks fine to me.
-
Marked as reviewed by bpb (Reviewer
On Mon, 8 Feb 2021 21:42:36 GMT, Naoto Sato wrote:
> Please review this simple test case fix. By sampling locales to test, it
> reduces the possibility of the time out.
Marked as reviewed by bpb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2465
On Tue, 15 Dec 2020 22:21:12 GMT, Brent Christian wrote:
>> This is part of an effort in the JDK to replace archaic/non-inclusive words
>> with more neutral terms (see JDK-8253315 for details).
>>
>> Here are the changes covering core libraries code and tests. Terms were
>> changed as follows
On Tue, 15 Dec 2020 01:46:08 GMT, Brent Christian wrote:
>> This is part of an effort in the JDK to replace archaic/non-inclusive words
>> with more neutral terms (see JDK-8253315 for details).
>>
>> Here are the changes covering core libraries code and tests. Terms were
>> changed as follows
On Thu, 19 Nov 2020 17:15:11 GMT, Naoto Sato wrote:
> Hi,
>
> Please review this doc only fix to the class description of `DecimalFormat`
> class. `localized minus sign` has never been (and should never be) used in
> the implicit negative subpattern. Actual implementation correctly uses ascii
Hi Naoto,
On the surface this looks fine to me although I am not familiar with this area.
Brian
> On Apr 25, 2019, at 3:09 PM, naoto.s...@oracle.com wrote:
>
> Hello,
>
> Please review the changes to the following issue:
>
> https://bugs.openjdk.java.net/browse/JDK-8222980
>
> The proposed c
+1
Brian
> On Dec 4, 2018, at 10:59 AM, Lance Andersen wrote:
>
> Looks OK Naoto
Hi Naoto,
+1
Brian
On Feb 21, 2018, at 1:13 PM, naoto.s...@oracle.com wrote:
> Please review the fix to the following issue:
>
> https://bugs.openjdk.java.net/browse/JDK-8198385
>
> The proposed changeset is located at:
>
> http://cr.openjdk.java.net/~naoto/8198385/webrev.00/
>
> The proper
Hi Nishit,
I suggest these changes in NumberFormat.java:
184:delete the line
186:s/{@code NumberFormat}/The default implementation/
187-188:s/By default, it uses/It uses/
With these changes I am fine with the patch and no need to send an updated
webrev unless you
A few minor comments:
L178-195: Is a list necessary here?
L186: I don’t think “Rounding: " is necessary.
L187: s/the numbers/numbers/
L188: s/uses/uses the/
L191: s/its/the/
Thanks,
Brian
On Aug 24, 2017, at 12:06 AM, Nishit Jain wrote:
> Webrev:http://cr.openjdk.java.net/~nishjain/818671
30 matches
Mail list logo
