Re: [i2c] [PATCH 2.6.26.5] rtc-ds1307 : SMBus compatibility

2008-10-15 Thread BARRE Sebastien
This patch change i2c access functions to SMBus access functions in order to use the ds1307 with SMBus adapter. Signed-off-by: Sebastien Barre [EMAIL PROTECTED] Acked-by: Jean Delvare [EMAIL PROTECTED] --- a/drivers/rtc/rtc-ds1307.c 2008-09-08 19:40:20.0 +0200 +++

Re: [i2c] [PATCH 2.6.26.5] rtc-ds1307 : SMBus compatibility

2008-10-14 Thread BARRE Sebastien
-Original Message- From: Alessandro Zummo [mailto:[EMAIL PROTECTED] Sent: Tuesday, October 14, 2008 3:22 PM To: BARRE Sebastien Cc: Jean Delvare; i2c@lm-sensors.org; frederic Rodo; David Brownell; Rodolfo Giometti Subject: Re: [i2c] [PATCH 2.6.26.5] rtc-ds1307 : SMBus compatibility

Re: [i2c] [PATCH 2.6.26.5] rtc-ds1307 : SMBus compatibility

2008-10-14 Thread Alessandro Zummo
On Tue, 14 Oct 2008 17:57:29 +0200 BARRE Sebastien [EMAIL PROTECTED] wrote: seems almost ok. please send your latest version to me and cc to the rtc-list for the final review. if it passed Jean's tests I'm confident it's quite ready for inclusion :) Patch is attached to preserve tabs.

Re: [i2c] [PATCH 2.6.26.5] rtc-ds1307 : SMBus compatibility

2008-10-14 Thread BARRE Sebastien
-Original Message- From: David Brownell [mailto:[EMAIL PROTECTED] Sent: Tuesday, October 14, 2008 5:47 PM To: Jean Delvare Cc: BARRE Sebastien; i2c@lm-sensors.org; Alessandro Zummo; frederic Rodo; Rodolfo Giometti Subject: Re: [i2c] [PATCH 2.6.26.5] rtc-ds1307 : SMBus compatibility

Re: [i2c] [PATCH 2.6.26.5] rtc-ds1307 : SMBus compatibility

2008-10-14 Thread David Brownell
On Tuesday 14 October 2008, Jean Delvare wrote: On Tue, 14 Oct 2008 15:15:10 +0200, BARRE Sebastien wrote: New version is attached for tests and comments Could I see it too? ___ i2c mailing list i2c@lm-sensors.org

Re: [i2c] [PATCH 2.6.26.5] rtc-ds1307 : SMBus compatibility

2008-10-13 Thread BARRE Sebastien
-Original Message- From: David Brownell [mailto:[EMAIL PROTECTED] ... At a quick glance, this looks like a sane conversion ... unlike the last one proposed, which I had to NAK since it broke driver functionality by trying to replace block transfers with non-equivalent byte-at-a-time

Re: [i2c] [PATCH 2.6.26.5] rtc-ds1307 : SMBus compatibility

2008-10-13 Thread Jean Delvare
Hi Sebastien, On Fri, 10 Oct 2008 15:46:11 +0200, BARRE Sebastien wrote: Thanks for your advices. Fixed patch is in attachement to avoid tabs replacement. Other comments are welcome. Note: you need to include a comment describing what your patch does, as well as your Signed-off-by line.

Re: [i2c] [PATCH 2.6.26.5] rtc-ds1307 : SMBus compatibility

2008-10-11 Thread David Brownell
On Friday 10 October 2008, Jean Delvare wrote: Unfortunately your e-mail client replaced all tabs with spaces in the patch, so I can't apply it, which makes reviewing it much harder. Here's a first pass anyway, but please fix that and resend the patch in such a format that I (and other

Re: [i2c] [PATCH 2.6.26.5] rtc-ds1307 : SMBus compatibility

2008-10-10 Thread Jean Delvare
Bonjour Sebastien, On Thu, 9 Oct 2008 08:59:17 +0200, BARRE Sebastien wrote: Hi, This patch change all i2c access functions to SMBus access functions in order to use the ds1307 on SMBus. I expect that using SMBus access functions is correct for all boards with i2C or SMBus adapter. Is it

Re: [i2c] [PATCH 2.6.26.5] rtc-ds1307 : SMBus compatibility

2008-10-10 Thread BARRE Sebastien
Thanks for your advices. Fixed patch is in attachement to avoid tabs replacement. Other comments are welcome. -- Sébastien Barré Bureau d'étude - Développement SDEL Contrôle Commande D2A - Rue Nungesser et Coli 44860 Saint Aignan de Grand Lieu FRANCE Tél : +33(0)2 40 84 50 88 Fax : +33(0)2 40 84

[i2c] [PATCH 2.6.26.5] rtc-ds1307 : SMBus compatibility

2008-10-09 Thread BARRE Sebastien
Hi, This patch change all i2c access functions to SMBus access functions in order to use the ds1307 on SMBus. I expect that using SMBus access functions is correct for all boards with i2C or SMBus adapter. Is it correct ? I have tested it on my Geode LX board with a ds1307 device. Please CC