Re: [i2c] [PATCH] i2c driver for Maxim max9485 audio clock generator chip

2008-10-22 Thread Jean Delvare
On Tue, 21 Oct 2008 19:57:09 -0400, Jon Smirl wrote: On Tue, Oct 21, 2008 at 4:36 AM, Jean Delvare [EMAIL PROTECTED] wrote: Honestly I don't see any value in this driver. There's nothing you can do with it that you couldn't already do without it. I need a driver so that my device tree will

Re: [i2c] [PATCH] i2c driver for Maxim max9485 audio clock generator chip

2008-10-22 Thread Jon Smirl
What you want me to do? Put in a bare .h file for the part? Bare .h files are much harder to find and reuse. It is also going to force anyone reusing this part into reading the datasheet and determining how the part works. On Wed, Oct 22, 2008 at 2:38 AM, Jean Delvare [EMAIL PROTECTED] wrote:

Re: [i2c] [PATCH] i2c driver for Maxim max9485 audio clock generator chip

2008-10-21 Thread Jean Delvare
Hi Jon, On Mon, 20 Oct 2008 23:02:05 -0400, Jon Smirl wrote: Signed-off-by: Jon Smirl [EMAIL PROTECTED] --- drivers/i2c/chips/Kconfig |9 drivers/i2c/chips/Makefile |1 drivers/i2c/chips/max9485.c | 106 +++

Re: [i2c] [PATCH] i2c driver for Maxim max9485 audio clock generator chip

2008-10-21 Thread Ben Dooks
On Mon, Oct 20, 2008 at 11:02:05PM -0400, Jon Smirl wrote: Signed-off-by: Jon Smirl [EMAIL PROTECTED] --- drivers/i2c/chips/Kconfig |9 drivers/i2c/chips/Makefile |1 drivers/i2c/chips/max9485.c | 106 +++

Re: [i2c] [PATCH] i2c driver for Maxim max9485 audio clock generator chip

2008-10-21 Thread Jon Smirl
On Tue, Oct 21, 2008 at 4:36 AM, Jean Delvare [EMAIL PROTECTED] wrote: Honestly I don't see any value in this driver. There's nothing you can do with it that you couldn't already do without it. I need a driver so that my device tree will bind and tell me the i2c address of the device. We may