Re: [ibm-acpi-devel] [PATCH 12/16] INPUT: add a new EV_SW SW_RADIO event, for radio switches on laptops

2007-07-05 Thread Henrique de Moraes Holschuh
On Thu, 05 Jul 2007, Dmitry Torokhov wrote: > On Thursday 05 July 2007 22:42, Henrique de Moraes Holschuh wrote: > > Many laptops have rf-kill physical switches that are not keys, but slider > > or rocker switches. Often (like in all ThinkPads with a radio kill slider > > switch), they have both a

Re: [ibm-acpi-devel] Bug on ibm-acpi and hal regarding brightness keys

2007-07-05 Thread Henrique de Moraes Holschuh
On Thu, 05 Jul 2007, Chris Hanson wrote: > I'm using 2.6.21.5 with the whoopie patches (which include an older > version of thinkpad-acpi 0.14). On this system the brightness keys work > fine, as does tpb's on-screen display. Do you need me to try the > current version of thinkpad-acpi, or doe

Re: [ibm-acpi-devel] Bug on ibm-acpi and hal regarding brightness keys

2007-07-05 Thread Chris Hanson
Henrique de Moraes Holschuh wrote: >> The brightness controls _are_ implemented in SSDT1. Maybe they even >> work. How do I test that? > > The ACPI video module is supposed to know how to talk to them... and it > shouldn't be too broken since 2.6.21. I'm using 2.6.21.5 with the whoopie patche

Re: [ibm-acpi-devel] [PATCH 12/16] INPUT: add a new EV_SW SW_RADIO event, for radio switches on laptops

2007-07-05 Thread Dmitry Torokhov
On Thursday 05 July 2007 22:42, Henrique de Moraes Holschuh wrote: > Many laptops have rf-kill physical switches that are not keys, but slider > or rocker switches. Often (like in all ThinkPads with a radio kill slider > switch), they have both a slider/rocker switch and a hot key. Linus just mer

Re: [ibm-acpi-devel] Bug on ibm-acpi and hal regarding brightness keys

2007-07-05 Thread Henrique de Moraes Holschuh
On Thu, 05 Jul 2007, Chris Hanson wrote: > Henrique de Moraes Holschuh wrote: > > On Thu, 05 Jul 2007, Chris Hanson wrote: > >> Henrique de Moraes Holschuh wrote: > >>> It is also a good idea to read the ACPI specification 3.0b, and check what > >>> is the ACPI standard way of dealing with display

Re: [ibm-acpi-devel] Bug on ibm-acpi and hal regarding brightness keys

2007-07-05 Thread Chris Hanson
Henrique de Moraes Holschuh wrote: > On Thu, 05 Jul 2007, Chris Hanson wrote: >> Henrique de Moraes Holschuh wrote: >>> It is also a good idea to read the ACPI specification 3.0b, and check what >>> is the ACPI standard way of dealing with display brightness. If Lenovo is >>> supporting that one, i

Re: [ibm-acpi-devel] Bug on ibm-acpi and hal regarding brightness keys

2007-07-05 Thread Henrique de Moraes Holschuh
On Thu, 05 Jul 2007, Chris Hanson wrote: > Henrique de Moraes Holschuh wrote: > > It is also a good idea to read the ACPI specification 3.0b, and check what > > is the ACPI standard way of dealing with display brightness. If Lenovo is > > supporting that one, it is best to just switch to it on Leno

[ibm-acpi-devel] [PATCH 06/16] ACPI: thinkpad-acpi: export to sysfs the state of the radio slider switch

2007-07-05 Thread Henrique de Moraes Holschuh
Some ThinkPad models, notably the T60 and X60, have a slider switch to enable and disable the radios. The switch has the capability of force-disabling the radios in hardware on most models, and it is supposed to affect all radios (WLAN, WWAN, BlueTooth). Export the switch state as a sysfs attribu

[ibm-acpi-devel] [PATCH 14/16] ACPI: thinkpad-acpi: export EV_SW SW_RADIO events

2007-07-05 Thread Henrique de Moraes Holschuh
The expected user case for the radio slider switch on a ThinkPad includes interfacing to applications, so that the user gets an offer to find and associate with a wireless network when the switch is changed from disabled to enabled (ThinkVantage suite). Export the information about the switch stat

[ibm-acpi-devel] [PATCH 16/16] ACPI: thinkpad-acpi: rename pci HID constant

2007-07-05 Thread Henrique de Moraes Holschuh
Rename an internal driver constant, on request by Len Brown. Also, document exactly what it is for. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.c |7 +-- drivers/misc/thinkpad_acpi.h |1 - 2 files changed, 5 insertions(+), 3 deletions

[ibm-acpi-devel] [PATCH 11/16] ACPI: thinkpad-acpi: make the input event mode the default

2007-07-05 Thread Henrique de Moraes Holschuh
Make the input layer the default way to deal with thinkpad-acpi hot keys, but add a kernel config option to retain the old way of doing things. This means we map a lot more keys to useful stuff by default, and also that we enable hot key handling by default on driver load (like Windows does). The

[ibm-acpi-devel] [PATCH 12/16] INPUT: add a new EV_SW SW_RADIO event, for radio switches on laptops

2007-07-05 Thread Henrique de Moraes Holschuh
Many laptops have rf-kill physical switches that are not keys, but slider or rocker switches. Often (like in all ThinkPads with a radio kill slider switch), they have both a slider/rocker switch and a hot key. Trying to kludge a real switch to act like a key is not a very smart thing to do if you

[ibm-acpi-devel] [PATCH 15/16] ACPI: thinkpad-acpi: checkpoint sysfs interface version due to input layer

2007-07-05 Thread Henrique de Moraes Holschuh
The change in the way hotkey events are handled by default, and the use of the input layer for the hotkey events are important enough features to warrant increasing the major field of the sysfs interface version. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- Documentation/thi

[ibm-acpi-devel] [PATCH 10/16] ACPI: thinkpad-acpi: add input device support to hotkey subdriver

2007-07-05 Thread Henrique de Moraes Holschuh
Add input device support to the hotkey subdriver. Hot keys that have a valid keycode mapping are reported through the input layer if the input device is open. Otherwise, they will be reported as ACPI events, as they were before. Scan codes are reported (using EV_MSC MSC_SCAN events) along with E

[ibm-acpi-devel] [PATCH 02/16] ACPI: thinkpad-acpi: remove all uneeded initializers

2007-07-05 Thread Henrique de Moraes Holschuh
Remove all initializers to NULL or zero. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/misc/thinkpad_acpi.c b/drivers/misc/thinkpad_acpi.c index 22a5f2

[ibm-acpi-devel] [PATCH 08/16] ACPI: thinkpad-acpi: update CMOS commands documentation

2007-07-05 Thread Henrique de Moraes Holschuh
The CMOS set of commands is often just used to keep the CMOS NVRAM in sync with whatever the ACPI BIOS has been doing in modern ThinkPads. In older ThinkPads, it actually carried out real actions. Document this. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- Documentation/th

[ibm-acpi-devel] [PATCH 13/16] ACPI: thinkpad-acpi: add power-management handler capability

2007-07-05 Thread Henrique de Moraes Holschuh
Some subdrivers could benefit from resume handling, so add the infrastructure for simple resume handling. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.c | 16 drivers/misc/thinkpad_acpi.h |1 + 2 files changed, 17 insertions(

[ibm-acpi-devel] [PATCH 07/16] ACPI: thinkpad-acpi: checkpoint sysfs interface version due to hotkey

2007-07-05 Thread Henrique de Moraes Holschuh
The change in the size of the hotkey mask, the hability to report the keys that use the higher bits, and the addition of the hotkey_radio_sw attribute are important enough features to warrant increasing the minor field of the sysfs interface version. Also, document a bit better how and when the th

[ibm-acpi-devel] [PATCH 09/16] ACPI: thinkpad-acpi: register input device

2007-07-05 Thread Henrique de Moraes Holschuh
Register an input device to send input events to userspace. This patch is based on a patch by Richard Hughes <[EMAIL PROTECTED]>. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> Cc: Richard Hughes <[EMAIL PROTECTED]> Cc: Dmitry Torokhov <[EMAIL PROTECTED]> --- drivers/misc/thinkpa

[ibm-acpi-devel] [PATCH 01/16] ACPI: thinkpad-acpi: add DMI-based modalias

2007-07-05 Thread Henrique de Moraes Holschuh
Add DMI-based aliases to allow module autoloading on select thinkpads. The aliases will do nothing unless the dmi-based-module-autoloading.patch patch from Lennart Poettering <[EMAIL PROTECTED]> is applied. Lennart's patch has been accepted by greghk and will be merged eventually. Signed-off-by:

[ibm-acpi-devel] [PATCH 04/16] ACPI: thinkpad-acpi: enable more hotkeys

2007-07-05 Thread Henrique de Moraes Holschuh
Revise ACPI HKEY functionality to better interface with the firmware, and enable up to 32 regular hotkeys, instead of just 16 of them. Ouch. This takes care of most keys one used to have to do CMOS NVRAM polling on, and should drop the need for tpb, thinkpad-keys, and other such 5Hz NVRAM polling

[ibm-acpi-devel] [PATCH 03/16] ACPI: thinkpad-acpi: update information on T43 thermal sensor 0xc1

2007-07-05 Thread Henrique de Moraes Holschuh
Update the documentation with some extra data on the T43 thermal sensor @0xc1, thanks to Alexey Fisher. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- Documentation/thinkpad-acpi.txt |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/Documentation/think

[ibm-acpi-devel] [GIT PULL] thinkpad-acpi initial queue for 2.6.23

2007-07-05 Thread Henrique de Moraes Holschuh
Len, Please pull from: git://repo.or.cz/linux-2.6/linux-acpi-2.6/ibm-acpi-2.6.git for-upstream/acpi-test

[ibm-acpi-devel] [PATCH 05/16] ACPI: thinkpad-acpi: export hotkey maximum masks

2007-07-05 Thread Henrique de Moraes Holschuh
The firmware knows how many hot keys it supports, so export this information in a sysfs attribute. And the driver knows which keys are always handled by the firmware in all known ThinkPad models too, so export this information as well in a sysfs attribute. Unless you know which events need to be

Re: [ibm-acpi-devel] Bug on ibm-acpi and hal regarding brightness keys

2007-07-05 Thread Chris Hanson
Henrique de Moraes Holschuh wrote: > It is also a good idea to read the ACPI specification 3.0b, and check what > is the ACPI standard way of dealing with display brightness. If Lenovo is > supporting that one, it is best to just switch to it on Lenovo thinkpads. According to the spec, the standar

Re: [ibm-acpi-devel] Bug on ibm-acpi and hal regarding brightness keys

2007-07-05 Thread Henrique de Moraes Holschuh
On Thu, 05 Jul 2007, Antti P Miettinen wrote: > > > Please check if position 0x5E in the output of > > > hexdump -C /dev/nvram > > > has the brightness level (0..7) in the lowest three bits. > > > > Yeap, it's there, and updated. > > Same for me. More details at > http://permalink.gmane.org/gmane

Re: [ibm-acpi-devel] thinkpad-acpi release 0.14-20070701 available in sf.net

2007-07-05 Thread Henrique de Moraes Holschuh
On Thu, 05 Jul 2007, Richard Hughes wrote: > On Wed, 2007-07-04 at 14:35 +0200, Timo Hoenig wrote: > > Handling brightness events for ThinkPads is another story. The events > > will reach user space but user space is not ought to do anything as they > > are handled in hardware (c.f. [1]). But thi

Re: [ibm-acpi-devel] Bug on ibm-acpi and hal regarding brightness keys

2007-07-05 Thread Antti P Miettinen
> > Please check if position 0x5E in the output of > > hexdump -C /dev/nvram > > has the brightness level (0..7) in the lowest three bits. > > Yeap, it's there, and updated. Same for me. More details at http://permalink.gmane.org/gmane.linux.acpi.ibm-acpi.devel/383 -- http://www.iki.fi/~ananaza

Re: [ibm-acpi-devel] Bug on ibm-acpi and hal regarding brightness keys

2007-07-05 Thread Alfredo Matos
On Thu, 2007-07-05 at 10:37 -0300, Henrique de Moraes Holschuh wrote: > On Thu, 05 Jul 2007, Alfredo Matos wrote: > > 4 brigs up the brightness, while 5 lowers. It works, though no change > > detected in the 0x31 register. > > That's the old CMOS API for changing brightness. So, that means we *ca

Re: [ibm-acpi-devel] Bug on ibm-acpi and hal regarding brightness keys

2007-07-05 Thread Henrique de Moraes Holschuh
On Thu, 05 Jul 2007, Alfredo Matos wrote: > 4 brigs up the brightness, while 5 lowers. It works, though no change > detected in the 0x31 register. That's the old CMOS API for changing brightness. So, that means we *can* support it in these machines, and I won't even bitch at Lenovo for switching

Re: [ibm-acpi-devel] Bug on ibm-acpi and hal regarding brightness keys

2007-07-05 Thread Alfredo Matos
On Wed, 2007-07-04 at 23:26 -0300, Henrique de Moraes Holschuh wrote: > On Wed, 04 Jul 2007, Alfredo Matos wrote: > > > What does "echo 0x31 N" > /proc/acpi/ibm/ecdump (where N is a number from > > > 0 > > > to 7) do in your thinkpad? Does a cat /proc/acpi/ibm/ecdump show that the > > > value chan

Re: [ibm-acpi-devel] Bug on ibm-acpi and hal regarding brightness keys

2007-07-05 Thread Henrique de Moraes Holschuh
On Thu, 05 Jul 2007, Richard Hughes wrote: > On Wed, 2007-07-04 at 23:26 -0300, Henrique de Moraes Holschuh wrote: > > If it does nothing, that means the end of thinkpad-acpi brightness > > support for these thinkpads. Your only hope will be that the standard > > ACPI brightness interface works, o

Re: [ibm-acpi-devel] Bug on ibm-acpi and hal regarding brightness keys

2007-07-05 Thread Richard Hughes
On Wed, 2007-07-04 at 23:26 -0300, Henrique de Moraes Holschuh wrote: > If it does nothing, that means the end of thinkpad-acpi brightness > support for these thinkpads. Your only hope will be that the standard > ACPI brightness interface works, or that someone reverse engineers > whichever new in

Re: [ibm-acpi-devel] thinkpad-acpi release 0.14-20070701 available in sf.net

2007-07-05 Thread Richard Hughes
On Wed, 2007-07-04 at 14:35 +0200, Timo Hoenig wrote: > Handling brightness events for ThinkPads is another story. The events > will reach user space but user space is not ought to do anything as they > are handled in hardware (c.f. [1]). But thinkpad-keys did not do > anything about this anyway.

Re: [ibm-acpi-devel] Bug on ibm-acpi and hal regarding brightness keys

2007-07-05 Thread Henrique de Moraes Holschuh
On Wed, 04 Jul 2007, Alfredo Matos wrote: > > What does "echo 0x31 N" > /proc/acpi/ibm/ecdump (where N is a number from 0 > > to 7) do in your thinkpad? Does a cat /proc/acpi/ibm/ecdump show that the > > value changed as expected? > > Uhmm, it updates the value, but the brightness does not change