Re: [ibm-acpi-devel] [PATCH 6/7] ACPI: thinkpad-acpi: dequeue all pending hot key events at once

2007-09-20 Thread Len Brown
On Thursday 20 September 2007 09:50, Henrique de Moraes Holschuh wrote: > Receive all pending hot key events at once from a single notification, and > don't complain if the queue is empty. > > Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> > --- > drivers/misc/thinkpad_acpi.c |

[ibm-acpi-devel] [PATCH 6/7] ACPI: thinkpad-acpi: dequeue all pending hot key events at once

2007-09-20 Thread Henrique de Moraes Holschuh
Receive all pending hot key events at once from a single notification, and don't complain if the queue is empty. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.c | 52 - 1 files changed, 35 insertions(+), 17

[ibm-acpi-devel] [PATCH 3/7] ACPI: thinkpad-acpi: add mutex-based locking to input device event send path

2007-09-20 Thread Henrique de Moraes Holschuh
Protect the input device event sending path with a mutex, since hot key input events are not atomic and require an cohesive event block to be sent together. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.c | 10 ++ 1 files changed, 10 inser

[ibm-acpi-devel] [PATCH 2/7] ACPI: thinkpad-acpi: issue EV_SYNC after EV_SWITCH

2007-09-20 Thread Henrique de Moraes Holschuh
We were missing a input_sync on the radio switch event report path. Add it. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/misc/thinkpad_acpi.c b/drivers/misc/think

[ibm-acpi-devel] [PATCH 5/7] ACPI: thinkpad-acpi: check version of hot key firmware

2007-09-20 Thread Henrique de Moraes Holschuh
Check the HKEY firmware version (HKEY.MHKV handler), and refuse to load if it is unknown. Use this instead of the presence of HKEY.DHKV to detect hot key mask capability. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.c | 28 ++

[ibm-acpi-devel] [PATCH 4/7] ACPI: thinkpad-acpi: keep track of module state

2007-09-20 Thread Henrique de Moraes Holschuh
Keep track of module state (init, running, exit). This makes it trivially easy to avoid running any interrupt handlers, threads, or any other async activity before we are ready, or when we want to go away. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_a

[ibm-acpi-devel] [PATCH 7/7] ACPI: thinkpad-acpi: fix regression on HKEY LID event handling

2007-09-20 Thread Henrique de Moraes Holschuh
We were letting ThinkPad-specific LID events through to userspace again, instead of dropping them. Fix it. We don't want to give userspace the option of not using generic LID handling. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.c |9 +++

[ibm-acpi-devel] [PATCH 1/7] ACPI: thinkpad-acpi: make room for more features in tp_features bitfield

2007-09-20 Thread Henrique de Moraes Holschuh
Increase tp_features to 32 bits. It is too close to running out of room. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.h | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/misc/thinkpad_a

[ibm-acpi-devel] [GIT PATCH] thinkpad-acpi changes for the merge window (part 1)

2007-09-20 Thread Henrique de Moraes Holschuh
Len, Here is the first batch of changes for thinkpad-acpi, targetted at the next merge window. They're mostly non-critical fixes. Please merge this batch to acpi-test. I do have some new work to submit (NVRAM polling), but I am waiting for some testing feedback before I consider pushing it for