Re: [ibm-acpi-devel] [PATCH 6/7] ACPI: thinkpad-acpi: dequeue all pending hot key events at once

2007-09-23 Thread Len Brown
On Friday 21 September 2007 09:53, Henrique de Moraes Holschuh wrote: > On Thu, 20 Sep 2007, Len Brown wrote: > > On Thursday 20 September 2007 09:50, Henrique de Moraes Holschuh wrote: > > > Receive all pending hot key events at once from a single notification, and > > > don't complain if the queu

Re: [ibm-acpi-devel] [GIT PATCH v3.1] thinkpad-acpi changes for the merge window (part 1)

2007-09-23 Thread Len Brown
Okay, previous series replaced with this one. thanks, -Len On Sunday 23 September 2007 10:38, Henrique de Moraes Holschuh wrote: > Len, > > Here is the third version (fixed) of the first batch of changes for > thinkpad-acpi, targetted at the next merge window. They're mostly > non-critical fi

Re: [ibm-acpi-devel] thinkpad-acpi release 0.16-20070922 uploaded to ibm-acpi.sf.net

2007-09-23 Thread Michael Olbrich
Hi, I hope this mail actually arrives at ibm-acpi-devel... On Sun, Sep 23, 2007 at 03:02:48PM -0300, Henrique de Moraes Holschuh wrote: > On Sun, 23 Sep 2007, Michael Olbrich wrote: > > I get new events for the thinklight and the mixer (up/down/mute). > > Yeah, you can get them without the nvram

Re: [ibm-acpi-devel] thinkpad-acpi release 0.16-20070922 uploaded to ibm-acpi.sf.net

2007-09-23 Thread Henrique de Moraes Holschuh
On Sun, 23 Sep 2007, Michael Olbrich wrote: > v2.6.23-rc7+thinkpad-acpi-20070922 does not compile so I used > v2.6.22.7+thinkpad-acpi-20070922 instead: Yeah, I noticed. It is fixed in the git tree, I will push a new release tomorrow. > Just in tim then, right? This is a Z61m btw. with the latest

[ibm-acpi-devel] [PATCH 9/9] ACPI: thinkpad-acpi: duplicate driver attributes to new hwmon pdrv

2007-09-23 Thread Henrique de Moraes Holschuh
Thinkpad-acpi has some driver attributes (debug level, sysfs interface version, etc) that also belong to the new hwmon driver. Duplicate them there. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.c |8 +++- drivers/misc/thinkpad_acpi.h |

[ibm-acpi-devel] [GIT PATCH v3.1] thinkpad-acpi changes for the merge window (part 1)

2007-09-23 Thread Henrique de Moraes Holschuh
Len, Here is the third version (fixed) of the first batch of changes for thinkpad-acpi, targetted at the next merge window. They're mostly non-critical fixes. I have found a stupid bug on v2 and v2.1 of patch 6, and fixed it (hopefully correctly, this time). I am *really* sorry about that. I h

[ibm-acpi-devel] [PATCH 7/9] ACPI: thinkpad-acpi: fix regression on HKEY LID event handling

2007-09-23 Thread Henrique de Moraes Holschuh
We were letting ThinkPad-specific LID events through to userspace again, instead of dropping them. Fix it. We don't want to give userspace the option of not using generic LID handling. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.c |9 +++

[ibm-acpi-devel] [PATCH 8/9] ACPI: thinkpad-acpi: use a separate platform device for hwmon and name it

2007-09-23 Thread Henrique de Moraes Holschuh
Use a separate platform device to attach hwmon attributes and class, and add a name attribute of "thinkpad_hwmon" to it. To do it properly, we also register a new platform driver ("thinkpad_hwmon"). This makes thinkpad-acpi compatible with libsensors4 from lm-sensors, and the platform driver and

[ibm-acpi-devel] [PATCH 3/9] ACPI: thinkpad-acpi: add mutex-based locking to input device event send path

2007-09-23 Thread Henrique de Moraes Holschuh
Protect the input device event sending path with a mutex, since hot key input events are not atomic and require an cohesive event block to be sent together. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.c | 10 ++ 1 files changed, 10 inser

[ibm-acpi-devel] [PATCH 6/9] ACPI: thinkpad-acpi: dequeue all pending hot key events at once (v2.2)

2007-09-23 Thread Henrique de Moraes Holschuh
Receive all pending HKEY events at once from a single notification, and don't complain if the queue is empty. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.c | 51 -- 1 files changed, 34 insertions(+), 17 de

[ibm-acpi-devel] [PATCH 2/9] ACPI: thinkpad-acpi: issue EV_SYNC after EV_SWITCH

2007-09-23 Thread Henrique de Moraes Holschuh
We were missing a input_sync on the radio switch event report path. Add it. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/misc/thinkpad_acpi.c b/drivers/misc/think

[ibm-acpi-devel] [PATCH 4/9] ACPI: thinkpad-acpi: keep track of module state

2007-09-23 Thread Henrique de Moraes Holschuh
Keep track of module state (init, running, exit). This makes it trivially easy to avoid running any interrupt handlers, threads, or any other async activity before we are ready, or when we want to go away. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_a

[ibm-acpi-devel] [PATCH 5/9] ACPI: thinkpad-acpi: check version of hot key firmware

2007-09-23 Thread Henrique de Moraes Holschuh
Check the HKEY firmware version (HKEY.MHKV handler), and refuse to load if it is unknown. Use this instead of the presence of HKEY.DHKV to detect hot key mask capability. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.c | 28 ++

[ibm-acpi-devel] [PATCH 1/9] ACPI: thinkpad-acpi: make room for more features in tp_features bitfield

2007-09-23 Thread Henrique de Moraes Holschuh
Increase tp_features to 32 bits. It is too close to running out of room. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.h | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/misc/thinkpad_a

Re: [ibm-acpi-devel] [GIT PATCH v3] thinkpad-acpi changes for the merge window (part 1)

2007-09-23 Thread Henrique de Moraes Holschuh
On Sun, 23 Sep 2007, Henrique de Moraes Holschuh wrote: > I have found a stupid bug on v2 of patch 6, and fixed it. Sorry about Today must not be my day. There is still an error in patch 6, I will send the batch again in a few moments. I am *really* sorry about this. -- "One disk to rule th

[ibm-acpi-devel] [PATCH 5/9] ACPI: thinkpad-acpi: check version of hot key firmware

2007-09-23 Thread Henrique de Moraes Holschuh
Check the HKEY firmware version (HKEY.MHKV handler), and refuse to load if it is unknown. Use this instead of the presence of HKEY.DHKV to detect hot key mask capability. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.c | 28 ++

[ibm-acpi-devel] [PATCH 4/9] ACPI: thinkpad-acpi: keep track of module state

2007-09-23 Thread Henrique de Moraes Holschuh
Keep track of module state (init, running, exit). This makes it trivially easy to avoid running any interrupt handlers, threads, or any other async activity before we are ready, or when we want to go away. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_a

[ibm-acpi-devel] [PATCH 6/9] ACPI: thinkpad-acpi: dequeue all pending hot key events at once (v2.1)

2007-09-23 Thread Henrique de Moraes Holschuh
Receive all pending HKEY events at once from a single notification, and don't complain if the queue is empty. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.c | 51 -- 1 files changed, 34 insertions(+), 17 de

[ibm-acpi-devel] [PATCH 1/9] ACPI: thinkpad-acpi: make room for more features in tp_features bitfield

2007-09-23 Thread Henrique de Moraes Holschuh
Increase tp_features to 32 bits. It is too close to running out of room. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.h | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/misc/thinkpad_a

[ibm-acpi-devel] [PATCH 7/9] ACPI: thinkpad-acpi: fix regression on HKEY LID event handling

2007-09-23 Thread Henrique de Moraes Holschuh
We were letting ThinkPad-specific LID events through to userspace again, instead of dropping them. Fix it. We don't want to give userspace the option of not using generic LID handling. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.c |9 +++

[ibm-acpi-devel] [PATCH 9/9] ACPI: thinkpad-acpi: duplicate driver attributes to new hwmon pdrv

2007-09-23 Thread Henrique de Moraes Holschuh
Thinkpad-acpi has some driver attributes (debug level, sysfs interface version, etc) that also belong to the new hwmon driver. Duplicate them there. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.c |8 +++- drivers/misc/thinkpad_acpi.h |

[ibm-acpi-devel] [PATCH 8/9] ACPI: thinkpad-acpi: use a separate platform device for hwmon and name it

2007-09-23 Thread Henrique de Moraes Holschuh
Use a separate platform device to attach hwmon attributes and class, and add a name attribute of "thinkpad_hwmon" to it. To do it properly, we also register a new platform driver ("thinkpad_hwmon"). This makes thinkpad-acpi compatible with libsensors4 from lm-sensors, and the platform driver and

[ibm-acpi-devel] [PATCH 2/9] ACPI: thinkpad-acpi: issue EV_SYNC after EV_SWITCH

2007-09-23 Thread Henrique de Moraes Holschuh
We were missing a input_sync on the radio switch event report path. Add it. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/misc/thinkpad_acpi.c b/drivers/misc/think

[ibm-acpi-devel] [PATCH 3/9] ACPI: thinkpad-acpi: add mutex-based locking to input device event send path

2007-09-23 Thread Henrique de Moraes Holschuh
Protect the input device event sending path with a mutex, since hot key input events are not atomic and require an cohesive event block to be sent together. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.c | 10 ++ 1 files changed, 10 inser

[ibm-acpi-devel] [GIT PATCH v3] thinkpad-acpi changes for the merge window (part 1)

2007-09-23 Thread Henrique de Moraes Holschuh
Len, Here is the third version of the first batch of changes for thinkpad-acpi, targetted at the next merge window. They're mostly non-critical fixes. I have found a stupid bug on v2 of patch 6, and fixed it. Sorry about that. I have also added two new patches, that were going to be sent as p

[ibm-acpi-devel] thinkpad-acpi development switching to 2.6.22

2007-09-23 Thread Henrique de Moraes Holschuh
I have switched the main development of thinkpad-acpi to 2.6.22. This means the git branches are now based on 2.6.22 or one of the 2.6.22.y stable versions. It also means that releases for 2.6.20 and 2.6.21 are simply backports, and that I depend on reports to know if they are working right. Pre