Re: [ibm-acpi-devel] [ltp] Re: thinkpad-acpi release 0.17-20071002 uploaded to ibm-acpi.sf.net

2007-10-04 Thread Chris Hanson
Henrique de Moraes Holschuh wrote: > On Thu, 04 Oct 2007, Chris Hanson wrote: >> What doesn't appear here is code to discard the input buffer when EINVAL >> is returned. I don't understand where that is supposed to happen, since >> it would normally be handled by returning the number of characters

Re: [ibm-acpi-devel] [ltp] Re: thinkpad-acpi release 0.17-20071002 uploaded to ibm-acpi.sf.net

2007-10-04 Thread Henrique de Moraes Holschuh
On Thu, 04 Oct 2007, Chris Hanson wrote: > What doesn't appear here is code to discard the input buffer when EINVAL > is returned. I don't understand where that is supposed to happen, since > it would normally be handled by returning the number of characters read If you return any valid error (li

Re: [ibm-acpi-devel] [ltp] Re: thinkpad-acpi release 0.17-20071002 uploaded to ibm-acpi.sf.net

2007-10-04 Thread Chris Hanson
Henrique de Moraes Holschuh wrote: > Here's the offending code, from backlight.c: > > [...] Yes, I've read it pretty carefully. That's what I marked up with printk's to find the problem. I agree with your analysis of the fragility of the parsing, but that's not the problem I'm seeing. (As I thi

Re: [ibm-acpi-devel] events for lid stopped working

2007-10-04 Thread Henrique de Moraes Holschuh
On Thu, 04 Oct 2007, Peter Jordan wrote: > Henrique de Moraes Holschuh, 10/04/07 17:37: > > Could you open a wishlist bug on bugzilla.kernel.org against ACPI, asking > > them for a way to get the relevant information in button events, instead of > > an useless event count? Maybe if they added a gu

Re: [ibm-acpi-devel] events for lid stopped working

2007-10-04 Thread Peter Jordan
Henrique de Moraes Holschuh, 10/04/07 17:37: > > Could you open a wishlist bug on bugzilla.kernel.org against ACPI, asking > them for a way to get the relevant information in button events, instead of > an useless event count? Maybe if they added a guarantee that all odd events > are "close" and

Re: [ibm-acpi-devel] [ltp] thinkpad-acpi release 0.17-20071002 uploaded to ibm-acpi.sf.net

2007-10-04 Thread Henrique de Moraes Holschuh
On Thu, 04 Oct 2007, Jan Gutter wrote: > On Thu, 2007-10-04 at 12:49 -0300, Henrique de Moraes Holschuh wrote: > > On Thu, 04 Oct 2007, Jan Gutter wrote: > > > On Thu, 2007-10-04 at 09:56 -0300, Henrique de Moraes Holschuh wrote: > > > > On Thu, 04 Oct 2007, Jan Gutter wrote: > > > > > On Wed, 2007

Re: [ibm-acpi-devel] [ltp] Re: thinkpad-acpi release 0.17-20071002 uploaded to ibm-acpi.sf.net

2007-10-04 Thread Henrique de Moraes Holschuh
On Thu, 04 Oct 2007, Henrique de Moraes Holschuh wrote: > On Thu, 04 Oct 2007, Chris Hanson wrote: > > OK, I have a lot more information now. > > > > Contrary to what I previously (thought? I) saw, the procfs interface now > > works OK after writing a bad value to sysfs. So this is a sysfs-only >

Re: [ibm-acpi-devel] [ltp] thinkpad-acpi release 0.17-20071002 uploaded to ibm-acpi.sf.net

2007-10-04 Thread Henrique de Moraes Holschuh
On Thu, 04 Oct 2007, Jan Gutter wrote: > On Thu, 2007-10-04 at 09:56 -0300, Henrique de Moraes Holschuh wrote: > > On Thu, 04 Oct 2007, Jan Gutter wrote: > > > On Wed, 2007-10-03 at 21:13 -0300, Henrique de Moraes Holschuh wrote: > > > > On Wed, 03 Oct 2007, Henrique de Moraes Holschuh wrote: > >

Re: [ibm-acpi-devel] [ltp] thinkpad-acpi release 0.17-20071002 uploaded to ibm-acpi.sf.net

2007-10-04 Thread Jan Gutter
On Thu, 2007-10-04 at 09:56 -0300, Henrique de Moraes Holschuh wrote: > On Thu, 04 Oct 2007, Jan Gutter wrote: > > On Wed, 2007-10-03 at 21:13 -0300, Henrique de Moraes Holschuh wrote: > > > On Wed, 03 Oct 2007, Henrique de Moraes Holschuh wrote: > Argh indeed, probably it is screwing up when look

Re: [ibm-acpi-devel] [ltp] thinkpad-acpi release 0.17-20071002 uploaded to ibm-acpi.sf.net

2007-10-04 Thread Jan Gutter
On Thu, 2007-10-04 at 15:49 +0200, Jan Gutter wrote: > sparky linux # echo 15 > /proc/acpi/ibm/brightness > bash: echo: write error: Invalid argument I'm such an idiot: echo level 15 > /proc/acpi/ibm/brightness works. -- Jan -

Re: [ibm-acpi-devel] [ltp] thinkpad-acpi release 0.17-20071002 uploaded to ibm-acpi.sf.net

2007-10-04 Thread Jan Gutter
On Wed, 2007-10-03 at 21:13 -0300, Henrique de Moraes Holschuh wrote: > On Wed, 03 Oct 2007, Henrique de Moraes Holschuh wrote: > > You found the problem. It is not doing a depth-walk to find LCD0._BCL. I > > shall have it fixed soon, there is a ugly and a nice way to do it. > > Jeez, it took so

Re: [ibm-acpi-devel] events for lid stopped working

2007-10-04 Thread Henrique de Moraes Holschuh
On Thu, 04 Oct 2007, Henrique de Moraes Holschuh wrote: > On Thu, 04 Oct 2007, Peter Jordan wrote: > > Henrique de Moraes Holschuh, 10/03/07 23:28: > > > On Wed, 03 Oct 2007, Peter Jordan wrote: > > >> Henrique de Moraes Holschuh, 10/03/07 19:57: > > >>> However, if you make a valid case for me for

Re: [ibm-acpi-devel] events for lid stopped working

2007-10-04 Thread Henrique de Moraes Holschuh
On Thu, 04 Oct 2007, Peter Jordan wrote: > Henrique de Moraes Holschuh, 10/03/07 23:28: > > On Wed, 03 Oct 2007, Peter Jordan wrote: > >> Henrique de Moraes Holschuh, 10/03/07 19:57: > >>> However, if you make a valid case for me for the reason you need the > >>> thinkpad-specific 0x5001 and 0x5002

Re: [ibm-acpi-devel] [ltp] thinkpad-acpi release 0.17-20071002 uploaded to ibm-acpi.sf.net

2007-10-04 Thread Henrique de Moraes Holschuh
On Thu, 04 Oct 2007, Christian Birchinger wrote: > Just as information, this enables working 16 levels on my Thinkpad R61 too. > Will try the new patch as soon as i get a chance. Good. This means as soon as I manage to get the detection routine right, I can send the patch upstream. -- "One dis

Re: [ibm-acpi-devel] [ltp] Re: thinkpad-acpi release 0.17-20071002 uploaded to ibm-acpi.sf.net

2007-10-04 Thread Henrique de Moraes Holschuh
On Thu, 04 Oct 2007, Chris Hanson wrote: > OK, I have a lot more information now. > > Contrary to what I previously (thought? I) saw, the procfs interface now > works OK after writing a bad value to sysfs. So this is a sysfs-only > problem, I think. > > The bug is definitely in the backlight imp

Re: [ibm-acpi-devel] [ltp] thinkpad-acpi release 0.17-20071002 uploaded to ibm-acpi.sf.net

2007-10-04 Thread Henrique de Moraes Holschuh
On Thu, 04 Oct 2007, Jan Gutter wrote: > On Wed, 2007-10-03 at 21:13 -0300, Henrique de Moraes Holschuh wrote: > > On Wed, 03 Oct 2007, Henrique de Moraes Holschuh wrote: > > > You found the problem. It is not doing a depth-walk to find LCD0._BCL. I > > > shall have it fixed soon, there is a ugly

Re: [ibm-acpi-devel] Thinkpad R61 8918-5QG LED control

2007-10-04 Thread Christian Birchinger
On Tue, Oct 02, 2007 at 11:30:22PM +0200, Christian Birchinger wrote: > I wonder if the LED control should work on this model. LED 1 > is the orange part of the battery and LED 7 is sleep (moon). > All the other leds don't change when i try to set or unset them. > > I'm using the latest 0.16-20070

Re: [ibm-acpi-devel] [ltp] thinkpad-acpi release 0.17-20071002 uploaded to ibm-acpi.sf.net

2007-10-04 Thread Christian Birchinger
On Wed, Oct 03, 2007 at 07:03:44PM -0300, Henrique de Moraes Holschuh wrote: > You found the problem. It is not doing a depth-walk to find LCD0._BCL. I > shall have it fixed soon, there is a ugly and a nice way to do it. > > Please do test the ugly way, just so we can test the rest of the stuff: