Re: [ibm-acpi-devel] [PATCH 01/15] ACPI: thinkpad-acpi: refactor hotkey_get and hotkey_set

2007-11-15 Thread Len Brown
> This patch: a nit to prove that I read this before dumping it into my test branch... the "perfect patch" never refers to itself as a patch in its check-in comments -- since by the time it is checked in, it is sort of self-evident it is a patch:-) http://www.zip.com.au/~akpm/linux/patches/stuf

[ibm-acpi-devel] [GIT PATCH] thinkpad-acpi patches for 2.6.25 (batch 1)

2007-11-15 Thread Henrique de Moraes Holschuh
Len, This patchset has most of my current thinkpad-acpi queue. The target is 2.6.25, I am submitting they early for testing in acpi-test. As usual, the patch set is available at: git://repo.or.cz/linux-2.6/linux-acpi-2.6/ibm-acpi-2.6.git for-upstream/acpi-test The branch root is latest Linus'

[ibm-acpi-devel] [PATCH 01/15] ACPI: thinkpad-acpi: refactor hotkey_get and hotkey_set

2007-11-15 Thread Henrique de Moraes Holschuh
This patch: 1. Splits hotkey_get/set into hotkey_status_get/set and hotkey_mask_get/set; 2. Caches the status of hot key mask for later driver use; 3. Makes sure the cache of hot key mask is refreshed when needed; 4. logs a printk notice when the firmware doesn't set the hot key mask to exactly

[ibm-acpi-devel] [PATCH 09/15] ACPI: thinkpad-acpi: spring cleanup part 4

2007-11-15 Thread Henrique de Moraes Holschuh
Remove dead code, and anything in the old changelog that is not a thank you credit, or a key point to track down history. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.c | 55 +++-- 1 files changed, 4 insertions

[ibm-acpi-devel] [PATCH 06/15] ACPI: thinkpad-acpi: spring cleanup part 1

2007-11-15 Thread Henrique de Moraes Holschuh
Remove the header file. Private header files used by a single .c file are in bad taste, and I know better now. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.c | 632 - drivers/misc/thinkpad_acpi.h | 656 ---

[ibm-acpi-devel] [PATCH 08/15] ACPI: thinkpad-acpi: spring cleanup part 3

2007-11-15 Thread Henrique de Moraes Holschuh
Reorder code in the file to get rid of more of the forward declarations, and to make things cleaner and more organized. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.c | 1493 +- 1 files changed, 734 insertion

[ibm-acpi-devel] [PATCH 07/15] ACPI: thinkpad-acpi: spring cleanup part 2

2007-11-15 Thread Henrique de Moraes Holschuh
Move most subdriver-related stuff imported from the header file closer to their subdriver code. Also, delete unneeded forward declarations. Signed-off-by: Henrique de Moraes Holschuh <[EMAIL PROTECTED]> --- drivers/misc/thinkpad_acpi.c | 613 +- 1 files c