Re: [ibm-acpi-devel] [PATCH 01/15] ACPI: thinkpad-acpi: refactor hotkey_get and hotkey_set

2007-11-19 Thread Len Brown
> I now have to decide whether I should follow my heart (indent levels with > tabs, everything else with spaces), or just decide that the kernel > hopelessly chained to tabs-as-8-spaces-only land and pipe thinkpad-acpi > entirely through unexpand to get rid of a huge ammount of checkpatch.pl > nag

Re: [ibm-acpi-devel] [PATCH] ACPI: thinkpad-acpi: fix oops when a module parameter has no value

2007-11-19 Thread Len Brown
applied thanks, -len On Sunday 18 November 2007 06:18, Henrique de Moraes Holschuh wrote: > set_ibm_param() could OOPS with a NULL pointer derreference if one did not > give > any values for a module parameter it handles. This would, of course, cause > all > sort of trouble for future modprobi

Re: [ibm-acpi-devel] fn+f7 does not produce any acpi event

2007-11-19 Thread Henrique de Moraes Holschuh
On Mon, 19 Nov 2007, Cristopher Camacho wrote: > I am having some troubles with the fn+f7 hotkey on my IBM X60, other hotkeys > report events, but fn+f7 reports nothing I am not really sure about what is > going on here. for example fn+f8 and fn+f9 give me back > > ibm/hotkey HKEY 0080

[ibm-acpi-devel] fn+f7 does not produce any acpi event

2007-11-19 Thread Cristopher Camacho
Hi All, I am having some troubles with the fn+f7 hotkey on my IBM X60, other hotkeys report events, but fn+f7 reports nothing I am not really sure about what is going on here. for example fn+f8 and fn+f9 give me back ibm/hotkey HKEY 0080 1008 ibm/hotkey HKEY 0080 1009 but fn+f