Re: [ibm-acpi-devel] [PATCH 3/4] thinkpad-acpi: Avoid heap buffer overrun

2009-08-01 Thread Len Brown
applied w/ simplified check-in commment thanks, Len Brown, Intel Open Source Technology Center -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integrat

Re: [ibm-acpi-devel] [PATCH 4/4] thinkpad-acpi: fix incorrect use of TPACPI_BRGHT_MODE_ECNVRAM

2009-08-01 Thread Len Brown
applied thanks, Len Brown, Intel Open Source Technology Center -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus o

Re: [ibm-acpi-devel] [PATCH 2/4] thinkpad-acpi: remove dock and bay subdrivers

2009-08-01 Thread Len Brown
applied thanks, Len Brown, Intel Open Source Technology Center -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus o

Re: [ibm-acpi-devel] [PATCH 1/4] thinkpad-acpi: disable broken bay and dock subdrivers

2009-08-01 Thread Len Brown
applied thanks, Len Brown, Intel Open Source Technology Center -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus o

Re: [ibm-acpi-devel] [PATCH 3/4] thinkpad-acpi: Avoid heap buffer overrun

2009-08-01 Thread Henrique de Moraes Holschuh
On Sat, 01 Aug 2009, Michael Buesch wrote: > On Saturday 01 August 2009 17:04:19 Henrique de Moraes Holschuh wrote: > > From: Michael Buesch > > > > Avoid a heap buffer overrun triggered by an integer overflow of the > > userspace controlled "count" variable. > > > > If userspace passes in a "co

[ibm-acpi-devel] [PATCH 2/4] thinkpad-acpi: remove dock and bay subdrivers

2009-08-01 Thread Henrique de Moraes Holschuh
The standard ACPI dock driver can handle the hotplug bays and docks of the ThinkPads just fine (including batteries) as of 2.6.27, and the code in thinkpad-acpi for the dock and bay subdrivers is currently broken anyway... Userspace needs some love to support the two-stage ejection nicely, but it

[ibm-acpi-devel] [PATCH 1/4] thinkpad-acpi: disable broken bay and dock subdrivers

2009-08-01 Thread Henrique de Moraes Holschuh
Currently, the ThinkPad-ACPI bay and dock drivers are completely broken, and cause a NULL pointer derreference in kernel mode (and, therefore, an OOPS) when they try to issue events (i.e. on dock, undock, bay ejection, etc). OTOH, the standard ACPI dock driver can handle the hotplug bays and docks

[ibm-acpi-devel] [PATCH 3/4] thinkpad-acpi: Avoid heap buffer overrun

2009-08-01 Thread Henrique de Moraes Holschuh
From: Michael Buesch Avoid a heap buffer overrun triggered by an integer overflow of the userspace controlled "count" variable. If userspace passes in a "count" of (size_t)-1l, the kmalloc size will overflow to ((size_t)-1l + 2) = 1, so only one byte will be allocated. However, copy_from_user()

[ibm-acpi-devel] [GIT PATCH] thinkpad-acpi 2.6.31-rc fixes

2009-08-01 Thread Henrique de Moraes Holschuh
Len, This patchset has important fixes (two are security fixes, one is known-dangerous code removal, and one is a regression fix) for thinkpad-acpi. Not all of them have bugzilla entries. It includes the patches I already sent you, but which were not sent to mainline yet. Please send them to Li

[ibm-acpi-devel] [PATCH 4/4] thinkpad-acpi: fix incorrect use of TPACPI_BRGHT_MODE_ECNVRAM

2009-08-01 Thread Henrique de Moraes Holschuh
HBRV-based default selection of backlight control strategy didn't work well, at least the X41 defines it but doesn't use it and I don't think it will stop there. Switch to a white/blacklist. All models that have HBRV defined have been included in the list, and initially all ATI GPUs will get ECNV