Re: [ibm-acpi-devel] [GIT PATCH] backlight event support enhancements

2009-09-20 Thread Richard Purdie
On Sun, 2009-09-20 at 14:44 -0300, Henrique de Moraes Holschuh wrote: > This two-patch patchset adds poll() support to Matthew's backlight event > work, and also adds backlight event support for thinkpad-acpi. > > The thinkpad-acpi changes depend on a patchset I just sent to Len Brown > for mergin

Re: [ibm-acpi-devel] Parallel port not detected if laptop (X60s) is not docked at boot time

2009-09-20 Thread Paride Legovini
On Sun, Sep 20, 2009 at 08:12:28PM -0300, Henrique de Moraes Holschuh wrote: > Please check if reloading the parport and/or lp modules makes it find the > port. Does it? No, it doesn't. I just get get the lp: driver loaded but no devices found message.

Re: [ibm-acpi-devel] Parallel port not detected if laptop (X60s) is not docked at boot time

2009-09-20 Thread Henrique de Moraes Holschuh
Please check if reloading the parport and/or lp modules makes it find the port. Does it? -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Ho

[ibm-acpi-devel] thinkpad-acpi release 0.23-20090920 uploaded to ibm-acpi.sf.net

2009-09-20 Thread Henrique de Moraes Holschuh
I have released version 0.23-20090920 of thinkpad-acpi through the sourceforge.net release system. Patches are available for 2.6.27, 2.6.28, 2.6.29, 2.6.30 and 2.6.31 at: https://sourceforge.net/projects/ibm-acpi/files/thinkpad-acpi/0.23-20090920/ (support for 2.6.28 and 2.6.29 will be

Re: [ibm-acpi-devel] Parallel port not detected if laptop (X60s) is not docked at boot time

2009-09-20 Thread Henrique de Moraes Holschuh
On Sun, 20 Sep 2009, Paride Legovini wrote: > I own a thinkpad X60s and its docking station (ultrabase X6), which has > a parallel port on it. I'm running a 2.6.31 vanilla kernel. > When I boot with the laptop while it is docked the 'partport' and 'lp' > modules are loaded and I get the /dev/lp0 de

[ibm-acpi-devel] Parallel port not detected if laptop (X60s) is not docked at boot time

2009-09-20 Thread Paride Legovini
I own a thinkpad X60s and its docking station (ultrabase X6), which has a parallel port on it. I'm running a 2.6.31 vanilla kernel. When I boot with the laptop while it is docked the 'partport' and 'lp' modules are loaded and I get the /dev/lp0 device I can use for printing. If I boot the laptop wh

[ibm-acpi-devel] [PATCH 1/2] backlight: extend event support to also support poll()

2009-09-20 Thread Henrique de Moraes Holschuh
Extend the backlight event support to also allow the use of poll()/select() on actual_brightness. We already have the entire event hookup anyway, adding a single function call in one line to get functionality like that is a really good deal. Signed-off-by: Henrique de Moraes Holschuh Cc: Matthew

[ibm-acpi-devel] [GIT PATCH] backlight event support enhancements

2009-09-20 Thread Henrique de Moraes Holschuh
Matthew, Richard, This two-patch patchset adds poll() support to Matthew's backlight event work, and also adds backlight event support for thinkpad-acpi. The thinkpad-acpi changes depend on a patchset I just sent to Len Brown for merging in acpi-test. Is there any timeframe for the backlight eve

[ibm-acpi-devel] [PATCH 2/2] thinkpad-acpi: issue backlight class events

2009-09-20 Thread Henrique de Moraes Holschuh
Take advantage of the new events capabilities of the backlight class to notify userspace of backlight changes. This depends on "backlight: Allow drivers to update the core, and generate events on changes", by Matthew Garrett. Signed-off-by: Henrique de Moraes Holschuh Cc: Matthew Garrett --- D

[ibm-acpi-devel] [PATCH 1/6] thinkpad-acpi: don't leave ERR_PTR() pointers around

2009-09-20 Thread Henrique de Moraes Holschuh
backlight_device_register returns ERR_PTR() in case of problems, and the current code would leave that ERR_PTR in ibm_backlight_device. The current code paths won't touch it in that situation, but that could change. Make sure to set ibm_backlight_device to NULL in the error path. Signed-off-by:

[ibm-acpi-devel] [PATCH 2/6] thinkpad-acpi: remove uneeded tp_features.hotkey tests in hotkey_exit

2009-09-20 Thread Henrique de Moraes Holschuh
hotkey_exit() is only called if hotkey_init() finished sucessfully, or by direct calls inside hotkey_init(). The tp_features.hotkey test is always true, and just adds to the confusion, remove it. Also, avoid calling hotkey_mask_set() when it won't do anything useful. Signed-off-by: Henrique de M

[ibm-acpi-devel] [PATCH 6/6] thinkpad-acpi: name event constants

2009-09-20 Thread Henrique de Moraes Holschuh
Reduce the number of magic numbers in the driver... note that they were all explained and documented already. Signed-off-by: Henrique de Moraes Holschuh --- drivers/platform/x86/thinkpad_acpi.c | 92 + 1 files changed, 69 insertions(+), 23 deletions(-) diff --g

[ibm-acpi-devel] [PATCH 4/6] thinkpad-acpi: hotkey event driver update

2009-09-20 Thread Henrique de Moraes Holschuh
Update the HKEY event driver to: 1. Handle better the second-gen firmware, which has no HKEY mask support but does report FN+F3, FN+F4 and FN+F12 without the need for NVRAM polling. a) always make the mask-related attributes available in sysfs; b) use DMI quirks to detect the second-g

[ibm-acpi-devel] [GIT PATCH] thinkpad-acpi patches for the merge window (second set)

2009-09-20 Thread Henrique de Moraes Holschuh
Len, This is a second set of changes for thinkpad-acpi that I would like to see merged into acpi-test for this merge window. The patchset contains some cleanups, and an important rework of the internal hotkey event handling code which new features will depend on. I apologise for not sending them

[ibm-acpi-devel] [PATCH 5/6] thinkpad-acpi: add internal hotkey event API

2009-09-20 Thread Henrique de Moraes Holschuh
Add an internal API to the driver, to allow subdrivers to request and receive HKEY 0x1000 events. This API will be used by the backlight (brightness up/down) and upcoming ALSA mixer (volume up/down/mute) subdrivers. Signed-off-by: Henrique de Moraes Holschuh --- drivers/platform/x86/thinkpad_ac

[ibm-acpi-devel] [PATCH 3/6] thinkpad-acpi: drop HKEY event 0x5010

2009-09-20 Thread Henrique de Moraes Holschuh
HKEY event 0x5010 is useless to us: old ThinkPads don't issue it. Newer ThinkPads won't issue it anymore. And all ThinkPads issue 0x1010 and 0x1011 events. Just silently drop it instead of sending it to userspace. Signed-off-by: Henrique de Moraes Holschuh --- Documentation/laptops/thinkpad-a