Re: [ibm-acpi-devel] [GIT PATCH] thinkpad-acpi fixes for 2.6.32-rc2

2009-12-26 Thread Peter Jordan
Henrique de Moraes Holschuh, Sun Dec 27 2009 01:52:12 GMT+0100 (CET): > Len, > > This patchset fixes a few problems that have been reported, > including the annoying build problem reported by Ingo. > > It mostly updates the new ALSA functionality to be better > behaved, and makes it optional for

Re: [ibm-acpi-devel] [GIT PATCH] thinkpad-acpi fixes for 2.6.32-rc2

2009-12-26 Thread Len Brown
applied to acpi-test thanks, Len Brown, Intel Open Source Technology Center On Sat, 26 Dec 2009, Henrique de Moraes Holschuh wrote: > Len, > > This patchset fixes a few problems that have been reported, > including the annoying build problem reported by Ingo. > > It mostly updates the new ALSA

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi.c: Remove #define TPACPI_s for printks

2009-12-26 Thread Henrique de Moraes Holschuh
On Sat, 26 Dec 2009, Joe Perches wrote: > On Sat, 2009-12-26 at 22:29 -0200, Henrique de Moraes Holschuh wrote: > > Unfolding the printk messages to a single line _is_ useful for grep, though, > > and I plan to do just that (not high priority, though), and I would accept > > patches that do just th

[ibm-acpi-devel] [PATCH 3/5] thinkpad-acpi: make volume subdriver optional

2009-12-26 Thread Henrique de Moraes Holschuh
Allow the user to choose through Kconfig if the Console Audio Control interface (aka "volume subdriver") should be available or not. This not only saves some memory, but also allows the thinkpad-acpi driver to be built-in even if ALSA is modular when the console audio control interface is not want

[ibm-acpi-devel] [PATCH 4/5] thinkpad-acpi: update volume documentation

2009-12-26 Thread Henrique de Moraes Holschuh
Update the volume subdriver documentation. Signed-off-by: Henrique de Moraes Holschuh --- Documentation/laptops/thinkpad-acpi.txt | 58 ++ 1 files changed, 50 insertions(+), 8 deletions(-) diff --git a/Documentation/laptops/thinkpad-acpi.txt b/Documentation/laptop

[ibm-acpi-devel] [GIT PATCH] thinkpad-acpi fixes for 2.6.32-rc2

2009-12-26 Thread Henrique de Moraes Holschuh
Len, This patchset fixes a few problems that have been reported, including the annoying build problem reported by Ingo. It mostly updates the new ALSA functionality to be better behaved, and makes it optional for people who could care less for on-screen-display of volume hotkeys and would rather

[ibm-acpi-devel] [PATCH 5/5] thinkpad-acpi: improve Kconfig help text

2009-12-26 Thread Henrique de Moraes Holschuh
Document that rfkill and ALSA functionality exists, but requires the subsystems to be available, and not modular if thinkpad-acpi is not modular. Signed-off-by: Henrique de Moraes Holschuh --- drivers/platform/x86/Kconfig |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git

[ibm-acpi-devel] [PATCH 1/5] thinkpad-acpi: don't take the first ALSA slot by default

2009-12-26 Thread Henrique de Moraes Holschuh
We don't want to be the first soundcard. We don't want to shift other soundcards out of the way either, even if they load much later. Ask ALSA to (by default) load us in one of the last three slots. This can be overriden at will using the "index" parameter. Reported-by: Whoopie Signed-off-by:

[ibm-acpi-devel] [PATCH 2/5] thinkpad-acpi: don't fail to load the entire module due to ALSA problems

2009-12-26 Thread Henrique de Moraes Holschuh
If we cannot create the ALSA mixer, it is a good reason to fail to load the volume subdriver, and not to fail to load the entire module. While at it, add more debugging messages, as the error paths are being used a lot more than I'd expect, and it is failing to set up the ALSA mixer on a number of

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi.c: Remove #define TPACPI_s for printks

2009-12-26 Thread Henrique de Moraes Holschuh
On Fri, 25 Dec 2009, Joe Perches wrote: > On Sat, 2009-12-26 at 02:20 -0200, Henrique de Moraes Holschuh wrote: > > Why would I want a parameter macro instead of a straightforward bunch of > > #defines ? > > To make grep a bit easier. Is greping for KERN_ common? Unfolding the printk messages to