Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-09 Thread Andrew Lutomirski
On Mon, May 9, 2011 at 10:36 PM, Andrew Lutomirski wrote: > On Mon, May 9, 2011 at 9:04 PM, Henrique de Moraes Holschuh > wrote: >> On Mon, 09 May 2011, Andrew Lutomirski wrote: >>> FWIW, this patch (other than having the wrong default on X220) makes >>> Linux better than Windows :) >> >> Please

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-09 Thread Andrew Lutomirski
On Mon, May 9, 2011 at 9:04 PM, Henrique de Moraes Holschuh wrote: > On Mon, 09 May 2011, Andrew Lutomirski wrote: >> FWIW, this patch (other than having the wrong default on X220) makes >> Linux better than Windows :) > > Please expand on that, especially the "wrong default on X220"... > >> Do yo

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-09 Thread Henrique de Moraes Holschuh
On Mon, 09 May 2011, Andrew Lutomirski wrote: > FWIW, this patch (other than having the wrong default on X220) makes > Linux better than Windows :) Please expand on that, especially the "wrong default on X220"... > Do you know how to read a field from the EC by name? I think I can If it is in t

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-09 Thread Andrew Lutomirski
On Mon, May 9, 2011 at 7:53 PM, Henrique de Moraes Holschuh wrote: > Interesting.  Let me test it on my T43, it has hardware volume and seems to > cover a class of box you couldn't test. > > I like the idea, but I might have some questions to ask you about it.  More > on this after I test the patc

Re: [ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-09 Thread Henrique de Moraes Holschuh
Interesting. Let me test it on my T43, it has hardware volume and seems to cover a class of box you couldn't test. I like the idea, but I might have some questions to ask you about it. More on this after I test the patch in the next few days. -- "One disk to rule them all, One disk to find t

[ibm-acpi-devel] [RFC PATCH] thinkpad-acpi: Improve hardware volume controls

2011-05-09 Thread Andy Lutomirski
ThinkPads have hardware volume controls and three buttons to control them. (These are separate from the standard mixer.) By default, the buttons are: - Mute: Mutes the hardware volume control and generates KEY_MUTE. - Up: Unmutes, generates KEY_VOLUMEUP, and increases volume if applicable.

Re: [ibm-acpi-devel] [RFC] Controlling the ThinkPad battery charger

2011-05-09 Thread Andrew Lutomirski
On Mon, May 9, 2011 at 11:29 AM, Henrique de Moraes Holschuh wrote: > On Mon, 09 May 2011, Andrew Lutomirski wrote: >> > The SBS interface exposes more data about the battery, including >> > per-cell-group voltage and pack microcontroller aging counters, alarms, and >> > the "needs to get through

Re: [ibm-acpi-devel] [RFC] Controlling the ThinkPad battery charger

2011-05-09 Thread Henrique de Moraes Holschuh
On Mon, 09 May 2011, Andrew Lutomirski wrote: > > The SBS interface exposes more data about the battery, including > > per-cell-group voltage and pack microcontroller aging counters, alarms, and > > the "needs to get through the fuel-gaugue reset procedure" semasphore. > > If I'm feeling really mo

Re: [ibm-acpi-devel] [RFC] Controlling the ThinkPad battery charger

2011-05-09 Thread Andrew Lutomirski
On Mon, May 9, 2011 at 10:45 AM, Henrique de Moraes Holschuh wrote: > On Sun, 08 May 2011, Andrew Lutomirski wrote: >> I've figured out how the ThinkPad SMAPI charge control works (at least >> well enough to program thresholds on some models), and I'd like to get > > Yeah, there's a little protoco

Re: [ibm-acpi-devel] [RFC] Controlling the ThinkPad battery charger

2011-05-09 Thread Henrique de Moraes Holschuh
On Sun, 08 May 2011, Andrew Lutomirski wrote: > I've figured out how the ThinkPad SMAPI charge control works (at least > well enough to program thresholds on some models), and I'd like to get Yeah, there's a little protocol to talk to the EC, otherwise it simply ignores writes to the battery thres

Re: [ibm-acpi-devel] [RFC] Controlling the ThinkPad battery charger

2011-05-09 Thread Matthew Garrett
On Sun, May 08, 2011 at 08:35:32AM -0400, Andrew Lutomirski wrote: > I like option 2 better, since it means that a userspace tool (like > GNOME) could learn how to operate a battery charge controller once and > then other laptops and devices could reuse the same interface. The > problem is that t