[ibm-acpi-devel] thinkpad_acpi: unhandled HKEY event 0x6060

2013-06-20 Thread Lauri Kenttä
On a Lenovo Thinkpad E335, I sometimes (maybe once per month) manage to get this unhandled HKEY event 0x6060. I donät know why, it just happens in the middle of normal use. It also totally hangs all input, mouse and keyboard, including VT switching. Some Fn keys still work, such as shutting dow

Re: [ibm-acpi-devel] [PATCH 0/3] thinkpad_acpi: avoid ACPI Warning while operating non-exist LEDs

2013-06-20 Thread Igor Gnatenko
On Fri, 2013-06-07 at 16:20 +0800, Adam Lee wrote: > Some new Lenovo or ThinkPad laptops don't have EC controllable LEDs What laptops have this problem ? -- Best Regards, Igor Gnatenko signature.asc Description: This is a digitally signed message part ---

Re: [ibm-acpi-devel] [PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't have EC controllable LEDs

2013-06-20 Thread Adam Lee
On Fri, Jun 07, 2013 at 05:16:15PM -0300, Henrique de Moraes Holschuh wrote: > Can you get me the ACPI interface documentation? It should be simple > to get it, but I haven't emailed the Lenovo BIOS engineers for some > time. > > Basically, create a new LED method in thinkpad-acpi, lock it down t

Re: [ibm-acpi-devel] Patch for thinkpad-acpi.c

2013-06-20 Thread Bruce
Hi, Bjorn Thank your advice . I will modify my code, then try to submit again. Bruce.Ma May 29,2013 On 05/28/2013 06:28 PM, Bjørn Mork wrote: > Bruce writes: > >> +struct blacklist lenovo_blacklist[] = { >> + { >> +.model_s = "Lenovo LM490s", >> +.nummodel_s = "814YG01", >> + }, > >

[ibm-acpi-devel] [PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't have EC controllable LEDs

2013-06-20 Thread Adam Lee
Some new Lenovo or ThinkPad laptops don't have EC controllable LEDs. This patch adds their quirks. Signed-off-by: Adam Lee --- drivers/platform/x86/thinkpad_acpi.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_a

[ibm-acpi-devel] [PATCH 2/3] thinkpad_acpi: add the ability setting TPACPI_LED_NONE by quirk

2013-06-20 Thread Adam Lee
Some new Lenovo or ThinkPad laptops don't have EC controllable LEDs, their LED quirks are 0. This patch set led_supported=TPACPI_LED_NONE when quirk equals 0. Signed-off-by: Adam Lee --- drivers/platform/x86/thinkpad_acpi.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-)

[ibm-acpi-devel] [PATCH 0/3] thinkpad_acpi: avoid ACPI Warning while operating non-exist LEDs

2013-06-20 Thread Adam Lee
Some new Lenovo or ThinkPad laptops don't have EC controllable LEDs, they control LEDs by BIOS functions, and return ACPI Warning while operating LEDs by EC. These patches set some quirks, optimize led_init() and led_write() to avoid that warning. Adam Lee (3): thinkpad_acpi: return -NODEV whil

Re: [ibm-acpi-devel] [PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't have EC controllable LEDs

2013-06-20 Thread Adam Lee
On Fri, Jun 07, 2013 at 01:22:39PM +, Matthew Garrett wrote: > On Fri, 2013-06-07 at 16:20 +0800, Adam Lee wrote: > > Some new Lenovo or ThinkPad laptops don't have EC controllable LEDs. > > This patch adds their quirks. > > Can you detect this case? If this is a new way of doing things then >

[ibm-acpi-devel] Patch for thinkpad-acpi.c

2013-06-20 Thread Bruce
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, all: We are testing Ubuntu 12.04 on some laptops , and find out there are some error messages in dmesg after run S3 or S4. Like: [10512.177806] ACPI Warning: For \_SB_.PCI0.LPCB.H_EC.LED_: Excess arguments - needs 1, found 2 (20110623/nspredef-32

Re: [ibm-acpi-devel] [PATCH 1/3] thinkpad_acpi: return -NODEV while operating uninitialized LEDs

2013-06-20 Thread Adam Lee
On Fri, Jun 07, 2013 at 10:53:50AM +0200, Bjørn Mork wrote: > Adam Lee writes: > > > --- a/drivers/platform/x86/thinkpad_acpi.c > > +++ b/drivers/platform/x86/thinkpad_acpi.c > > @@ -5401,9 +5401,12 @@ static int led_write(char *buf) > > return -ENODEV; > > > > while ((cmd = nex

[ibm-acpi-devel] [PATCH v2] thinkpad_acpi: return -NODEV while operating uninitialized LEDs

2013-06-20 Thread Adam Lee
Not all 0-15 LEDs are available for all models, sometimes it's even not safe. This patch return -NODEV while operating uninitialized LEDs. Signed-off-by: Adam Lee --- drivers/platform/x86/thinkpad_acpi.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/platform/

[ibm-acpi-devel] [PATCH 1/3] thinkpad_acpi: return -NODEV while operating uninitialized LEDs

2013-06-20 Thread Adam Lee
Not all 0-15 LEDs are available for all models, sometimes it's even not safe. This patch return -NODEV while operating uninitialized LEDs. Signed-off-by: Adam Lee --- drivers/platform/x86/thinkpad_acpi.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/platform/

[ibm-acpi-devel] [PATCH] subsystem: thinkpad-acpi.c

2013-06-20 Thread Bruce
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 from: Bruce Ma For some specific model of laptop, don't execute any led functions. Signed-off-by: Bruce Ma - --- - --- old/thinkpad_acpi.c2013-01-29 16:54:34.0 +0800 +++ src/thinkpad_acpi.c2013-01-29 16:52:46.0 +0800 @@ -178

[ibm-acpi-devel] [PATCH 1/3 v3] thinkpad_acpi: return -NODEV while operating uninitialized LEDs

2013-06-20 Thread Adam Lee
Not all 0-15 LEDs are available for all models, sometimes it's even not safe. This patch return -NODEV while operating uninitialized LEDs. Signed-off-by: Adam Lee --- drivers/platform/x86/thinkpad_acpi.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/pla

Re: [ibm-acpi-devel] [PATCH 1/3] thinkpad_acpi: return -NODEV while operating uninitialized LEDs

2013-06-20 Thread Bjørn Mork
Adam Lee writes: > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -5401,9 +5401,12 @@ static int led_write(char *buf) > return -ENODEV; > > while ((cmd = next_cmd(&buf))) { > - if (sscanf(cmd, "%d", &led) != 1 || led

[ibm-acpi-devel] unhandled HKEY event 0x6040

2013-06-20 Thread MIchael Lustenberger
Hi, sitting on my shiny new (..) lenovo x131e with a debian wheezy setup - and well aware that this is maybe not the latest kernel version out there (3.2.0-4-amd64) - I am getting the following message any time I plug or unplug the power cord (both trigger the same '0x6040'): {{{ Jun 12 16:45:57

Re: [ibm-acpi-devel] [PATCH v2] thinkpad_acpi: return -NODEV while operating uninitialized LEDs

2013-06-20 Thread Amos Kong
On Fri, Jun 7, 2013 at 5:05 PM, Adam Lee wrote: > > Not all 0-15 LEDs are available for all models, sometimes it's even not > safe. This patch return -NODEV while operating uninitialized LEDs. > > Signed-off-by: Adam Lee > --- > drivers/platform/x86/thinkpad_acpi.c |5 - > 1 file changed

Re: [ibm-acpi-devel] [PATCH 3/3] thinkpad_acpi: add LED quirks of models which don't have EC controllable LEDs

2013-06-20 Thread Matthew Garrett
On Fri, 2013-06-07 at 16:20 +0800, Adam Lee wrote: > Some new Lenovo or ThinkPad laptops don't have EC controllable LEDs. > This patch adds their quirks. Can you detect this case? If this is a new way of doing things then you're going to have to add new entries to the quirk list every time Lenovo

Re: [ibm-acpi-devel] Patch for thinkpad-acpi.c

2013-06-20 Thread Bjørn Mork
Bruce writes: > +struct blacklist lenovo_blacklist[] = { > + { > +.model_s = "Lenovo LM490s", > +.nummodel_s = "814YG01", > + }, The driver already has a list of LED support per model in the static const struct tpacpi_quirk led_useful_qtable[] __initconst = {} array. Why do you

[ibm-acpi-devel] CPU governor ondemand misbehaves after s2ram for kernel 3.10-rcX

2013-06-20 Thread Toralf Förster
If I s2ram my ThinkPad T420 (latest BIOS) and wake it up, CPU speeds up to 2.4 GHz/2.6GHz (max freq. without boost for the i5) and temperature increases to 70°-80°. Switching to governor powersave and back to ondemand helps, CPU are at 800 MHz and temperature at 49°. 3.9.X works fine. Few dmesg/ls

[ibm-acpi-devel] thinkpad_acpi: please report the conditions when this event happened to...

2013-06-20 Thread Kopiás Csaba
Hello! I saw this error, having no clue what does it mean, so i send it to you. Thank you for your work! Jun 18 10:00:12 x220 kernel: [ 1361.515925] thinkpad_acpi: unknown possible thermal alarm or keyboard event received Jun 18 10:00:12 x220 kernel: [ 1361.515929] thinkpad_acpi: unhandled HKEY

[ibm-acpi-devel] unhandled HKEY event 0x6040

2013-06-20 Thread dongsik park
[ 7509.949650] thinkpad_acpi: unknown possible thermal alarm or keyboard event received [ 7509.949675] thinkpad_acpi: unhandled HKEY event 0x6040 [ 7509.949677] thinkpad_acpi: please report the conditions when this event happened to ibm-acpi-devel@lists.sourceforge.net [ 7509.949991] thinkpad_acpi:

[ibm-acpi-devel] dmesg log.

2013-06-20 Thread Haris Ibrahim K. V.
Hi I am running Ubuntu 12.04 and I happened to simply close the lid of my computer (IBM ThinkPad X230) for a while, put it in my bag and took it from one building to another where I switched between wifis. "dmesg" showed the following log and told me to report this issue. Hence the mail. [192804.5

[ibm-acpi-devel] [PATCH] Remove nested functions from Thinkpad ACPI

2013-06-20 Thread Behan Webster
The only real change is passing in event_mask to the formerly nested functions. Otherwise it's just moving around function and macro code. This is the only place in the Linux kernel where nested functions are still in use. Nested functions aren't part of the C standards, and complicate the generat