Re: [ibm-acpi-devel] [PATCH 4/6] thinkpad_acpi: Add support for more adaptive kbd buttons

2015-02-19 Thread Darren Hart
On Wed, Feb 18, 2015 at 09:53:48PM +0100, Bastien Nocera wrote: > This commit adds new elements to the ThinkPad keymaps, and > will send key events for keys for which an input.h declaration > exists. > > Signed-off-by: Bastien Nocera > --- > drivers/platform/x86/thinkpad_acpi.c | 80 > +

Re: [ibm-acpi-devel] [PATCH 3/6] thinkpad_acpi: Add adaptive_kbd_mode sysfs attr

2015-02-19 Thread Darren Hart
On Wed, Feb 18, 2015 at 09:53:44PM +0100, Bastien Nocera wrote: Commit message please. > Signed-off-by: Bastien Nocera > --- > drivers/platform/x86/thinkpad_acpi.c | 71 > +++- > 1 file changed, 62 insertions(+), 9 deletions(-) > > diff --git a/drivers/platform

Re: [ibm-acpi-devel] [PATCH 2/6] thinkpad_acpi: Factor out get/set adaptive kbd mode

2015-02-19 Thread Darren Hart
On Wed, Feb 18, 2015 at 09:53:35PM +0100, Bastien Nocera wrote: Please provide a commit message. There is always something to say beyond what is in the subject. In this case, I suggest the motivation and justification for the change. While I appreciate the abstraction, it makes the code at the ca

Re: [ibm-acpi-devel] [PATCH 1/6] thinkpad_acpi: Remember adaptive kbd presence

2015-02-19 Thread Darren Hart
On Wed, Feb 18, 2015 at 09:53:28PM +0100, Bastien Nocera wrote: > Rather than checking on each suspend and resume whether the laptop > has an adaptive keyboard, check when the driver is initialised. Reasonable. > > Signed-off-by: Bastien Nocera > --- > drivers/platform/x86/thinkpad_acpi.c | 38