Re: [ibm-acpi-devel] [PATCH 5/7] input: Add keycodes used by Lenovo Carbon X1 2014

2015-02-20 Thread Bastien Nocera
Hey Dmitry, On Fri, 2015-02-20 at 10:40 -0800, Dmitry Torokhov wrote: > On Fri, Feb 20, 2015 at 10:04:04AM -0500, Benjamin Tissoires wrote: > > On Fri, Feb 20, 2015 at 9:44 AM, Bastien Nocera wrote: > > > Signed-off-by: Bastien Nocera > > > --- > > > include/uapi/linux/input.h | 10 ++ >

Re: [ibm-acpi-devel] [PATCH 5/7] input: Add keycodes used by Lenovo Carbon X1 2014

2015-02-20 Thread Dmitry Torokhov
On Fri, Feb 20, 2015 at 10:04:04AM -0500, Benjamin Tissoires wrote: > On Fri, Feb 20, 2015 at 9:44 AM, Bastien Nocera wrote: > > Signed-off-by: Bastien Nocera > > --- > > include/uapi/linux/input.h | 10 ++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/include/uapi/linux/inpu

Re: [ibm-acpi-devel] [PATCH 4/6] thinkpad_acpi: Add support for more adaptive kbd buttons

2015-02-20 Thread Bastien Nocera
On Thu, 2015-02-19 at 21:35 -0800, Darren Hart wrote: > On Wed, Feb 18, 2015 at 09:53:48PM +0100, Bastien Nocera wrote: > > This commit adds new elements to the ThinkPad keymaps, and > > will send key events for keys for which an input.h declaration > > exists. > > > > Signed-off-by: Bastien Nocer

[ibm-acpi-devel] [PATCH 2/7] thinkpad_acpi: Factor out get/set adaptive kbd mode

2015-02-20 Thread Bastien Nocera
Move the getting/setting of the adaptive keyboard mode to separate functions, so that we can reuse them later through sysfs attributes. Signed-off-by: Bastien Nocera --- drivers/platform/x86/thinkpad_acpi.c | 61 ++-- 1 file changed, 38 insertions(+), 23 deletions

[ibm-acpi-devel] [PATCH 1/7] thinkpad_acpi: Remember adaptive kbd presence

2015-02-20 Thread Bastien Nocera
Rather than checking on each suspend and resume whether the laptop has an adaptive keyboard, check when the driver is initialised. Signed-off-by: Bastien Nocera --- drivers/platform/x86/thinkpad_acpi.c | 37 ++-- 1 file changed, 18 insertions(+), 19 deletions(-)

Re: [ibm-acpi-devel] [PATCH 3/7] thinkpad_acpi: Add adaptive_kbd_mode sysfs attr

2015-02-20 Thread Bastien Nocera
On Fri, 2015-02-20 at 17:27 +0200, Mika Westerberg wrote: > On Fri, Feb 20, 2015 at 04:22:07PM +0100, Bastien Nocera wrote: > > On Fri, 2015-02-20 at 17:20 +0200, Mika Westerberg wrote: > > > On Fri, Feb 20, 2015 at 03:44:22PM +0100, Bastien Nocera wrote: > > > > Add a sysfs attribute to allow priv

Re: [ibm-acpi-devel] [PATCH 3/7] thinkpad_acpi: Add adaptive_kbd_mode sysfs attr

2015-02-20 Thread Bastien Nocera
On Fri, 2015-02-20 at 17:20 +0200, Mika Westerberg wrote: > On Fri, Feb 20, 2015 at 03:44:22PM +0100, Bastien Nocera wrote: > > Add a sysfs attribute to allow privileged users to change the keyboard > > mode. This could be used by desktop environments to change the keyboard > > mode depending on th

[ibm-acpi-devel] [PATCH 5/7] input: Add keycodes used by Lenovo Carbon X1 2014

2015-02-20 Thread Bastien Nocera
Signed-off-by: Bastien Nocera --- include/uapi/linux/input.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h index b0a8130..affe40e 100644 --- a/include/uapi/linux/input.h +++ b/include/uapi/linux/input.h @@ -740,6 +740,16 @@

[ibm-acpi-devel] [PATCH 7/7] thinkpad_acpi: use DEVICE_ATTR_* macros

2015-02-20 Thread Bastien Nocera
Use the DEVICE_ATTR_RW macro to reduce boiler plate and move the attribute declaration to get rid of function signatures. Signed-off-by: Bastien Nocera --- drivers/platform/x86/thinkpad_acpi.c | 72 ++-- 1 file changed, 20 insertions(+), 52 deletions(-) diff --gi

[ibm-acpi-devel] [PATCH 4/7] thinkpad_acpi: Add support for more adaptive kbd buttons

2015-02-20 Thread Bastien Nocera
This commit adds new elements to the ThinkPad keymaps, and will send key events for keys for which an input.h declaration exists. Signed-off-by: Bastien Nocera --- drivers/platform/x86/thinkpad_acpi.c | 80 +++- 1 file changed, 79 insertions(+), 1 deletion(-) dif

[ibm-acpi-devel] [PATCH 6/7] thinkpad_acpi: More Carbon X1 2014 keys

2015-02-20 Thread Bastien Nocera
Add support for newly added evdev keycodes. Signed-off-by: Bastien Nocera --- drivers/platform/x86/thinkpad_acpi.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index 57130a1..53

[ibm-acpi-devel] [PATCH 3/7] thinkpad_acpi: Add adaptive_kbd_mode sysfs attr

2015-02-20 Thread Bastien Nocera
Add a sysfs attribute to allow privileged users to change the keyboard mode. This could be used by desktop environments to change the keyboard mode depending on the application focused, as the Windows application does. Signed-off-by: Bastien Nocera --- drivers/platform/x86/thinkpad_acpi.c | 69 +

Re: [ibm-acpi-devel] [PATCH 3/6] thinkpad_acpi: Add adaptive_kbd_mode sysfs attr

2015-02-20 Thread Bastien Nocera
On Thu, 2015-02-19 at 21:28 -0800, Darren Hart wrote: > On Wed, Feb 18, 2015 at 09:53:44PM +0100, Bastien Nocera wrote: > > Commit message please. Added. > > Signed-off-by: Bastien Nocera > > --- > > drivers/platform/x86/thinkpad_acpi.c | 71 > > +++- > > 1 fil

Re: [ibm-acpi-devel] [PATCH 2/6] thinkpad_acpi: Factor out get/set adaptive kbd mode

2015-02-20 Thread Bastien Nocera
On Thu, 2015-02-19 at 21:22 -0800, Darren Hart wrote: > On Wed, Feb 18, 2015 at 09:53:35PM +0100, Bastien Nocera wrote: > > Please provide a commit message. There is always something to say beyond what > is > in the subject. In this case, I suggest the motivation and justification for > the > ch

Re: [ibm-acpi-devel] [PATCH 1/6] thinkpad_acpi: Remember adaptive kbd presence

2015-02-20 Thread Bastien Nocera
On Thu, 2015-02-19 at 21:08 -0800, Darren Hart wrote: > On Wed, Feb 18, 2015 at 09:53:28PM +0100, Bastien Nocera wrote: > > Rather than checking on each suspend and resume whether the laptop > > has an adaptive keyboard, check when the driver is initialised. > > Reasonable. > > > > > Signed-off-