[ibm-acpi-devel] [PATCH] thinkpad_acpi: use DEVICE_ATTR_* macros

2015-03-02 Thread Bastien Nocera
Use the DEVICE_ATTR_* macros to reduce boiler plate. Signed-off-by: Bastien Nocera --- drivers/platform/x86/thinkpad_acpi.c | 72 ++-- 1 file changed, 20 insertions(+), 52 deletions(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thin

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: use DEVICE_ATTR_* macros

2015-03-02 Thread Henrique de Moraes Holschuh
On Mon, Mar 2, 2015, at 14:40, Bastien Nocera wrote: > Use the DEVICE_ATTR_* macros to reduce boiler plate. > > Signed-off-by: Bastien Nocera Reviewed-by: Henrique de Moraes Holschuh Acked-by: Henrique de Moraes Holschuh > --- > drivers/platform/x86/thinkpad_acpi.c | 72 > ++

Re: [ibm-acpi-devel] [PATCH 3/4] thinkpad_acpi: Add adaptive_kbd_mode sysfs attr

2015-03-02 Thread Henrique de Moraes Holschuh
On Mon, Mar 2, 2015, at 10:45, Bastien Nocera wrote: > Add a sysfs attribute to allow privileged users to change the keyboard > mode. This could be used by desktop environments to change the keyboard > mode depending on the application focused, as the Windows application > does. > > Signed-off-by:

Re: [ibm-acpi-devel] [PATCH 2/4] thinkpad_acpi: Factor out get/set adaptive kbd mode

2015-03-02 Thread Henrique de Moraes Holschuh
On Mon, Mar 2, 2015, at 10:45, Bastien Nocera wrote: > Move the getting/setting of the adaptive keyboard mode to separate > functions, so that we can reuse them later through sysfs attributes. > > Signed-off-by: Bastien Nocera Acked-by: Henrique de Moraes Holschuh > --- > drivers/platform/x86

Re: [ibm-acpi-devel] [PATCH 4/4] thinkpad_acpi: Add support for more adaptive kbd buttons

2015-03-02 Thread Henrique de Moraes Holschuh
On Mon, Mar 2, 2015, at 10:45, Bastien Nocera wrote: > This commit adds new elements to the ThinkPad keymaps, and > will send key events for keys for which an input.h declaration > exists. > > Signed-off-by: Bastien Nocera Reviewed-by: Henrique de Moraes Holschuh Acked-by: Henrique de Moraes Ho

Re: [ibm-acpi-devel] [PATCH 1/4] thinkpad_acpi: Remember adaptive kbd presence

2015-03-02 Thread Henrique de Moraes Holschuh
On Mon, Mar 2, 2015, at 10:45, Bastien Nocera wrote: > Rather than checking on each suspend and resume whether the laptop > has an adaptive keyboard, check when the driver is initialised. > > Signed-off-by: Bastien Nocera Acked-by: Henrique de Moraes Holschuh > --- > drivers/platform/x86/thin

Re: [ibm-acpi-devel] Bug report - Lenovo T440s

2015-03-02 Thread Lyude
On Thu, 2015-02-19 at 15:20 +1100, Jol Valentine wrote: > Hi folks, > > I have a bug report for a Lenovo T440s. I know the "unsupported > brightness interface" has been reported numerous times, but from an > end user perspective I have two issues: > 1. once I 'logon' to the Linux desktop and

Re: [ibm-acpi-devel] Bug report - Lenovo T440s

2015-03-02 Thread Lyude
On Thu, 2015-02-19 at 15:20 +1100, Jol Valentine wrote: > Hi folks, > > I have a bug report for a Lenovo T440s. I know the "unsupported > brightness interface" has been reported numerous times, but from an > end user perspective I have two issues: > 1. once I 'logon' to the Linux desktop and

Re: [ibm-acpi-devel] Thinkpad ACPI Unsupported

2015-03-02 Thread Lyude
On Sat, 2015-02-28 at 11:17 -0300, Henrique de Moraes Holschuh wrote: > On Sun, 22 Feb 2015, Georges Giralt wrote: > > I own a brand new Lenovo E540 (20C600JHFR) fitted with a full HD LCD > > screen. > > > > I've installed Ubuntu 14.04 LTS and exploring the syslog file for > > unsupported hardw

[ibm-acpi-devel] [PATCH 1/4] thinkpad_acpi: Remember adaptive kbd presence

2015-03-02 Thread Bastien Nocera
Rather than checking on each suspend and resume whether the laptop has an adaptive keyboard, check when the driver is initialised. Signed-off-by: Bastien Nocera --- drivers/platform/x86/thinkpad_acpi.c | 37 ++-- 1 file changed, 18 insertions(+), 19 deletions(-)

[ibm-acpi-devel] [PATCH 3/4] thinkpad_acpi: Add adaptive_kbd_mode sysfs attr

2015-03-02 Thread Bastien Nocera
Add a sysfs attribute to allow privileged users to change the keyboard mode. This could be used by desktop environments to change the keyboard mode depending on the application focused, as the Windows application does. Signed-off-by: Bastien Nocera --- Documentation/laptops/thinkpad-acpi.txt | 1

[ibm-acpi-devel] [PATCH 4/4] thinkpad_acpi: Add support for more adaptive kbd buttons

2015-03-02 Thread Bastien Nocera
This commit adds new elements to the ThinkPad keymaps, and will send key events for keys for which an input.h declaration exists. Signed-off-by: Bastien Nocera --- drivers/platform/x86/thinkpad_acpi.c | 80 +++- 1 file changed, 79 insertions(+), 1 deletion(-) dif

[ibm-acpi-devel] [PATCH 2/4] thinkpad_acpi: Factor out get/set adaptive kbd mode

2015-03-02 Thread Bastien Nocera
Move the getting/setting of the adaptive keyboard mode to separate functions, so that we can reuse them later through sysfs attributes. Signed-off-by: Bastien Nocera --- drivers/platform/x86/thinkpad_acpi.c | 61 ++-- 1 file changed, 38 insertions(+), 23 deletions