Re: [ibm-acpi-devel] Unsupported brightness interface

2015-03-22 Thread Henrique de Moraes Holschuh
On Sat, Mar 7, 2015, at 17:12, Jarmila Holcova wrote: > Mar 7 20:34:47 OH-ThinkPad-Edge-E440 kernel: [ 10.725697] > thinkpad_acpi: Unsupported brightness interface, please contact > ibm-acpi-devel@lists.sourceforge.net Thanks for the report. You can ignore this error message. -- "One disk

Re: [ibm-acpi-devel] thinkpad_acpi: THERMAL ALERT

2015-03-22 Thread Henrique de Moraes Holschuh
On Fri, Mar 20, 2015, at 22:15, Rosaldo G Garcia wrote: > thinkpad_acpi: THERMAL ALERT: unknown thermal alarm received > thinkpad_acpi: unhandled HKEY event 0x6040 This message can be safely ignored. Thanks for the report! -- "One disk to rule them all, One disk to find them. One disk to bring th

Re: [ibm-acpi-devel] thinkpad_acpi unsupported brightness interface

2015-03-22 Thread Henrique de Moraes Holschuh
On Mon, Mar 2, 2015, at 16:37, Lukas Singer wrote: > does this help you? do you need more infos about my system? Thanks for the report. No, I don't any more info, you can ignore the messages safely. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the

Re: [ibm-acpi-devel] thinkpad_acpi: Unsupported brightness interface

2015-03-22 Thread Henrique de Moraes Holschuh
On Fri, Mar 20, 2015, at 10:17, Grzegorz Listwan wrote: > Mar 20 08:21:27 linux kernel: thinkpad_acpi: Unsupported brightness > interface, please contact ibm-acpi-devel@lists.sourceforge.net You can just ignore this, it is likely going to be fixed in Linux 4.1, and anyway it is to be handled by t

Re: [ibm-acpi-devel] thinkpad_acpi and X1 Carbon 3rd gen

2015-03-22 Thread Henrique de Moraes Holschuh
You will want Linux 4.1 for better Carbon X1 3rd gen support. Meanwhile, it is probably safer to just keep forcing the load of thinkpad-acpi. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the sh

Re: [ibm-acpi-devel] [patch 2/2] thinkpad_acpi: off by one in adaptive_keyboard_hotkey_notify_hotkey()

2015-03-22 Thread Henrique de Moraes Holschuh
On Wed, Mar 11, 2015, at 06:36, Dan Carpenter wrote: > This should be >= instead of > because otherwise we read one element > past the end of the hotkey_keycode_map[] array. > > The hotkey_keycode_map[] array has TPACPI_HOTKEY_MAP_LEN elements. > > Fixes: 6a68d8557084 ('thinkpad_acpi: Add support

Re: [ibm-acpi-devel] [patch 1/2] thinkpad_acpi: signedness bugs getting current_mode

2015-03-22 Thread Henrique de Moraes Holschuh
On Wed, Mar 11, 2015, at 06:34, Dan Carpenter wrote: > This needs to be signed for the error handling to work. Valid modes are > small positive integers. > > Fixes: b790ceeb0fd9 ('thinkpad_acpi: Add adaptive_kbd_mode sysfs attr') > Signed-off-by: Dan Carpenter Acked-by: Henrique de Moraes Holsc

[ibm-acpi-devel] thinkpad_acpi: Unsupported brightness interface

2015-03-22 Thread Grzegorz Listwan
Hi, I'm getting the following errors in journal when running openSUSE 13.2 on Thinkpad W540 Mar 20 08:21:27 linux kernel: ACPI: Deprecated procfs I/F for AC is loaded, please retry with CONFIG_ACPI_PROCFS_POWER cleared Mar 20 08:21:27 linux kernel: ACPI: AC Adapter [AC] (on-line) Mar 20 08:21:2

[ibm-acpi-devel] thinkpad_acpi and X1 Carbon 3rd gen

2015-03-22 Thread Major Hayden
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello there, I'm using thinkpad_acpi on a Lenovo Thinkpad X1 Carbon (3rd generation). The module only loads on my laptop with force_load=1. The module seems to check for TPACPI_ACPI_LENOVO_HKEY_HID and TPACPI_ACPI_EC_HID, both of which are present o

Re: [ibm-acpi-devel] unknown version of the HKEY interface: 0x200

2015-03-22 Thread Michael Heuberger
Ok, good to know. In that case I'll wait until these turn up. No idea for how long. Cheers Michael On 14/03/15 04:27, Henrique de Moraes Holschuh wrote: > Hi Michael! > > On Wed, 04 Mar 2015, Michael Heuberger wrote: > >> Hello everyone >> >> I just spotted these errors on the dmesg output on my

Re: [ibm-acpi-devel] [patch 1/2] thinkpad_acpi: signedness bugs getting current_mode

2015-03-22 Thread Stephen Rothwell
Hi Darren, On Sat, 14 Mar 2015 14:06:12 -0700 Darren Hart wrote: > > On Wed, Mar 11, 2015 at 12:34:50PM +0300, Dan Carpenter wrote: > > This needs to be signed for the error handling to work. Valid modes are > > small positive integers. > > > > Fixes: b790ceeb0fd9 ('thinkpad_acpi: Add adaptive_

Re: [ibm-acpi-devel] [patch 1/2] thinkpad_acpi: signedness bugs getting current_mode

2015-03-22 Thread Stephen Rothwell
Hi Darren, On Sun, 15 Mar 2015 13:46:12 +1100 Stephen Rothwell wrote: > > The people you will inconvenience more by rebasing are the developers > who write patches that are based on your tree. If you rebase under > them, they may have to rebase and fix up the patches they have already > tested

[ibm-acpi-devel] [patch 2/2] thinkpad_acpi: off by one in adaptive_keyboard_hotkey_notify_hotkey()

2015-03-22 Thread Dan Carpenter
This should be >= instead of > because otherwise we read one element past the end of the hotkey_keycode_map[] array. The hotkey_keycode_map[] array has TPACPI_HOTKEY_MAP_LEN elements. Fixes: 6a68d8557084 ('thinkpad_acpi: Add support for more adaptive kbd buttons') Signed-off-by: Dan Carpenter d

[ibm-acpi-devel] [patch 1/2] thinkpad_acpi: signedness bugs getting current_mode

2015-03-22 Thread Dan Carpenter
This needs to be signed for the error handling to work. Valid modes are small positive integers. Fixes: b790ceeb0fd9 ('thinkpad_acpi: Add adaptive_kbd_mode sysfs attr') Signed-off-by: Dan Carpenter diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index 5

[ibm-acpi-devel] thinkpad_acpi: THERMAL ALERT

2015-03-22 Thread Rosaldo G Garcia
thinkpad_acpi: THERMAL ALERT: unknown thermal alarm received thinkpad_acpi: unhandled HKEY event 0x6040 thinkpad_acpi: please report the conditions when this event happened to ibm-acpi-devel@lists.sourceforge.net thinkpad_acpi: EC reports that Thermal Table has changed Rosaldo G. Garcia GBS App

Re: [ibm-acpi-devel] [PATCH 2/4] thinkpad_acpi: Factor out get/set adaptive kbd mode

2015-03-22 Thread ibm-acpi
On Mon, Mar 2, 2015, at 10:45, Bastien Nocera wrote: > Move the getting/setting of the adaptive keyboard mode to separate > functions, so that we can reuse them later through sysfs attributes. > > Signed-off-by: Bastien Nocera Acked-by: Henrique de Moraes Holschuh > --- > drivers/platform/x86

Re: [ibm-acpi-devel] Thinkpad ACPI Unsupported

2015-03-22 Thread Georges Giralt
Hello Lyude, Sorry to respond so late. But my work had me exhausted these last days. Add to this that the laptop returned to Lenovo for repair and that's it. The first solution works a bit better than no addition to the kernel line on boot but it is still not perfect and as smooth than on windows

[ibm-acpi-devel] thinkpad_acpi unsupported brightness interface

2015-03-22 Thread Lukas Singer
hi, i have a lenovo edge e-135 notebook. i run the latest kernel 4.0 rc1 from kernel.org (the first time i built the kernel myself :-) ). i got this message on startup, it says i should contact you: [0.700364] thinkpad_acpi: ThinkPad ACPI Extras v0.25 [0.700367] thinkpad_acpi: http://ibm

[ibm-acpi-devel] Unsupported brightness interface

2015-03-22 Thread Jarmila Holcova
Hallo, my notebook Lenovo Thinkpad Edge E440 20C5A-01A, serial number NT164i2d with Ubuntu 14.04 says: Mar 7 20:34:47 OH-ThinkPad-Edge-E440 kernel: [ 10.725697] thinkpad_acpi: Unsupported brightness interface, please contact ibm-acpi-devel@lists.sourceforge.net Thanks for help. Jarmila Hol

Re: [ibm-acpi-devel] thinkpad-acpi and broadwell thinkpads

2015-03-22 Thread Yves-Alexis Perez
On ven., 2015-03-13 at 11:12 +0100, Yves-Alexis Perez wrote: > - I guess some patches need to be included to thinkpad-acpi in order to have > it > load fine on bdw Thinkpads, Is here a right place to submit them, or should > they go to linux-acpi mailing list? I failed to follow-up, but this is a