Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

2016-01-12 Thread Pavel Machek
Hi! On Mon 2016-01-11 21:03:01, Pali Rohár wrote: > On Monday 11 January 2016 20:28:00 Henrique de Moraes Holschuh wrote > > The two features are not the same (and are handled differently by the > > firmware, for whatever reason), although they do serve the same > > purpose. I don't think a thinkp

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

2016-01-12 Thread Kevin Locke
On 01/12/2016 10:20 AM, Henrique de Moraes Holschuh wrote: > On Tue, Jan 12, 2016, at 16:11, Kevin Locke wrote: >> I looked through the DSDT and SSDT AML on the T430 (which also has both >> a keyboard backlight and ThinkLight) and couldn't deduce which method >> was being invoked for Fn+Space or an

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

2016-01-12 Thread Kevin Locke
On 01/12/2016 08:07 AM, Henrique de Moraes Holschuh wrote: > On Mon, Jan 11, 2016, at 19:12, Johannes Stezenbach wrote: >> I can confirm this, my x230 has both. FWIW, BIOS hotkey >> Fn+Space cycles through off, dim backlight, full backlight >> and full thinklight. /sys/class/leds/tpacpi::thinkligh

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

2016-01-12 Thread Henrique de Moraes Holschuh
On Tue, Jan 12, 2016, at 16:11, Kevin Locke wrote: > I looked through the DSDT and SSDT AML on the T430 (which also has both > a keyboard backlight and ThinkLight) and couldn't deduce which method > was being invoked for Fn+Space or an analog to MLCG/MLCS for the > ThinkLight. However, that may

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

2016-01-12 Thread Henrique de Moraes Holschuh
On Tue, Jan 12, 2016, at 14:35, Johannes Stezenbach wrote: > On Tue, Jan 12, 2016 at 02:07:10PM -0200, Henrique de Moraes Holschuh > wrote: > > Is the ACPI AML for fn+space readable enough, or is it trapping directly > > into SMM? Because if it interacts with the traditional higher-level > > ACPI

Re: [ibm-acpi-devel] More info onsuspend / resume bug

2016-01-12 Thread jonnie o
Sorry, link got mangled: https://bugzilla.kernel.org/show_bug.cgi?id=100171 On Tuesday, 12 January 2016, 17:48, jonnie o wrote: Hi, this is a showstopper bug, widely reported, but it seems to be getting no attention from ibm-acpi developers, despite a number of people willing to test s

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

2016-01-12 Thread Henrique de Moraes Holschuh
On Tue, Jan 12, 2016, at 14:59, Darren Hart wrote: > Gah, these two threads landed next to each other in my Inbox and I didn't > pick > up the split. Apologies. > > This is queued in testing (again). Thanks! -- "One disk to rule them all, One disk to find them. One disk to bring them all an

[ibm-acpi-devel] More info onsuspend / resume bug

2016-01-12 Thread jonnie o
Hi, this is a showstopper bug, widely reported, but it seems to be getting no attention from ibm-acpi developers, despite a number of people willing to test solutions. See for example, info and thread here: https://bugzilla.kernel.org/show_bug.cgi?id=100171Is there anyone in particular we could

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

2016-01-12 Thread Darren Hart
On Mon, Jan 11, 2016 at 05:28:00PM -0200, Henrique de Moraes Holschuh wrote: > > > Henrique, so are you taking back your Ack from 10 minutes prior? > > Hmm? No, the ACK stands. > > Pavel was talking about another feature altogether, apparently: older > thinkpads did not have "keyboard backlight

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

2016-01-12 Thread Yves-Alexis Perez
On mar., 2016-01-12 at 14:07 -0200, Henrique de Moraes Holschuh wrote: > We likely need to integrate better (future work) the new backlight > control with the thinklight control and the firmware interface in the > x230. Ok so I've just checked my work X230, and I was just wrong: no ThinkLight on i

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

2016-01-12 Thread Henrique de Moraes Holschuh
On Mon, Jan 11, 2016, at 19:12, Johannes Stezenbach wrote: > On Mon, Jan 11, 2016 at 09:03:01PM +0100, Pali Rohár wrote: > > On Monday 11 January 2016 20:28:00 Henrique de Moraes Holschuh wrote > > > The two features are not the same (and are handled differently by the > > > firmware, for whatever

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

2016-01-12 Thread Henrique de Moraes Holschuh
On Mon, Jan 11, 2016, at 18:03, Pali Rohár wrote: > On Monday 11 January 2016 20:28:00 Henrique de Moraes Holschuh wrote > > The two features are not the same (and are handled differently by the > > firmware, for whatever reason), although they do serve the same > > purpose. I don't think a thinkpa