Re: [ibm-acpi-devel] platform/x86/thinkpad_acpi: Adjustments for four function implementations

2017-12-19 Thread Andy Shevchenko
On Tue, Dec 19, 2017 at 6:23 PM, SF Markus Elfring wrote: >>> Delete an error message for a failed memory allocation in three functions >> >> This one is questionable since it prints error messages at ->init() stage. >> I would rather not touch this. > > Do you find the Linux allocation failure

Re: [ibm-acpi-devel] [PATCH 2/3 v6] battery: Add the ThinkPad "Not Charging" quirk

2017-12-19 Thread Rafael J. Wysocki
On Tue, Dec 19, 2017 at 3:34 PM, Andy Shevchenko wrote: > On Mon, Dec 18, 2017 at 7:31 PM, Rafael J. Wysocki wrote: >> On Mon, Dec 18, 2017 at 1:36 PM, Andy Shevchenko >> wrote: >>> On Mon, Dec 18, 2017 at 12:21 PM, Ognjen Galić wrote: On 16/12/2017, Rafael J. Wysocki wrote: >>> > I w

Re: [ibm-acpi-devel] [PATCH 0/2] platform/x86/thinkpad_acpi: Adjustments for four function implementations

2017-12-19 Thread Andy Shevchenko
On Mon, Dec 18, 2017 at 11:26 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 18 Dec 2017 22:23:45 +0100 > > Two update suggestions were taken into account > from static source code analysis. > > Markus Elfring (2): > Delete an error message for a failed memory allocation in th

Re: [ibm-acpi-devel] [PATCH 2/3 v6] battery: Add the ThinkPad "Not Charging" quirk

2017-12-19 Thread Andy Shevchenko
On Mon, Dec 18, 2017 at 7:31 PM, Rafael J. Wysocki wrote: > On Mon, Dec 18, 2017 at 1:36 PM, Andy Shevchenko > wrote: >> On Mon, Dec 18, 2017 at 12:21 PM, Ognjen Galić wrote: >>> On 16/12/2017, Rafael J. Wysocki wrote: >> I would reorder it as the first patch in the series, then, because t