Re: [ibm-acpi-devel] ThinkPad T480s & LED_MUTE, LED_MICMUTE

2018-06-16 Thread Takashi Iwai
On Sat, 16 Jun 2018 17:43:09 +0200, Pali Rohár wrote: > > On Saturday 16 June 2018 09:05:41 Takashi Iwai wrote: > > On Fri, 15 Jun 2018 21:09:59 +0200, > > Pali Rohár wrote: > > > > > > On Friday 15 June 2018 14:51:47 Takashi Iwai wrote: > > > > On Fri, 08 Jun 2018 13:10:57 +0200, > > > > Pali Ro

Re: [ibm-acpi-devel] ThinkPad T480s & LED_MUTE, LED_MICMUTE

2018-06-16 Thread Pavel Machek
Hi! > > Question is if we want flexibility or security. > > For thinkpad-acpi, it is security by default. Flexibility is allowed as > *compile*-time (Kconfig) option, and only as long as it defaults to > secure *and* the help text is very explicit at instructing distros to > NOT enable this opti

Re: [ibm-acpi-devel] ThinkPad T480s & LED_MUTE, LED_MICMUTE

2018-06-16 Thread Pali Rohár
On Saturday 16 June 2018 09:05:41 Takashi Iwai wrote: > On Fri, 15 Jun 2018 21:09:59 +0200, > Pali Rohár wrote: > > > > On Friday 15 June 2018 14:51:47 Takashi Iwai wrote: > > > On Fri, 08 Jun 2018 13:10:57 +0200, > > > Pali Rohár wrote: > > > > > > > > Hi! With up-to-date thinkpad_acpi.ko driver

[ibm-acpi-devel] unknown possible thermal alarm or keyboard event received

2018-06-16 Thread Vishal Verma
Jun 12 10:39:02 thinkpad kernel: [279349.366822] ACPI: Waking up from system sleep state S3 Jun 12 10:39:02 thinkpad kernel: [279349.876770] thinkpad_acpi: unknown possible thermal alarm or keyboard event received Jun 12 10:39:02 thinkpad kernel: [279349.876773] thinkpad_acpi: unhandled HKEY event

[ibm-acpi-devel] unhandled HKEY event 0x6032, please report the conditions when this event happened

2018-06-16 Thread Adam Rabjerg
Just found this in my dmesg, it asked me to report so hre it is. Hope i can help. this is everything before and after: [56811.353116] thinkpad_acpi: unknown possible thermal alarm or keyboard event received [56811.353122] thinkpad_acpi: unhandled HKEY event 0x6032 [56811.353125] thinkpad_acpi: pl

[ibm-acpi-devel] unhandled HKEY event 0x60b0 / 0x60b1

2018-06-16 Thread Matthias Lohr
Hey, my dmesg output is full of spam like [ 1793.717386] thinkpad_acpi: unknown possible thermal alarm or keyboard event received [ 1793.717394] thinkpad_acpi: unhandled HKEY event 0x60b0 [ 1793.717399] thinkpad_acpi: please report the conditions when this event happened to ibm-acpi-devel@lists.s

[ibm-acpi-devel] unhandled key

2018-06-16 Thread Matthias Paulmier
Hello, I've had this message in my dmesg logs when hitting a key on my laptop : [529401.717204] thinkpad_acpi: unknown possible thermal alarm or keyboard event received [529401.717209] thinkpad_acpi: unhandled HKEY event 0x6020 [529401.717211] thinkpad_acpi: please report the conditions when t

[ibm-acpi-devel] [PATCH] thinkpad_acpi: use consistent return values

2018-06-16 Thread Thomas Weißschuh
The error codes for ACPI failures when setting battery start and stop thresholds were gobbling the real error code and also inconsistent. Signed-off-by: Thomas Weißschuh --- drivers/platform/x86/thinkpad_acpi.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/driver

[ibm-acpi-devel] [PATCH] thinkpad_acpi: don't overwrite supported battery operations

2018-06-16 Thread Thomas Weißschuh
Previously the struct containing the supported operations for all batteries was zeroed every time a battery was probed. This prevented all batteries except the lastly probed one from being configured. Signed-off-by: Thomas Weißschuh --- drivers/platform/x86/thinkpad_acpi.c | 5 - 1 file chan

[ibm-acpi-devel] ACPI message requests report

2018-06-16 Thread Alex Gontmakher
Repro instructions: - Lenovo Carbon X1, 6th gen - OS: Linux newgro 4.15.0-22-generic #24-Ubuntu SMP Wed May 16 12:15:17 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux - The message appears in dmesg when I close and re-open the laptop lid (i.e., apparently when it tries to enter sleep mode). [ 46.803995

[ibm-acpi-devel] report

2018-06-16 Thread Gianni Cardini
executing a dmesg I have found the following after a resume [ 574.499328] ACPI: Waking up from system sleep state S3 [ 574.773704] thinkpad_acpi: unknown possible thermal alarm or keyboard event received [ 574.773764] thinkpad_acpi: temperatures (Celsius): 0 48 0 0 0 0 33 29 [ 574.773771] thi

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: use consistent return values

2018-06-16 Thread Henrique de Moraes Holschuh
On Sat, 16 Jun 2018, Thomas Weißschuh wrote: > The error codes for ACPI failures when setting battery start and stop > thresholds were gobbling the real error code and also inconsistent. Well, we do not care for ACPI failure codes (other than the fact it failed): we care for proper errno return to

Re: [ibm-acpi-devel] ThinkPad T480s & LED_MUTE, LED_MICMUTE

2018-06-16 Thread Henrique de Moraes Holschuh
On Sat, 16 Jun 2018, Pavel Machek wrote: > Question is if we want flexibility or security. For thinkpad-acpi, it is security by default. Flexibility is allowed as *compile*-time (Kconfig) option, and only as long as it defaults to secure *and* the help text is very explicit at instructing distros

Re: [ibm-acpi-devel] ThinkPad T480s & LED_MUTE, LED_MICMUTE

2018-06-16 Thread Pavel Machek
Hi! On Fri 2018-06-15 20:36:28, Henrique de Moraes Holschuh wrote: > On Fri, 15 Jun 2018, Pali Rohár wrote: > > This means that kernel should not export any led class device. Or when > > exported, then "set" operation should always fail. > > "not export" is right. > > > > 2. Otherwise implement

Re: [ibm-acpi-devel] ThinkPad T480s & LED_MUTE, LED_MICMUTE

2018-06-16 Thread Takashi Iwai
On Fri, 15 Jun 2018 21:09:59 +0200, Pali Rohár wrote: > > On Friday 15 June 2018 14:51:47 Takashi Iwai wrote: > > On Fri, 08 Jun 2018 13:10:57 +0200, > > Pali Rohár wrote: > > > > > > Hi! With up-to-date thinkpad_acpi.ko driver on ThinkPad T480s I'm seeing > > > a strange behavior of LEDs which a