Re: [ibm-acpi-devel] [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it)

2018-11-26 Thread Andy Shevchenko
On Mon, Nov 26, 2018 at 7:14 PM Takashi Iwai wrote: > > Hi, > > this is patch series I've hacked after useful conversation with > Pavel. Basically this adds a new LED trigger audio-mute and > audio-micmute, and convert the HD-audio driver and the platform > drivers to use the LED trigger instead

Re: [ibm-acpi-devel] [PATCH 3/6] platform/x86: thinkpad_acpi: Add audio mute LED classdev support

2018-11-26 Thread Andy Shevchenko
On Mon, Nov 26, 2018 at 7:13 PM Takashi Iwai wrote: > > In the upcoming change, the binding of audio mute / mic-mute LED > controls will be switched with LED trigger. This patch is the last > piece of preparation: adding the audio mute / mic-mute LED class > devices to thinkpad_acpi driver. > > T

Re: [ibm-acpi-devel] [PATCH 1/6] leds: trigger: Introduce audio mute LED trigger

2018-11-26 Thread Andy Shevchenko
On Mon, Nov 26, 2018 at 7:14 PM Takashi Iwai wrote: > > This patch adds a new LED trigger for coupling the audio mixer change > with the LED on laptops or other devices. Currently there are two > trigger types, "audio-mute" and "audio-micmute". > > The audio driver triggers the LED brightness cha

Re: [ibm-acpi-devel] [PATCH 1/6] leds: trigger: Introduce audio mute LED trigger

2018-11-26 Thread Jacek Anaszewski
Hi Takashi, Thank you for the patch set. On 11/26/2018 06:11 PM, Takashi Iwai wrote: > This patch adds a new LED trigger for coupling the audio mixer change > with the LED on laptops or other devices. Currently there are two > trigger types, "audio-mute" and "audio-micmute". > > The audio drive

[ibm-acpi-devel] [PATCH 6/6] platform/x86: thinkpad_acpi: Drop superfluous exported function

2018-11-26 Thread Takashi Iwai
Since we've switched to the LED trigger for binding with HD-audio, we can drop the exported function as well as the whole linux/thinkpad_acpi.h. The own TPACPI_LED_MUTE and TPACPI_LED_MICMUTE definitions are replaced with the identical ones for LEDS, i.e. LED_AUDIO_MUTE and LED_AUDIO_MICMUTE, resp

[ibm-acpi-devel] [PATCH 0/6] Introduce audio-mute LED trigger (and conversions to it)

2018-11-26 Thread Takashi Iwai
Hi, this is patch series I've hacked after useful conversation with Pavel. Basically this adds a new LED trigger audio-mute and audio-micmute, and convert the HD-audio driver and the platform drivers to use the LED trigger instead of the ugly direct dynamic symbol binding. The latest version of

[ibm-acpi-devel] [PATCH 4/6] ALSA: hda - Support led audio trigger

2018-11-26 Thread Takashi Iwai
Now all relevant platform drivers are providing the LED audio trigger, we can switch the mute LED control with the LED trigger, finally. For the mic-mute LED trigger, a common fixup function, snd_hda_gen_fixup_micmute_led(), is provided to be called for the corresponding quirk entries. This sets

[ibm-acpi-devel] [PATCH 3/6] platform/x86: thinkpad_acpi: Add audio mute LED classdev support

2018-11-26 Thread Takashi Iwai
In the upcoming change, the binding of audio mute / mic-mute LED controls will be switched with LED trigger. This patch is the last piece of preparation: adding the audio mute / mic-mute LED class devices to thinkpad_acpi driver. Two devices, tpacpi::mute and tpacpi::micmute, will be added for co

[ibm-acpi-devel] [PATCH 2/6] platform/x86: dell-laptop: Add micmute LED trigger support

2018-11-26 Thread Takashi Iwai
This patch adds the LED trigger support for audio mic-mute control. As of this patch, the LED device isn't tied with the audio driver, and can be changed via user-space at "dell::micmute" sysfs entry. The binding with HD-audio is still done via the existing exported dell_micmute_led_set(). It wil

[ibm-acpi-devel] [PATCH 1/6] leds: trigger: Introduce audio mute LED trigger

2018-11-26 Thread Takashi Iwai
This patch adds a new LED trigger for coupling the audio mixer change with the LED on laptops or other devices. Currently there are two trigger types, "audio-mute" and "audio-micmute". The audio driver triggers the LED brightness change via ledtrig_audio_set() call with the proper type (either mu

[ibm-acpi-devel] [PATCH 5/6] platform/x86: dell-laptop: Drop superfluous exported function

2018-11-26 Thread Takashi Iwai
Since we've switched to the LED trigger for binding with HD-audio, we can drop the exported function as well as the whole linux/dell-led.h. Signed-off-by: Takashi Iwai --- drivers/platform/x86/dell-laptop.c | 22 +- include/linux/dell-led.h | 7 --- 2 files cha